[GitHub] incubator-predictionio issue #421: Elasticsearch 5.x singleton client with a...

2017-08-23 Thread mars
Github user mars commented on the issue: https://github.com/apache/incubator-predictionio/pull/421 🏁 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] incubator-predictionio issue #421: Elasticsearch 5.x singleton client with a...

2017-08-23 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio/pull/421 > I addressed all your Scala style & usage suggestions. 👍 > Still need to take care of the threadsafety issue with the singleton client. Yes, I'm

[GitHub] incubator-predictionio issue #421: Elasticsearch 5.x singleton client with a...

2017-08-23 Thread mars
Github user mars commented on the issue: https://github.com/apache/incubator-predictionio/pull/421 Based on these [Scala Concurrency/Thread Safety docs](https://twitter.github.io/scala_school/concurrency.html#danger), I believe simply annotating `@volatile` will cause the