[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

2017-10-18 Thread pferrel
Github user pferrel commented on the issue: https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6 Making templates easier for users doing upgrades is extremely important IMO. Getting them working with 0.12.0 is first priority and I for one appr

[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

2017-10-18 Thread pferrel
Github user pferrel commented on the issue: https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6 the PR is fine, but this can be solved partially with the current templates. For instance why not support both the previous defaults (those used in 0.11.

[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

2017-10-18 Thread takezoe
Github user takezoe commented on the issue: https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6 @pferrel It looks to be impossible to solve in the current template mechanism. I believe that keeping templates for the latest and default stack is the b

[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

2017-10-17 Thread pferrel
Github user pferrel commented on the issue: https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6 Also the build.sbt locks people into the latest versions of Spark, etc. So this template will no longer work with services installed with pio-0.11.0 incl

[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

2017-10-17 Thread pferrel
Github user pferrel commented on the issue: https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6 Upgrading HDFS may also come with a conversion process if data is stored there. Not sure. ---

[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

2017-10-17 Thread pferrel
Github user pferrel commented on the issue: https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6 @shimamoto @takezoe this does not support all the pio build options and so will not work if pio is built in a different way from this template. We need to

[GitHub] incubator-predictionio-template-java-ecom-recommender issue #6: 0.12.0-incub...

2017-10-17 Thread shimamoto
Github user shimamoto commented on the issue: https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6 I have checked it works. @takezoe Can you review this PR? ---