Github user marevol commented on the issue:
https://github.com/apache/incubator-predictionio/pull/352
Fixed problems for ES5 support.
Integration tests will be passed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user marevol commented on the issue:
https://github.com/apache/incubator-predictionio/pull/352
Almost all failures are fixed.
For remaining problem, integration tests use PDT time, but elasticsearch
uses UTC time.
Therefore, the following assertion is failed in
Github user marevol commented on the issue:
https://github.com/apache/incubator-predictionio/pull/352
For integration tests of ES5, 3 tests are failed on
[move-storages-es5]...(https://github.com/marevol/incubator-predictionio/tree/move-storages-es5)
I'll check them today.
Github user marevol commented on the issue:
https://github.com/apache/incubator-predictionio/pull/352
Correct.
I'm working on integration tests for ES5. To use ES5 as default, should I
create a new PR?
For UR, @haginot and co-workers work on ES5 support. They will
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/352
So basically this will build PIO with the same behavior as before, and pack
the ES5 support as an extra JAR during `make-distribution.sh` in `lib/extra`.
In order to use ES5, one
Github user marevol commented on the issue:
https://github.com/apache/incubator-predictionio/pull/352
Fixed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user marevol commented on the issue:
https://github.com/apache/incubator-predictionio/pull/352
I'll fix it today...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/352
Hey @marevol are you working on fixing the integration tests? I can help if
you are not already doing so.
---
If your project is set up for it, you can reply to this email and have
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/352
Hi @marevol , I have finished working on PIO-53, which allows unit and
integration tests be updated per commit and removed reliance on a cached Docker
image on Docker Hub. You might
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/352
Adding @haginot to this thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
10 matches
Mail list logo
