Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/412
Created https://issues.apache.org/jira/browse/PIO-110 and
https://issues.apache.org/jira/browse/PIO-111 as follow-ups. Thanks @mars for
the feature and @takezoe for the feedback!
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/412
LGTM. Great work @mars !
Agree with @takezoe 's comments. I think there are a few follow up tasks we
should do.
1. Refactor common code that exists in both
Github user mars commented on the issue:
https://github.com/apache/incubator-predictionio/pull/412
@takezoe thank you for the feedback. As a relatively-new Scala programmer I
really appreciate this kind of review.
I am a bit hesitant to make these changes. I'm trying to
