Github user liningalex closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/387
---
Github user liningalex commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120186661
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCChannels.scala
---
@@ -0,0 +1,56 @@
+/*
+
Github user liningalex commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120186563
--- Diff:
data/src/main/scala/org/apache/predictionio/data/storage/Storage.scala ---
@@ -306,9 +306,18 @@ object Storage extends Logging
Github user liningalex commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120186635
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCAccessKeys.scala
---
@@ -0,0 +1,45 @@
+/*
Github user liningalex commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120186730
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCEvaluationInstances.scala
---
@@ -0,0 +1,52 @@
Github user liningalex commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120186758
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCModels.scala
---
@@ -0,0 +1,56 @@
+/*
+ *
Github user liningalex commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120186611
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/jdbc/JDBCEvaluationInstances.scala
---
@@ -29,8 +29,9 @@
Github user liningalex commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120186601
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/jdbc/JDBCChannels.scala
---
@@ -29,14 +29,15 @@ class
Github user liningalex commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120186994
--- Diff:
core/src/main/scala/org/apache/predictionio/workflow/CreateServer.scala ---
@@ -198,7 +198,7 @@ object CreateServer extends
Github user liningalex commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120186512
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/StorageClient.scala
---
@@ -0,0 +1,53 @@
+/*
+
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151665
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCChannels.scala
---
@@ -0,0 +1,56 @@
+/*
+ *
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151628
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCApps.scala
---
@@ -0,0 +1,59 @@
+/*
+ *
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120154775
--- Diff:
core/src/main/scala/org/apache/predictionio/workflow/CreateServer.scala ---
@@ -198,7 +198,7 @@ object CreateServer extends
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151427
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/jdbc/JDBCEvaluationInstances.scala
---
@@ -29,8 +29,9 @@ class
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151860
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCModels.scala
---
@@ -0,0 +1,56 @@
+/*
+ *
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151731
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCEngineInstances.scala
---
@@ -0,0 +1,55 @@
+/*
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151544
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCAccessKeys.scala
---
@@ -0,0 +1,45 @@
+/*
+
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120153688
--- Diff:
data/src/main/scala/org/apache/predictionio/data/storage/Storage.scala ---
@@ -306,9 +306,18 @@ object Storage extends Logging {
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120150849
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/jdbc/JDBCChannels.scala
---
@@ -29,14 +29,15 @@ class
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151795
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/OJDBCEvaluationInstances.scala
---
@@ -0,0 +1,52 @@
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151484
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/jdbc/JDBCModels.scala
---
@@ -28,15 +28,18 @@ import
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120151362
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/jdbc/JDBCEngineInstances.scala
---
@@ -29,8 +29,9 @@ class
Github user takezoe commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120147041
--- Diff:
data/src/main/scala/org/apache/predictionio/data/storage/Storage.scala ---
@@ -306,9 +306,18 @@ object Storage extends Logging {
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/387#discussion_r120063752
--- Diff:
storage/jdbc/src/main/scala/org/apache/predictionio/data/storage/ojdbc/StorageClient.scala
---
@@ -0,0 +1,53 @@
+/*
+ *
GitHub user liningalex opened a pull request:
https://github.com/apache/incubator-predictionio/pull/387
Oracle databas supports
This pull request is to supports Oracle database. please review. thanks.
You can merge this pull request into a Git repository by running:
$ git pull
25 matches
Mail list logo
