[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-predictionio/pull/421 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134419406 --- Diff: storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESPEvents.scala --- @@ -107,37 +107,32

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134416803 --- Diff: storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/StorageClient.scala --- @@ -18,27 +18,84

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134398339 --- Diff: core/src/main/scala/org/apache/predictionio/workflow/CleanupFunctions.scala --- @@ -0,0 +1,65 @@ +/* + * Licensed to the

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134399760 --- Diff: data/src/main/scala/org/apache/predictionio/data/storage/Storage.scala --- @@ -461,4 +463,11 @@ object Storage extends Logging {

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134417513 --- Diff: storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/StorageClient.scala --- @@ -18,27 +18,84

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134419379 --- Diff: storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESPEvents.scala --- @@ -107,37 +107,32

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134399019 --- Diff: core/src/main/scala/org/apache/predictionio/workflow/CleanupFunctions.scala --- @@ -0,0 +1,65 @@ +/* + * Licensed to the

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134419425 --- Diff: storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/ESPEvents.scala --- @@ -107,37 +107,32

[GitHub] incubator-predictionio pull request #421: Elasticsearch 5.x singleton client...

2017-08-22 Thread mars
Github user mars commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/421#discussion_r134630517 --- Diff: storage/elasticsearch/src/main/scala/org/apache/predictionio/data/storage/elasticsearch/StorageClient.scala --- @@ -18,27 +18,84 @@