Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/270
updating to new pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user pferrel opened a pull request:
https://github.com/apache/incubator-predictionio/pull/273
PIO-20 Merge ActionML fork
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pferrel/PredictionIO actionml-merge
Alternatively
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/273#discussion_r74325732
--- Diff: manifest.json ---
@@ -1 +1,2 @@
-{"id":"ipNrDsdxAtsDjZHRSAqfgOTL0PztjuR3","version":"b6a10
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/273#discussion_r74712711
--- Diff: bin/install.sh ---
@@ -102,9 +103,8 @@ if [[ "$OS" = "Linux" && $(cat /proc/1/cgroup) ==
*cpu:/doc
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/273#discussion_r74712571
--- Diff: RELEASE.md ---
@@ -1,26 +1,58 @@
-##Release Notes and News
+#Release Notes and News
**Note:** For upgrade
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/273#discussion_r74690832
--- Diff: build.sbt ---
@@ -19,7 +19,7 @@ import UnidocKeys._
name := "pio"
-version in ThisBuild := "
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793283
--- Diff:
examples/scala-parallel-similarproduct/filterbyyear/src/main/scala/DataSource.scala
---
@@ -13,16 +16,21 @@ import
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793199
--- Diff: data/src/main/scala/io/prediction/data/storage/Models.scala ---
@@ -78,3 +78,6 @@ class ModelSerializer extends CustomSerializer
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793171
--- Diff:
core/src/test/scala/io/prediction/core/SelfCleaningDataSourceTest.scala ---
@@ -0,0 +1,78 @@
+package io.prediction.core.test
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793218
--- Diff:
data/src/main/scala/io/prediction/data/storage/hbase/HBPEvents.scala ---
@@ -109,4 +109,25 @@ class HBPEvents(client: HBClient
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793210
--- Diff: data/src/main/scala/io/prediction/data/storage/PEvents.scala ---
@@ -179,4 +179,8 @@ trait PEvents extends Serializable
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793183
--- Diff: data/build.sbt ---
@@ -44,9 +44,9 @@ libraryDependencies ++= Seq(
"org.json4s" %% &quo
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793228
--- Diff:
data/src/main/scala/io/prediction/data/storage/jdbc/JDBCPEvents.scala ---
@@ -155,6 +156,22 @@ class JDBCPEvents(client: String
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793019
--- Diff: README.md ---
@@ -76,21 +71,17 @@
Status](https://gemnasium.com/PredictionIO/PredictionIO.svg)](https://gemnasium.
Keep
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793029
--- Diff: RELEASE.md ---
@@ -65,7 +106,9 @@ March 4th, 2015 | [Release
Notes](https://predictionio.atlassian.net/jira/secure
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793137
--- Diff: core/build.sbt ---
@@ -27,13 +27,14 @@ libraryDependencies ++= Seq(
"io.spray" %% "spray-routi
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793121
--- Diff: build.sbt ---
@@ -193,3 +193,8 @@ concurrentRestrictions in Global := Seq(
Tags.limitAll( 1
GitHub user pferrel opened a pull request:
https://github.com/apache/incubator-predictionio/pull/269
Master
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pferrel/PredictionIO master
Alternatively you can review and apply
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73793249
--- Diff: examples/scala-parallel-similarproduct/filterbyyear/build.sbt ---
@@ -7,6 +7,6 @@ name := "template-scala-parallel-similarpr
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/269
I think this is ready for review.
The main things here are changes to support trimming data in the PEvents
and LEvents somewhat like the formerly experimental Cleanup App
GitHub user pferrel opened a pull request:
https://github.com/apache/incubator-predictionio/pull/270
PIO-20 Merge ActionML fork
trying the PR from my local version of `develop`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73982644
--- Diff:
examples/scala-parallel-similarproduct/filterbyyear/src/main/scala/DataSource.scala
---
@@ -1,28 +1,54
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/269
Notice the PR is from AML Master to Apache develop. When I fix the license
and package names they show up as a diff even though the licenses are changed
in the develop branch
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/269#discussion_r73806373
--- Diff: build.sbt ---
@@ -18,9 +18,9 @@ import UnidocKeys._
name := "pio"
-version in ThisBuild
Github user pferrel commented on a diff in the pull request:
https://github.com/apache/incubator-predictionio/pull/273#discussion_r74152214
--- Diff: conf/pio-env.sh.template ---
@@ -53,7 +36,7 @@ PIO_FS_TMPDIR=$PIO_FS_BASEDIR/tmp
# storage facilities. Default values
Github user pferrel closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/269
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/273
inactive, this has been merged with develop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user pferrel closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/273
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user pferrel commented on the pull request:
https://github.com/apache/incubator-predictionio/commit/7615b4708dae6ae30657d51194a33416a5509d1f#commitcomment-20656303
-1
https://issues.apache.org/jira/browse/PIO-51?jql=project%20%3D%20PIO
I thought we had decided
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/336
Well I like passing in only what is used so the general idea seems good.
But does the use of lib fit conventions? As I recall lib is used for managed
dependencies but in this case
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/336
This would imply too that a single assembly is not enough and you'd have to
deploy the entire pio directory structure to any machine that runs it, right?
This in turn means
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/336
This may be ok to stage to the feature/es5 branch but IMO should not be
merged with master for release yet.
The technique of linking and creating an assembly with both es1
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/336
@marevol you might want to search for "plugins" in the PIO code I think it
may already put those jars in the SparkSubmit params
This does seem like a better sol
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/336
@marevol Thanks this looks very promising! How do you configure PIO to use
1.x vs 5.x, Templates may need to look at the config or supply their own.
The UR uses the REST API
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/291
merged with develop
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/325
Do we have Alpine as the container OS? This seems to be the standard Docker
is pushing but this looks like Debian.
BTW You can merge this yourself now. We, as a group, like
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/issues/327
This tagged release does not work with Apache-PIO. You have to install
0.9.7-aml using instructions here: http://actionml.com/docs/install
The Universal Recommender
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/328
@chanlee514 said:
If the absolute filepath is the same in the machines (since SHA-1 hash of
filepath is used as engineVersion), there would be no changes in the above
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/328
ok, this looks like a good step
@dszeto we would not do `pio build` we would do `sbt build` in the
directory that has the template and this is fine IMO. The confusion users
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/328
@dszeto asked: "Do you currently have any production deployments that rely
heavily on engine IDs and versions? That would be a bigger immediate concern
regarding this c
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/328
Actually the manifest may be gone but the requirement of the same absolute
path is maintained, I believe. A hash of the path to the template code is used
to create the id and is part
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/391
Actually we already have an AWS AMI with HBase 1.2.6 that works fine
without any changes as far as we have seen and we do run automated tests.
Since this will require
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6
@shimamoto @takezoe this does not support all the pio build options and so
will not work if pio is built in a different way from this template. We need
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6
Upgrading HDFS may also come with a conversion process if data is stored
there. Not sure.
---
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6
Also the build.sbt locks people into the latest versions of Spark, etc. So
this template will no longer work with services installed with pio-0.11.0
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6
the PR is fine, but this can be solved partially with the current
templates. For instance why not support both the previous defaults (those used
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio-template-java-ecom-recommender/pull/6
Making templates easier for users doing upgrades is extremely important IMO.
Getting them working with 0.12.0 is first priority and I for one
47 matches
Mail list logo
