Github user chanlee514 commented on the issue:
https://github.com/apache/incubator-predictionio/pull/328
@pferrel: Yes the hash of engine directory path is used as engineVersion
(which kind of acts as the id).
However, I'm working on making updates to this PR so that users
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/328
Actually the manifest may be gone but the requirement of the same absolute
path is maintained, I believe. A hash of the path to the template code is used
to create the id and is part
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/328
@chanlee514 said:
If the absolute filepath is the same in the machines (since SHA-1 hash of
filepath is used as engineVersion), there would be no changes in the above
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/328
@chanlee514 @pferrel I have moved the discussion to dev@.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/328
@dszeto asked: "Do you currently have any production deployments that rely
heavily on engine IDs and versions? That would be a bigger immediate concern
regarding this change."
Github user pferrel commented on the issue:
https://github.com/apache/incubator-predictionio/pull/328
ok, this looks like a good step
@dszeto we would not do `pio build` we would do `sbt build` in the
directory that has the template and this is fine IMO. The confusion users
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/328
@pferrel For `pio build` we probably can enhance it such that it can take a
working directory for compilation to run. If we look at some other build tools,
they also rely on having
Github user chanlee514 commented on the issue:
https://github.com/apache/incubator-predictionio/pull/328
@pferrel: I agree, and that would be possible with a general metadata
registry server which would be the next step. The reason I started by removing
manifest.json is because the
Github user chanlee514 commented on the issue:
https://github.com/apache/incubator-predictionio/pull/328
Right now, the commands throw java.io.FileNotFoundException regarding
engine.json. May be better if we throw an error message saying the commands
should be executed inside engine
