[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

2017-08-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/incubator-predictionio/pull/425 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

2017-08-26 Thread takezoe
Github user takezoe commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/425#discussion_r135380673 --- Diff: core/src/main/scala/org/apache/predictionio/controller/PAlgorithm.scala --- @@ -115,15 +115,12 @@ abstract class PAlgorithm[PD,

[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

2017-08-25 Thread shimamoto
Github user shimamoto commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/425#discussion_r135187599 --- Diff: storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBEventsUtil.scala --- @@ -376,32 +375,30 @@ object

[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

2017-08-25 Thread shimamoto
Github user shimamoto commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/425#discussion_r135181421 --- Diff: data/src/main/scala/org/apache/predictionio/data/api/Webhooks.scala --- @@ -115,22 +107,22 @@ private[predictionio] object

[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

2017-08-25 Thread shimamoto
Github user shimamoto commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/425#discussion_r135187633 --- Diff: storage/hbase/src/main/scala/org/apache/predictionio/data/storage/hbase/HBEventsUtil.scala --- @@ -376,32 +375,30 @@ object

[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

2017-08-25 Thread shimamoto
Github user shimamoto commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/425#discussion_r135191103 --- Diff: data/src/main/scala/org/apache/predictionio/data/api/Webhooks.scala --- @@ -115,22 +107,22 @@ private[predictionio] object

[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

2017-08-25 Thread shimamoto
Github user shimamoto commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/425#discussion_r135175043 --- Diff: core/src/main/scala/org/apache/predictionio/controller/PAlgorithm.scala --- @@ -115,15 +115,12 @@ abstract class PAlgorithm[PD,

[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

2017-08-25 Thread shimamoto
Github user shimamoto commented on a diff in the pull request: https://github.com/apache/incubator-predictionio/pull/425#discussion_r135180795 --- Diff: data/src/main/scala/org/apache/predictionio/data/api/Webhooks.scala --- @@ -62,22 +53,23 @@ private[predictionio] object

[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

2017-08-24 Thread takezoe
GitHub user takezoe reopened a pull request: https://github.com/apache/incubator-predictionio/pull/425 [PIO-110] Refactoring You can merge this pull request into a Git repository by running: $ git pull https://github.com/takezoe/incubator-predictionio refactor-common-code

[GitHub] incubator-predictionio pull request #425: [PIO-110] Refactoring

2017-08-24 Thread takezoe
Github user takezoe closed the pull request at: https://github.com/apache/incubator-predictionio/pull/425 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if