+1
Best,
Hang
Enrico Olivelli 于2022年1月13日周四 14:20写道：
>
> +1
>
> Enrico
>
> Il Gio 13 Gen 2022, 06:01 Joe F ha scritto:
>
> > +1
> >
> > On Wed, Jan 12, 2022 at 3:52 PM Aloys Zhang wrote:
> >
> > > +1
> > >
> > > 陳智弘 于2022年1月12日周三 10:19写道：
> > >
> > > > +1
> > > >
> > > > Haiting Jiang 於 2022
+1
Enrico
Il Gio 13 Gen 2022, 06:01 Joe F ha scritto:
> +1
>
> On Wed, Jan 12, 2022 at 3:52 PM Aloys Zhang wrote:
>
> > +1
> >
> > 陳智弘 于2022年1月12日周三 10:19写道：
> >
> > > +1
> > >
> > > Haiting Jiang 於 2022年1月12日 週三 09:50 寫道：
> > >
> > > > +1
> > > >
> > > > On 2022/01/12 01:44:21 PengHui Li wr
Hello Enrico,
On 06/01/2022 17:07, Enrico Olivelli wrote:
> Benoit,
>
> Il Gio 6 Gen 2022, 10:54 Benoit TELLIER ha scritto:
>
>> Hello Pulsar folks!
>>
>> I am a member of the Apache James PMC, whose maintain the Java Apache
>> Mail Extensible Server (for the intimates hence James). The Distribut
+1
On Wed, Jan 12, 2022 at 3:52 PM Aloys Zhang wrote:
> +1
>
> 陳智弘 于2022年1月12日周三 10:19写道：
>
> > +1
> >
> > Haiting Jiang 於 2022年1月12日 週三 09:50 寫道：
> >
> > > +1
> > >
> > > On 2022/01/12 01:44:21 PengHui Li wrote:
> > > > +1
> > > >
> > > > Penghui
> > > >
> > > > On Wed, Jan 12, 2022 at 8:39 A
I am not sure if the fix in
https://github.com/apache/pulsar/commit/04b5da0f95794259694cc781e8960b7e52fac06b
is sufficient.
I would like to see there is at least one integration test that covers
running functions on k8s to ensure we don't break the basic stuff.
- Sijie
On Fri, Jan 7, 2022 at 9:5
I'm not sure if the bots can detect if the change is a Java client change,
maybe based on the changes introduced in which directory.
The main headache here is missing it. If there are some mechanisms that can
remind us.
It will be great. Looks like
"hey, new changes introduced in Java client, you
+1 (binding)
This is a behavior change, which we should highlight in the release note.
Penghui
On Thu, Jan 13, 2022 at 12:44 AM Chris Herzog
wrote:
> +1 (non)
>
>
> On Tue, Jan 11, 2022 at 9:46 PM r...@apache.org
> wrote:
>
> > +1 (non-binding)
> >
> > --
> > Thanks
> > Xiaolong Ran
> >
> > m
+1
Penghui
On Thu, Jan 13, 2022 at 7:54 AM Aloys Zhang wrote:
> +1
>
> Michael Marshall 于2022年1月12日周三 13:37写道：
>
> > +1 - assuming we ensure that the `ThresholdShedder` has unit test
> coverage.
> >
> > Thanks,
> > Michael
> >
> >
> > On Tue, Jan 11, 2022 at 9:53 PM r...@apache.org >
> > wrot
I have no objection to the motivation.
Just one thing is the PR changed many files, I guess we will get many
conflicts there.
With a few conflicts, we can handle them confidently and submit them
directly to branches.
If there are many conflicts, I would suggest creating PR direct to the
branch so
Hi all,
Not all modules enable the checkstyle.
I think we need to make sure the behavior is consistent across all modules.
On Wed, Jan 12, 2022 at 9:42 AM Michael Marshall
wrote:
> Hi Pulsar Community,
>
> I notice that we have had several recent PRs adding checkstyle to more
> of our modules:
+1
Michael Marshall 于2022年1月12日周三 13:37写道：
> +1 - assuming we ensure that the `ThresholdShedder` has unit test coverage.
>
> Thanks,
> Michael
>
>
> On Tue, Jan 11, 2022 at 9:53 PM r...@apache.org
> wrote:
> >
> > +1 (non-binding)
> >
> > --
> >
> > Thanks
> > Xiaolong Ran
> >
> > Haiting Jiang
+1
陳智弘 于2022年1月12日周三 10:19写道：
> +1
>
> Haiting Jiang 於 2022年1月12日 週三 09:50 寫道：
>
> > +1
> >
> > On 2022/01/12 01:44:21 PengHui Li wrote:
> > > +1
> > >
> > > Penghui
> > >
> > > On Wed, Jan 12, 2022 at 8:39 AM mattison chao
> > > wrote:
> > >
> > > > +1
> > > >
> > > > On Wed, 12 Jan 2022 at 0
I am +1 with the initiative.
I would like to add a suggestion, maybe I am exaggerating...
Why not "closing" those PRs ?
Closing a PR does not mean to delete it
btw I am fine with the process you suggested
Enrico
Il giorno mer 12 gen 2022 alle ore 18:54 Michael Marshall
ha scritto:
>
> > Ok, bo
> Ok, both "status/stale" and "status/inactive” looks good. Let's use
> "status/inactive”
+1 - I agree with using "status/inactive" for these issues/PRs.
>> Can the time period be made a configuration parameter to make it easy to
adjust?
>Yes, we can easy to change the CI params.
I agree with se
Hi Pulsar Community,
I notice that we have had several recent PRs adding checkstyle to more
of our modules:
https://github.com/apache/pulsar/pull/13409
https://github.com/apache/pulsar/pull/13413
https://github.com/apache/pulsar/pull/13343
https://github.com/apache/pulsar/pull/13284
https://githu
> I used the "status/stale" label for some old PRs that I closed.
I think that "status/inactive” would be a more descriptive label than
“icebox”.
Ok, both "status/stale" and "status/inactive” looks good. Let's use
"status/inactive”
> Can the time period be made a configuration parameter to make
michaeljmarshall commented on pull request #199:
URL:
https://github.com/apache/pulsar-helm-chart/pull/199#issuecomment-1011251281
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
cogito-kyle opened a new pull request #201:
URL: https://github.com/apache/pulsar-helm-chart/pull/201
Fixes #
### Motivation
*Explain here the context, and why you're making that change. What is the
problem you're trying to solve.*
### Modifications
- Added labels to
> On Jan 12, 2022, at 8:15 AM, PengHui Li wrote:
>
> Hi Pulsar Community,
>
> I want to start a discussion about introducing an icebox label that can be
> added to
> the issue or PR by pulsar bot automatically to help us can focus on the
> active PRs
> and issue. To avoid missing merge PRs, re
+1 (non)
On Tue, Jan 11, 2022 at 9:46 PM r...@apache.org
wrote:
> +1 (non-binding)
>
> --
> Thanks
> Xiaolong Ran
>
> mattison chao 于2022年1月12日周三 10:15写道：
>
> > +1 (non-binding)
> >
> > On Wed, 12 Jan 2022 at 09:59, Zike Yang
> > wrote:
> >
> > > +1 (non-binding)
> > >
> > > On Wed, Jan 12,
+1 (non-binding)
r...@apache.org 于2022年1月12日周三 11:46写道：
> +1 (non-binding)
>
> --
> Thanks
> Xiaolong Ran
>
> mattison chao 于2022年1月12日周三 10:15写道：
>
> > +1 (non-binding)
> >
> > On Wed, 12 Jan 2022 at 09:59, Zike Yang
> > wrote:
> >
> > > +1 (non-binding)
> > >
> > > On Wed, Jan 12, 2022 at
Hi Pulsar Community,
I want to start a discussion about introducing an icebox label that can be
added to
the issue or PR by pulsar bot automatically to help us can focus on the
active PRs
and issue. To avoid missing merge PRs, review PRs, triage issues.
It looks like the following:
1. If the iss
dragonls commented on pull request #155:
URL:
https://github.com/apache/pulsar-helm-chart/pull/155#issuecomment-1011028456
Sorry for the late modification. @MarvinCai PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dragonls commented on a change in pull request #155:
URL: https://github.com/apache/pulsar-helm-chart/pull/155#discussion_r783058040
##
File path: charts/pulsar/templates/grafana-deployment.yaml
##
@@ -88,4 +91,20 @@ spec:
name: "{{ template "pulsar.fullname" . }
dragonls commented on a change in pull request #155:
URL: https://github.com/apache/pulsar-helm-chart/pull/155#discussion_r783057866
##
File path: charts/pulsar/templates/grafana-pvc.yaml
##
@@ -0,0 +1,40 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or
+1
> I wonder if we can create issue in client repo automatically with bots for
> PRs labelled"component/client" in pulsar repo.
> This would save the extra effort for the reviewer.
But there are many PRs with "component/client" label that are specific
to java client changes. I think these shoul
Hi Sijie,
Thanks for the suggestions.
> That means:
>
> > 1. We should have a separate `version` from `appVersion`.
> > 2. We should use the Pulsar image version as the `appVersion`.
> > 3. It is okay to only update broker and proxy images version and leave
> zookeeper and bookkeeper version unch
lhotari opened a new pull request #200:
URL: https://github.com/apache/pulsar-helm-chart/pull/200
### Motivation
There was a suggestion [in a dev mailing list
discussion](https://lists.apache.org/thread/bgkvcyt1qq6h67p2k8xwp89xlncbqn3d)
that the Helm chart's appVersion should be use
lhotari merged pull request #199:
URL: https://github.com/apache/pulsar-helm-chart/pull/199
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-un
+1.
I agree with Haiting Jiang.
The automatic process is a better way to solve this problem.
Thanks,
Mattison chao
lhotari opened a new pull request #199:
URL: https://github.com/apache/pulsar-helm-chart/pull/199
### Motivation
- chart releaser command broker after upgrading to 1.3.0 version by #192
- [example
failure](https://github.com/apache/pulsar-helm-chart/runs/4785990468?check_suite_foc
lhotari merged pull request #198:
URL: https://github.com/apache/pulsar-helm-chart/pull/198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-un
lhotari closed issue #197:
URL: https://github.com/apache/pulsar-helm-chart/issues/197
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubsc
+1. Great idea.
I wonder if we can create issue in client repo automatically with bots for PRs
labelled"component/client" in pulsar repo.
This would save the extra effort for the reviewer.
Thanks,
Haiting Jiang
On 2022/01/12 03:45:18 "r...@apache.org" wrote:
> Hello everyone:
>
> At present, a
34 matches
Mail list logo
