Re: Required and recommended JavaVersion for Pulsar broker

2022-06-22 Thread tison
Thanks for your information! Then I think we can merge PR-16163 to master and release with 2.11, while not to cherry-pick to <=2.10. Best, tison. Ran Gao 于2022年6月23日周四 10:01写道: > One problem is that the presto 334 needs jdk11+ and it didn't support > jdk8, maybe 2.11 is a good time for

Re: [DISCUSS] PIP-172: Introduce the HEALTH_CHECK command in the binary protocol

2022-06-22 Thread Cong Zhao
Hi Michael, Thanks for your feedback. > I define a client's primary cluster as "healthy" when it is "healthy" for all of its producers and consumers. I define a healthy producer as one that can connect to a topic and publish messages within certain latency and throughput thresholds (configured

[GitHub] [pulsar-site] urfreespace merged pull request #121: fix: md 404 and tab not working

2022-06-22 Thread GitBox
urfreespace merged PR #121: URL: https://github.com/apache/pulsar-site/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [DISCUSS] PIP-180: Shadow Topic, an alternative way to support readonly topic ownership.

2022-06-22 Thread Dave Fisher
On Jun 21, 2022, at 1:00 AM, Haiting Jiang wrote: > > Hi Pulsar community: > > I open a pip to discuss "Shadow Topic, an alternative way to support readonly > topic ownership." > > Proposal Link: https://github.com/apache/pulsar/issues/16153 > > --- > > ## Motivation > > The motivation

Re: [DISCUSS] PIP-180: Shadow Topic, an alternative way to support readonly topic ownership.

2022-06-22 Thread Haiting Jiang
Hi Asaf, > I did a quick reading and I couldn't understand the gist of this change: > The shadow topic doesn't really have it's own messages, or it's own ledgers > right? When it reads messages, it reads from the original topic ledgers. So > the only thing you need to do is sync the "metadata" -

[GitHub] [pulsar-client-node] gaoran10 commented on a diff in pull request #219: Add null check for consumer in MessageListenerProxy

2022-06-22 Thread GitBox
gaoran10 commented on code in PR #219: URL: https://github.com/apache/pulsar-client-node/pull/219#discussion_r904458120 ## src/Consumer.cc: ## @@ -63,7 +63,9 @@ void MessageListenerProxy(Napi::Env env, Napi::Function jsCallback, MessageListe Consumer *consumer =

Re: [DISCUSS] PIP-180: Shadow Topic, an alternative way to support readonly topic ownership.

2022-06-22 Thread PengHui Li
> One question comes to mind here: Why not simply read the ledger information from original topic, without copy? I think this is a good idea. Penghui On Jun 22, 2022, 23:57 +0800, dev@pulsar.apache.org, wrote: > > One question comes to mind here: Why not simply read the ledger information > from

Re: Required and recommended JavaVersion for Pulsar broker

2022-06-22 Thread Ran Gao
One problem is that the presto 334 needs jdk11+ and it didn't support jdk8, maybe 2.11 is a good time for Pulsar to upgrade the Presto to 334+ or the latest stable version. On 2022/06/22 18:22:09 Enrico Olivelli wrote: > For Pulsar 2.9 and 2.10 you should use jdk11 > you can checkout the

Re: [VOTE] PIP-160 Make transactions work more efficiently by aggregation operation for transaction log and pending ack store

2022-06-22 Thread Jia Zhai
+1 On Mon, Jun 20, 2022 at 9:31 AM PengHui Li wrote: > +1 (binding) > > Left a minor comment here about the field name > https://github.com/apache/pulsar/issues/15370#issuecomment-1159870170 > Please check. > > Thanks, > Penghui > > On Mon, Jun 20, 2022 at 9:21 AM Yubiao Feng > wrote: > > > Hi

Re: [DISCUSS] PIP-174: Provide new implementation for broker dispatch cache

2022-06-22 Thread Matteo Merli
> If all topics share the same cache space, and we won't recycle space by topic. > So when some topics are rebalanced to other brokers, the previous broker > keeps its cache > and results in cache space wasting. > The topic shedding would be quite frequent under some cases, I am not sure > how

Re: [DISCUSS] PIP-172: Introduce the HEALTH_CHECK command in the binary protocol

2022-06-22 Thread Michael Marshall
I'd like to clarify the motivation for this PIP. My understanding is that the primary motivation is to give clients a robust way to classify a cluster as "healthy". The initial beneficiary of this feature is the auto failover use case. I think the feature makes sense, but before using the broker's

Re: Mark delete rate limiter bug?

2022-06-22 Thread Matteo Merli
Right, if there is constant activity on the cursor, the persisting frequency is dictated by the rate limiter. If the forced flush is rate-limited here it will not be a problem because the next ack operation (not rate-limited) will eventually flush everything. The problem the `flush()` is solving

Re: Required and recommended JavaVersion for Pulsar broker

2022-06-22 Thread Enrico Olivelli
For Pulsar 2.9 and 2.10 you should use jdk11 you can checkout the official docker images for 2.11 we decided to go with jdk17 Enrico Il giorno mer 22 giu 2022 alle ore 17:42 ZhangJian He ha scritto: > > Enrico commented on 31 Mar. Now it's required jdk17 on master branch. > `branch-2.10` is

Re: [DISCUSS] PIP-180: Shadow Topic, an alternative way to support readonly topic ownership.

2022-06-22 Thread Asaf Mesika
Hi, I did a quick reading and I couldn't understand the gist of this change: The shadow topic doesn't really have it's own messages, or it's own ledgers right? When it reads messages, it reads from the original topic ledgers. So the only thing you need to do is sync the "metadata" - ledgers list?

Re: Required and recommended JavaVersion for Pulsar broker

2022-06-22 Thread ZhangJian He
Enrico commented on 31 Mar. Now it's required jdk17 on master branch. `branch-2.10` is compatible with jdk8. Thanks ZhangJian He tison 于2022年6月22日周三 23:37写道: > Hi devs. > > During a review of PR-16163[1] I notice a comment from @Enrico Olivelli > on PR-14953 said: > > > We are currently

Required and recommended JavaVersion for Pulsar broker

2022-06-22 Thread tison
Hi devs. During a review of PR-16163[1] I notice a comment from @Enrico Olivelli on PR-14953 said: > We are currently still supporting jdk8 (on the server side) However, on our README.md it recommends: Pulsar Runtime Java Version Recommendation pulsar master branch Broker JavaVersion: 17

Re: [DISCUSS] PIP-172: Introduce the HEALTH_CHECK command in the binary protocol

2022-06-22 Thread Cong Zhao
Yes, there may have multiple clients request the HC at the same time in the AutoFailover case, so we should add some cache to reduce broker load. On 2022/06/22 12:55:49 Enrico Olivelli wrote: > Il giorno mer 22 giu 2022 alle ore 14:45 Cong Zhao > ha scritto: > > > > Hi Enrico, > > > > > Also, I

Re: [VOTE] PIP-172: Introduce the HEALTH_CHECK command in the binary protocol

2022-06-22 Thread PengHui Li
Hi Enrico, > IIUC nobody participated in the discussion. The discussion is under the Github issue. https://github.com/apache/pulsar/issues/15859 Please check. Thanks, Penghui On Jun 22, 2022, 18:16 +0800, Enrico Olivelli , wrote: > Hi, > IIUC nobody participated in the discussion. > > it is

Re: [DISCUSS] PIP-172: Introduce the HEALTH_CHECK command in the binary protocol

2022-06-22 Thread Enrico Olivelli
Il giorno mer 22 giu 2022 alle ore 14:45 Cong Zhao ha scritto: > > Hi Enrico, > > > Also, I would like to understand in which usecase you can use the > > binary endpoint and not the HTTP endpoint. > > We can't use the HTTP endpoint when the client did not have the admin auth to > do a health

Re: [DISCUSS] PIP-172: Introduce the HEALTH_CHECK command in the binary protocol

2022-06-22 Thread Cong Zhao
Hi Enrico, > Also, I would like to understand in which usecase you can use the > binary endpoint and not the HTTP endpoint. We can't use the HTTP endpoint when the client did not have the admin auth to do a health check. but we need it in some cases such as auto failover on the client-side

Re: [DISCUSS] PIP-172: Introduce the HEALTH_CHECK command in the binary protocol

2022-06-22 Thread Enrico Olivelli
I believe that this proposal is too broad. the PIP reads about: - adding HEALTHCHECK to the binary protocol - add a HEALTHCHECK cache on the broker Also, I would like to understand in which usecase you can use the binary endpoint and not the HTTP endpoint. Health Check is good for scripts and

Re: [VOTE] PIP-172: Introduce the HEALTH_CHECK command in the binary protocol

2022-06-22 Thread Enrico Olivelli
Hi, IIUC nobody participated in the discussion. it is too early to start a VOTE -1 (temporary) Enrico Il giorno mer 22 giu 2022 alle ore 05:26 PengHui Li ha scritto: > > +1 > > Penghui > > On Wed, Jun 22, 2022 at 11:16 AM Cong Zhao wrote: > > > Hi Pulsar Community, > > > > I would like to

[GitHub] [pulsar-helm-chart] LvLs9 commented on pull request #251: make proxy httpNumThreads configurable

2022-06-22 Thread GitBox
LvLs9 commented on PR #251: URL: https://github.com/apache/pulsar-helm-chart/pull/251#issuecomment-1162902513 Dear @MarvinCai, could we merge that please  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [pulsar-helm-chart] LvLs9 commented on pull request #251: make proxy httpNumThreads configurable

2022-06-22 Thread GitBox
LvLs9 commented on PR #251: URL: https://github.com/apache/pulsar-helm-chart/pull/251#issuecomment-1162902536 Dear @MarvinCai, could we merge that please  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL