[GitHub] [pulsar-test-infra] nodece closed issue #67: Simplify invocation of docbot action

2022-08-24 Thread GitBox
nodece closed issue #67: Simplify invocation of docbot action URL: https://github.com/apache/pulsar-test-infra/issues/67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [pulsar-test-infra] nodece merged pull request #68: [improve][docbot] Move the preceding steps into the action

2022-08-24 Thread GitBox
nodece merged PR #68: URL: https://github.com/apache/pulsar-test-infra/pull/68 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.ap

Re: [DISCUSS] Move PIPs to the codebase?

2022-08-24 Thread PengHui Li
Hi Tison, > But any proposer can take their proposal number once proposed and a committer clicks the merge button. Still, I'm concerned about adding such a step to exclusively allocate a proposal number. Here is the previous discussion https://lists.apache.org/thread/vw25onjyo18trfysd7x9k9wrs2tyq

Re: [DISCUSS] Catch up reads with many subscriptions - saving reads from BK

2022-08-24 Thread Enrico Olivelli
Thank you folks for your feedback Il giorno gio 25 ago 2022 alle ore 05:56 Haiting Jiang ha scritto: > > Here is my idea of handing the read position shift if we want to go a bit > further with this solution. > > Instead of only checking the exact match of entry range match > (PendingReadKey in t

Re: [DISCUSS] Move PIPs to the codebase?

2022-08-24 Thread PengHui Li
Hi all, I have pushed out a PR https://github.com/apache/pulsar/pull/17270 which wants to copy the PIP and proposal template to the codebase. The PR doesn't want to make some changes to the proposal process before we have approval. Since we will make some changes to the current PIP process, I wan

[GitHub] [pulsar] Nintorac edited a comment on the discussion: Presto connector schema issue

2022-08-24 Thread GitBox
GitHub user Nintorac edited a comment on the discussion: Presto connector schema issue And for logs in that folder I only see `logs/pulsar-standalone.log` and `logs/gc.log` GitHub link: https://github.com/apache/pulsar/discussions/17234#discussioncomment-3471296 This is an automaticall

[GitHub] [pulsar] Nintorac added a comment to the discussion: Presto connector schema issue

2022-08-24 Thread GitBox
GitHub user Nintorac added a comment to the discussion: Presto connector schema issue And for logs I only see `logs/pulsar-standalone.log` and `logs/gc.log` GitHub link: https://github.com/apache/pulsar/discussions/17234#discussioncomment-3471296 This is an automatically sent email for

[GitHub] [pulsar] Nintorac added a comment to the discussion: Presto connector schema issue

2022-08-24 Thread GitBox
GitHub user Nintorac added a comment to the discussion: Presto connector schema issue [pulsar-trino.tar.gz](https://github.com/apache/pulsar/files/9421624/pulsar-trino.tar.gz) Here is the setup -- all in docker compose. It is missing the pulsar presto connctor plugin folder found in the relea

[GitHub] [pulsar-site] Anonymitaet closed issue #172: Dark/Light mode toggle cannot be clicked for develop-binary-protocol page

2022-08-24 Thread GitBox
Anonymitaet closed issue #172: Dark/Light mode toggle cannot be clicked for develop-binary-protocol page URL: https://github.com/apache/pulsar-site/issues/172 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [DISCUSS] PIP-Enable read-only partition, add read and write control for a single partition.

2022-08-24 Thread Gavin Gao
Where we store the metadata? I suggest we use the system topic to store the metadata instead of zk On 2022/08/25 02:36:56 baomingyu_5 wrote: > Hi all, > > In the exclusive consumption mode of exclusive, failover, reader, etc. if a > large number of messages accumulate due to limited consumption

[GitHub] [pulsar] gaoran10 added a comment to the discussion: Presto connector schema issue

2022-08-24 Thread GitBox
GitHub user gaoran10 added a comment to the discussion: Presto connector schema issue Could you try to reproduce this problem in standalone mode? You should find log file `$PULSAR_HOME/lib/presto/var/log/server.log`. If there are reproduce steps, it's better. GitHub link: https://github.com/

Re: [Discussion] PIP 198 - How to define [type] and [scope]?

2022-08-24 Thread tison
Anyway, it's a separate topic to discuss. If you want to discuss issue types and whether to label components, please start another thread. Best, tison. tison 于2022年8月25日周四 13:12写道: > From current issue templates, we already sort issues into bug reports, > improvements, doc changes, flaky tests

Re: [Discussion] PIP 198 - How to define [type] and [scope]?

2022-08-24 Thread tison
>From current issue templates, we already sort issues into bug reports, improvements, doc changes, flaky tests, and PIPs. They're types. [type] and [component] described here are applied to commit messages, not for issues. For components, we may encourage contributors to try their best to sort out

Re: [Discussion] PIP 198 - How to define [type] and [scope]?

2022-08-24 Thread tison
> Agree with applying the same rules ( [type] [scope] summary) for writing issue titles. It cannot be guarded by check so I think it only increases contributors' overhead. Instead, we can try to find out some integration if we can use the GitHub issue forms dropdown widget to allow contributors t

[VOTE RESULT] PIP 198: Standardize PR Naming Convention using GitHub Actions

2022-08-24 Thread Yu
Hi team, As discussed previously [1], we'll start implementing PIP 198: Standardize PR Naming Convention using GitHub Actions [1] based on the results voted by the community. Below is a brief summary of the vote results. 1. Convention Continue to follow our existing convention

Re: [Discussion] PIP 198 - How to define [type] and [scope]?

2022-08-24 Thread Liu Yu
Thanks Max! Agree with applying the same rules ( [type] [scope] summary) for writing issue titles. On 2022/08/25 02:48:51 Max Xu wrote: > LGTM. > > And I think we should also update our issue templates. > > Best, > Max Xu > > > On Tue, Aug 23, 2022 at 6:04 PM Yu wrote: > > > Hi team, > >

Re: [DISCUSS] Move PIPs to the codebase?

2022-08-24 Thread tison
Hi Penghui, > IMO, the final status of the proposal should be summarized in the proposal. Agree. It's not exclusive. What I propose is that if you want to track proposals in a project, track issues. But it seems your opinion is not to do so. Then it's a nonissue. Flink FLIP tracks proposal status

Re: [VOTE] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-24 Thread Max Xu
+1 (non-binding) It's a cool idea! Best, Max Xu On Wed, Aug 24, 2022 at 9:46 PM PengHui Li wrote: > +1 (binding) > > Best, > Penghui > > On Wed, Aug 24, 2022 at 9:39 PM Dave Fisher wrote: > > > +1 (binding) > > > > Best, > > Dave > > > > Sent from my iPhone > > > > > On Aug 24, 2022, at 12:4

[GitHub] [pulsar] liangyuanpeng added a comment to the discussion: I encountered a port error when using pulsar to integrate etcd

2022-08-24 Thread GitBox
GitHub user liangyuanpeng added a comment to the discussion: I encountered a port error when using pulsar to integrate etcd I have tests on the docker image of `docker pull lypgcs/pulsar:2022-08-23` and it's working for etcd cluster. You need Change `etcd:node01:2379,node02:2379,node03:2379

[GitHub] [pulsar-site] Anonymitaet commented on pull request #176: Generate client config docs from source code

2022-08-24 Thread GitBox
Anonymitaet commented on PR #176: URL: https://github.com/apache/pulsar-site/pull/176#issuecomment-1226745537 @urfreespace Could you please review this PR from a technical perspective? Thank you! 😊 -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [pulsar-test-infra] maxsxu commented on a diff in pull request #68: [improve][docbot] Move the preceding steps into the action

2022-08-24 Thread GitBox
maxsxu commented on code in PR #68: URL: https://github.com/apache/pulsar-test-infra/pull/68#discussion_r954477706 ## docbot/action.yml: ## @@ -8,6 +8,16 @@ branding: runs: using: composite steps: -- run: go run main.go +- name: Checkout + uses: actions/check

[GitHub] [pulsar-test-infra] Anonymitaet closed pull request #36: [Docbot] Add doc-added label

2022-08-24 Thread GitBox
Anonymitaet closed pull request #36: [Docbot] Add doc-added label URL: https://github.com/apache/pulsar-test-infra/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [pulsar-test-infra] Anonymitaet commented on pull request #36: [Docbot] Add doc-added label

2022-08-24 Thread GitBox
Anonymitaet commented on PR #36: URL: https://github.com/apache/pulsar-test-infra/pull/36#issuecomment-1226743227 Thanks for your contribution! Already resolved https://github.com/apache/pulsar/blob/b21f72886dc20362efe6808d690ddca32c5abd1e/.github/workflows/ci-documentbot.yml#L56 -- This

Re: [DISCUSS] Catch up reads with many subscriptions - saving reads from BK

2022-08-24 Thread Haiting Jiang
Here is my idea of handing the read position shift if we want to go a bit further with this solution. Instead of only checking the exact match of entry range match (PendingReadKey in the PR), we can check if the requesting range is covered by several ongoing read requests, and merge the result of

[GitHub] [pulsar-test-infra] Anonymitaet commented on pull request #60: Remove unused legacy docbot

2022-08-24 Thread GitBox
Anonymitaet commented on PR #60: URL: https://github.com/apache/pulsar-test-infra/pull/60#issuecomment-1226742311 Hi @tisonkun @nodece thanks for your feedback! We (+ @maxsxu) prefer not to tag it. Reasons: 1. We've searched and found that nearly no one uses this code. 2. The

[GitHub] [pulsar-test-infra] maxsxu commented on pull request #36: [Docbot] Add doc-added label

2022-08-24 Thread GitBox
maxsxu commented on PR #36: URL: https://github.com/apache/pulsar-test-infra/pull/36#issuecomment-1226741194 Already addressed in new docbot. /cc @Anonymitaet -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [DISCUSS] Catch up reads with many subscriptions - saving reads from BK

2022-08-24 Thread Haiting Jiang
+1 for this optimization for the specific scenario. This simple patch is really effective, in some tests it reduces a lot > (from 100K reads/s to 250 reads/s) the concurrent reads to BK. > You may say that it is unlikely that the broker sends concurrent > requests for exactly the same range of ent

[GitHub] [pulsar-test-infra] tisonkun commented on a diff in pull request #68: [improve][docbot] Move the preceding steps into the action

2022-08-24 Thread GitBox
tisonkun commented on code in PR #68: URL: https://github.com/apache/pulsar-test-infra/pull/68#discussion_r954466400 ## docbot/action.yml: ## @@ -8,6 +8,16 @@ branding: runs: using: composite steps: -- run: go run main.go +- name: Checkout + uses: actions/che

[GitHub] [pulsar-test-infra] maxsxu commented on a diff in pull request #68: [improve][docbot] Move the preceding steps into the action

2022-08-24 Thread GitBox
maxsxu commented on code in PR #68: URL: https://github.com/apache/pulsar-test-infra/pull/68#discussion_r954462336 ## docbot/action.yml: ## @@ -8,6 +8,16 @@ branding: runs: using: composite steps: -- run: go run main.go +- name: Checkout + uses: actions/check

[GitHub] [pulsar-site] SignorMercurio opened a new issue, #177: Migrate all docs from `/tools` to `/reference`

2022-08-24 Thread GitBox
SignorMercurio opened a new issue, #177: URL: https://github.com/apache/pulsar-site/issues/177 According to https://apache-pulsar.slack.com/archives/C03MG1H2B3N/p1661220553497289, we can start working on migrate all docs from `/tools` to `/reference`. For instance, https://pulsar.apache.or

[GitHub] [pulsar-test-infra] maxsxu commented on a diff in pull request #68: [improve][docbot] Move the preceding steps into the action

2022-08-24 Thread GitBox
maxsxu commented on code in PR #68: URL: https://github.com/apache/pulsar-test-infra/pull/68#discussion_r954459313 ## docbot/action.yml: ## @@ -8,6 +8,16 @@ branding: runs: using: composite steps: -- run: go run main.go +- name: Checkout + uses: actions/check

Re: [Vote] PIP-192 New Pulsar Broker Load Balancer

2022-08-24 Thread Hang Chen
+1 (binding) Awesome job! Thanks, Hang Heesung Sohn 于2022年8月24日周三 05:29写道: > > Hi, Pulsar dev community, > > This vote has been open for 23 days, and we are closing this vote today as > this PIP received three binding +1s. > > We are moving forward and starting implementation -- there will be a

Re: [DISCUSS] Move PIPs to the codebase?

2022-08-24 Thread PengHui Li
Hi Tison, Thanks for providing more context. > Rust RFCs hold in a separate repo so that they can use the PR number as the proposal number to prevent duplicates. It's a bit overhead for Pulsar to hold a separate repo. So I'd prefer to hold proposals in the same repo under the dev/proposals folder

[GitHub] [pulsar-test-infra] tisonkun commented on a diff in pull request #68: [improve][docbot] Move the preceding steps into the action

2022-08-24 Thread GitBox
tisonkun commented on code in PR #68: URL: https://github.com/apache/pulsar-test-infra/pull/68#discussion_r954452284 ## docbot/action.yml: ## @@ -8,6 +8,16 @@ branding: runs: using: composite steps: -- run: go run main.go +- name: Checkout + uses: actions/che

[GitHub] [pulsar-site] SignorMercurio opened a new pull request, #176: Generate client config docs from source code

2022-08-24 Thread GitBox
SignorMercurio opened a new pull request, #176: URL: https://github.com/apache/pulsar-site/pull/176 Related PR: apache/pulsar#17198. @urfreespace PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [Discussion] PIP 198 - How to define [type] and [scope]?

2022-08-24 Thread Max Xu
LGTM. And I think we should also update our issue templates. Best, Max Xu On Tue, Aug 23, 2022 at 6:04 PM Yu wrote: > Hi team, > > Many thanks for your feedback! We've adjusted the convention based on your > suggestions! > > Below is a brief summary of what we have reached a consensus on: > >

[DISCUSS] PIP-Enable read-only partition, add read and write control for a single partition.

2022-08-24 Thread baomingyu_5
Hi all, In the exclusive consumption mode of exclusive, failover, reader, etc. if a large number of messages accumulate due to limited consumption capacity or consumption logic problems, expanding partitions or modifying consumption logic cannot reduce the consumption of new messages in time. I

[DISCUSS] PIP-Enable read-only partition, add read and write control for a single partition.

2022-08-24 Thread baomingyu_5
Hi all, In the exclusive consumption mode of exclusive, failover, reader, etc. if a large number of messages accumulate due to limited consumption capacity or consumption logic problems, expanding partitions or modifying consumption logic cannot reduce the consumption of new messages in time. I

Re: [DISCUSS] Move PIPs to the codebase?

2022-08-24 Thread PengHui Li
> So that we can review the details and improve these 2 documents (I see the last update for these two documents are 2021 and 2020) Sorry, I think it's not a good idea. We should move to the codebase 100% the same as the original documentation. And use another PR to make improvements for it. If it

Re: [DISCUSS] Move PIPs to the codebase?

2022-08-24 Thread PengHui Li
Hi Michael, > This raises the question of how to handle historical PIPs. We could do some work to move PIPs out of the wiki and out of issues into the code base. The wiki is just another git repo, so any committer should be able to help migrate PIPs in the wiki to the apache/pulsar git repo. This

[GitHub] [pulsar-test-infra] maxsxu commented on pull request #68: [improve][docbot] Move the preceding steps into the action

2022-08-24 Thread GitBox
maxsxu commented on PR #68: URL: https://github.com/apache/pulsar-test-infra/pull/68#issuecomment-1226695489 /cc @tisonkun @Anonymitaet @lhotari -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pulsar-test-infra] maxsxu opened a new pull request, #68: [improve][docbot] Move the preceding steps into the action

2022-08-24 Thread GitBox
maxsxu opened a new pull request, #68: URL: https://github.com/apache/pulsar-test-infra/pull/68 Fixes #67 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [pulsar-test-infra] maxsxu opened a new issue, #67: Simplify invocation of docbot action

2022-08-24 Thread GitBox
maxsxu opened a new issue, #67: URL: https://github.com/apache/pulsar-test-infra/issues/67 ### Motivation The [Current invocation of docbot](https://github.com/apache/pulsar/blob/46b1239a23fd2a250b009df1e9b4a65341d299a7/.github/workflows/ci-documentbot.yml): ``` jobs: label

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-08-24 Thread Baodi Shi
+1 Thanks, Baodi Shi > On Aug 24, 2022, at 20:1312, Qiang Huang wrote: > > +1 > > Zike Yang 于2022年8月22日周一 15:32写道: > >> +1 >> >> Thanks, >> Zike Yang >> >> On Mon, Aug 22, 2022 at 3:16 PM mattison chao >> wrote: >>> >>> +1 >>> >>> Best, >>> Mattison >>> >>> On Fri, 19 Aug 2022 at 01:40

Re: [DISCUSS] Move PIPs to the codebase?

2022-08-24 Thread tison
Hi Penghui, Thanks for starting this discussion! +1 for holding PIPs in the codebase. I'd like to share some experience working on open-source projects holding proposals as code. 1. Rust RFCs: codebase https://github.com/rust-lang/rfcs 2. TiDB Proposals: https://github.com/pingcap/tidb/tree/mast

[jira] [Closed] (PULSAR-22) flink消费pulsar时出现错误,但是仍可消费到数据

2022-08-24 Thread Jira
[ https://issues.apache.org/jira/browse/PULSAR-22?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 海洋饼干 closed PULSAR-22. -- Resolution: Cannot Reproduce > flink消费pulsar时出现错误,但是仍可消费到数据 > > > Key: PULS

Re: [DISCUSS] Move PIPs to the codebase?

2022-08-24 Thread Christophe Bornet
+1 from me. (I've always been a supporter of having PIPs in codebase) Le mer. 24 août 2022 à 18:04, Michael Marshall a écrit : > I support moving PIPs to the code base. > > When we discussed this option during last year's redesign of the PIP > process, an objection was that "merging" a PIP could

[GitHub] [pulsar-site] tisonkun commented on pull request #170: fix version replace

2022-08-24 Thread GitBox
tisonkun commented on PR #170: URL: https://github.com/apache/pulsar-site/pull/170#issuecomment-1226029231 Cool! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [pulsar-site] tisonkun opened a new issue, #175: Remove all content before sync

2022-08-24 Thread GitBox
tisonkun opened a new issue, #175: URL: https://github.com/apache/pulsar-site/issues/175 @urfreespace @Anonymitaet Otherwise, we can suffer from some files deleted from upstream but still remain in this repo. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [pulsar-site] tisonkun closed pull request #174: Sync with main repo rename develop-binary-protocol

2022-08-24 Thread GitBox
tisonkun closed pull request #174: Sync with main repo rename develop-binary-protocol URL: https://github.com/apache/pulsar-site/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pulsar-site] tisonkun commented on pull request #174: Sync with main repo rename develop-binary-protocol

2022-08-24 Thread GitBox
tisonkun commented on PR #174: URL: https://github.com/apache/pulsar-site/pull/174#issuecomment-1225988594 Closed. It seems I can use the following snippet to redirect. Should submit a pr on the main repo: ```mdx --- id: develop-binary-protocol title: Pulsar binary protocol s

Re: [DISCUSS] Catch up reads with many subscriptions - saving reads from BK

2022-08-24 Thread Michael Marshall
+1 I support merging the temporary solution. > Just one point, please make sure the change will not introduce too much > heap memory overhead. If we see that there is extra pressure, I wonder if we can dynamically determine when to deduplicate requests. A broker only needs this feature when a top

[GitHub] [pulsar-site] tisonkun commented on pull request #174: Sync with main repo rename develop-binary-protocol

2022-08-24 Thread GitBox
tisonkun commented on PR #174: URL: https://github.com/apache/pulsar-site/pull/174#issuecomment-1225936104 Or we can change main repo files `develop-binary-protocol` to redirect to `developing-binary-protocol ` -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [pulsar-site] tisonkun opened a new pull request, #174: Sync with main repo rename develop-binary-protocol

2022-08-24 Thread GitBox
tisonkun opened a new pull request, #174: URL: https://github.com/apache/pulsar-site/pull/174 This closes #172. cc @urfreespace perhaps we should set up a redirect from develop-binary-protocol to developing-binary-protocol. Although, I don't know how to achieve it. -- This is an a

Re: [DISCUSS] Move PIPs to the codebase?

2022-08-24 Thread Michael Marshall
I support moving PIPs to the code base. When we discussed this option during last year's redesign of the PIP process, an objection was that "merging" a PIP could be construed as acceptance of the PIP. As long as we are clear that we merge all proposed PIP PRs because it is good to have the histori

Re: [DISCUSS] Catch up reads with many subscriptions - saving reads from BK

2022-08-24 Thread PengHui Li
+1 for we can have a short-term solution first. Just one point, please make sure the change will not introduce too much heap memory overhead. Thanks, Penghui On Wed, Aug 24, 2022 at 11:54 PM Enrico Olivelli wrote: > Hello folks, > These days I am working on a use case in which I have many > su

[DISCUSS] Catch up reads with many subscriptions - saving reads from BK

2022-08-24 Thread Enrico Olivelli
Hello folks, These days I am working on a use case in which I have many subscriptions on the same topic (~100). If you get to a situation with a big backlog, the consumers are no more able to leverage the broker cache then the broker starts to read from BookKeeper. In 2.11 we have a first mechanis

[GitHub] [pulsar-manager] jakiuncle opened a new issue, #483: I want use casdoor to login,when i change code, happen some problem

2022-08-24 Thread GitBox
jakiuncle opened a new issue, #483: URL: https://github.com/apache/pulsar-manager/issues/483 ![image](https://user-images.githubusercontent.com/88994283/186461092-4ef76ec1-a3ba-4d7b-a177-bf877737cb2e.png) why it jump to ![image](https://user-images.githubusercontent.com/88994283/18646

[GitHub] [pulsar-test-infra] maxsxu commented on issue #58: Use Docker container action for docbot

2022-08-24 Thread GitBox
maxsxu commented on issue #58: URL: https://github.com/apache/pulsar-test-infra/issues/58#issuecomment-1225889058 > Although, we can still try to let the docbot action to be used as barely `apache/pulsar-test-infra/docbot@main`. Yes, one thing we can be sure of now is to simplify

[GitHub] [pulsar-test-infra] tisonkun closed issue #58: Use Docker container action for docbot

2022-08-24 Thread GitBox
tisonkun closed issue #58: Use Docker container action for docbot URL: https://github.com/apache/pulsar-test-infra/issues/58 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [pulsar-test-infra] tisonkun commented on issue #58: Use Docker container action for docbot

2022-08-24 Thread GitBox
tisonkun commented on issue #58: URL: https://github.com/apache/pulsar-test-infra/issues/58#issuecomment-1225879730 Cool! Then I'll close this issue as won't do. Although, we can still try to let the docbot action to be used as barely `apache/pulsar-test-infra/docbot@main`. -- Thi

Re: [DISCUSS] Move PIPs to the codebase?

2022-08-24 Thread 丛搏
Hi all, I also think it's a good idea. Not only can it prevent the duplication of PIP numbers, but most importantly, it is easier to annotate, in other words, It can review the PIP just like the review code, it can make the problem more focused, and it is easier for the viewer to annotate at any t

[GitHub] [pulsar-test-infra] maxsxu commented on issue #58: Use Docker container action for docbot

2022-08-24 Thread GitBox
maxsxu commented on issue #58: URL: https://github.com/apache/pulsar-test-infra/issues/58#issuecomment-1225869732 @tisonkun You have raised a very valuable question. I do curious about the real performance between composite action and docker action. So I did a quick test and the results s

Re: [VOTE] PIP-193 : Sink preprocessing Function

2022-08-24 Thread Christophe Bornet
Thanks to you all, Closing this vote with 8 +1s (4 bindings and 4 non-bindings) and no -1s. We'll adjust the naming during the implementation. Thanks, Christophe Le mar. 23 août 2022 à 07:04, Michael Marshall a écrit : > +1 (binding) > > I have some thoughts on naming, too. > > My preference

Re: [VOTE] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-24 Thread PengHui Li
+1 (binding) Best, Penghui On Wed, Aug 24, 2022 at 9:39 PM Dave Fisher wrote: > +1 (binding) > > Best, > Dave > > Sent from my iPhone > > > On Aug 24, 2022, at 12:43 AM, Yunze Xu > wrote: > > > > +1 (non binding) > > > > Thanks, > > Yunze > > > > > > > > > >> 2022年8月24日 15:38,Nicolò Boschi 写

Re: [VOTE] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-24 Thread Dave Fisher
+1 (binding) Best, Dave Sent from my iPhone > On Aug 24, 2022, at 12:43 AM, Yunze Xu wrote: > > +1 (non binding) > > Thanks, > Yunze > > > > >> 2022年8月24日 15:38,Nicolò Boschi 写道: >> >> +1 (non binding) >> Nicolò Boschi >> >> >>> Il giorno mer 24 ago 2022 alle ore 09:11 Enrico Olivell

[GitHub] [pulsar] abcMH1966 added a comment to the discussion: I encountered a port error when using pulsar to integrate etcd

2022-08-24 Thread GitBox
GitHub user abcMH1966 added a comment to the discussion: I encountered a port error when using pulsar to integrate etcd It doesn't work. Occur the same error! ![image](https://user-images.githubusercontent.com/59676485/186428980-8648bb8f-fdfb-42d3-91c7-7a63e76e3406.png) My JDK version is 18.0

Re: [DISCUSS] Use Github project to track the multi clients development

2022-08-24 Thread Enrico Olivelli
I think that the main problem is that in our community we have plenty of Java developers and there are a few committers that review the patches on non-Java client. The same problem is also for other projects like the Helm Chart. Also, the Java client is used internally by the broker so it is usuall

Re: [DISCUSS] Apache Pulsar 2.10.2 release

2022-08-24 Thread Enrico Olivelli
+1 Enrico Il giorno mer 24 ago 2022 alle ore 14:49 Qiang Huang ha scritto: > > +1 > > PengHui Li 于2022年8月23日周二 23:42写道: > > > +1 > > > > And, I have added the release/2.10.2 label, Lan Liang. > > > > Thanks, > > Penghui > > > > On Tue, Aug 23, 2022 at 11:02 PM Lan Liang > > wrote: > > > > > H

[GitHub] [pulsar] abcMH1966 added a comment to the discussion: I encountered a port error when using pulsar to integrate etcd

2022-08-24 Thread GitBox
GitHub user abcMH1966 added a comment to the discussion: I encountered a port error when using pulsar to integrate etcd > [This PR](https://github.com/apache/pulsar/pull/16309) had resolve pulsar > working with etcd cluster and seems like have not any release version of > pulsar include it. a

Re: [DISCUSS] Deprecate KeyValue schema factory methods with Class parameters

2022-08-24 Thread Qiang Huang
Nice catch. LGTM. Yunze Xu 于2022年8月24日周三 16:29写道: > Hi folks, > > Recently I'm looking into the KeyValue schema and found **FOUR** > static methods in `Schema` to create a `KeyValueSchema` object: > > 1. KeyValue(Class key, Class value); > 2. KeyValue(Class key, Class value, SchemaType type); >

Re: [VOTE] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-24 Thread Qiang Huang
+1 (non binding) Yunze Xu 于2022年8月24日周三 15:44写道: > +1 (non binding) > > Thanks, > Yunze > > > > > > 2022年8月24日 15:38,Nicolò Boschi 写道: > > > > +1 (non binding) > > Nicolò Boschi > > > > > > Il giorno mer 24 ago 2022 alle ore 09:11 Enrico Olivelli < > > eolive...@gmail.com> ha scritto: > > > >>

Re: [VOTE] [PIP-169] Support split bundle by flow or qps

2022-08-24 Thread Qiang Huang
+1(non-binding) Enrico Olivelli 于2022年8月24日周三 15:04写道: > +1 (binding) > > > Enrico > > Il giorno mer 24 ago 2022 alle ore 07:13 Aloys Zhang > ha scritto: > > > > +1 > > > > Haiting Jiang 于2022年8月24日周三 12:35写道: > > > > > +1 (non) > > > > > > Thanks, > > > Haiting > > > > > > On Wed, Aug 24, 202

Re: [DISCUSS] Minor breaking change to 2 method signatures in RangeCache class

2022-08-24 Thread Qiang Huang
Great work! It can tune the range cache better. Michael Marshall 于2022年8月24日周三 11:11写道: > Hi All, > > I'd like to add some more metrics to the broker entry cache. In order > to do so, I needed to update RangeCache#clear and > RangeCache#evictLEntriesBeforeTimestamp so they return Pair Long> inst

Re: [DISCUSS] Apache Pulsar 2.10.2 release

2022-08-24 Thread Qiang Huang
+1 PengHui Li 于2022年8月23日周二 23:42写道: > +1 > > And, I have added the release/2.10.2 label, Lan Liang. > > Thanks, > Penghui > > On Tue, Aug 23, 2022 at 11:02 PM Lan Liang > wrote: > > > Hi,Haiting: > > > >Thanks for your work of release. Could you help to release PR-16309 > > [0] to 2.10.2,

Re: [DISCUSS] Make `Pulsar CI / CI - Unit - Brokers - Flaky` test group to be required

2022-08-24 Thread Qiang Huang
Failure flaky tests reduce the passion of contributors. I suggest making stable tests as required. I have 3 points. 1. Find the existing failure flaky tests and fix them. I believe that there is already a project to record them. 2. Move the failure flaky tests out of the flaky test group. 3. Add th

Re: [DISCUSS] Extended auth operation

2022-08-24 Thread Qiang Huang
Nice catch! +1 Zixuan Liu 于2022年8月22日周一 16:49写道: > Hi all, > > I noticed we added the TenantOperation, NamespaceOperation, and > PolicyOperation in https://github.com/apache/pulsar/pull/6428, which > provide the "real" authz abilities for each resource. This PR only adds > check permissions meth

Re: [DISCUSS] Use Github project to track the multi clients development

2022-08-24 Thread Qiang Huang
It makes sense to me. I'm thinking, if an issue is encountered in a Java client, it is possible to be in other clients. If so, the Java client board is also needed. mattison chao 于2022年8月22日周一 16:00写道: > +1 > > Best, > Mattison > > On Mon, 22 Aug 2022 at 15:52, Baodi Shi > wrote: > > > Nice ide

Re: [DISCUSS] Enable message deduplication for replicator by default

2022-08-24 Thread Qiang Huang
+1 Zike Yang 于2022年8月22日周一 15:32写道: > +1 > > Thanks, > Zike Yang > > On Mon, Aug 22, 2022 at 3:16 PM mattison chao > wrote: > > > > +1 > > > > Best, > > Mattison > > > > On Fri, 19 Aug 2022 at 01:40, Enrico Olivelli > wrote: > > > > > I agree > > > > > > Enrico > > > > > > Il Gio 18 Ago 2022,

Re: [DISCUSS] Enable non-mandatory updating PR branches

2022-08-24 Thread Qiang Huang
It works now. It helps. Zixuan Liu 于2022年8月22日周一 10:38写道: > +1 > > Best, > Zixuan > > On 2022/08/18 13:01:58 tison wrote: > > Hello, > > > > The short version > > = > > > > Vote if you agree on enabling the non-mandatory updating PR branches > > button, i.e., the "Always suggest upda

Re: Enable "Update branch" Github button in pull requests

2022-08-24 Thread Qiang Huang
+1. It can help a lot. Zixuan Liu 于2022年8月22日周一 10:38写道: > +1 > > Best, > Zixuan > > On 2022/07/12 16:06:43 Nicolò Boschi wrote: > > Hi all, > > > > I'd like to propose to enable the Github button "update branch" in the > pull > > requests. > > > > The main reason is that it helps when you want

[GitHub] [pulsar-site] urfreespace merged pull request #169: Move config docs to /reference and improve docs gen scripts

2022-08-24 Thread GitBox
urfreespace merged PR #169: URL: https://github.com/apache/pulsar-site/pull/169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.a

[GitHub] [pulsar-site] Anonymitaet commented on issue #173: Improve color shades for dark mode

2022-08-24 Thread GitBox
Anonymitaet commented on issue #173: URL: https://github.com/apache/pulsar-site/issues/173#issuecomment-1225476599 Hi designers, @gancunjie @DaveDuggins, is it a good practice to set all the texts in the dark color background to `white`? https://user-images.githubusercontent.com/50226

Re: [Discussion] PIP 78: Replace brodocs with docsify?

2022-08-24 Thread Yu
Hi Dave, thanks for your great reminder! We'll add those rules. Yu, signormercurio, urfreespace On Tue, Aug 23, 2022 at 10:33 PM Dave Fisher wrote: > If page urls change then we should also add http redirect rules to help > users who bookmarked these docs. > > Sent from my iPhone > > > On Aug 2

Re: [DISCUSS] Move PIPs to the codebase?

2022-08-24 Thread Yu
Hi Penghui, Thanks for raising this up! > we should have a discussion first on the mailing list, just get feedback on the > motivation. If there are no objections, > the proposal owner can add a line to the file with the PIP number through > a PR, like PIP-123: xxx (Under Discussion). > So that we

Re: [DISCUSS] PIP-200 Package Pulsar Trino distro and config in a dedicated folder

2022-08-24 Thread tison
Hi Enrico and Qiang, The issue description was updated. Picked here: > upgrade and downgrade doc This change should not affect those who use Pulsar with the entry point script, but it changes the layout of the release artifact. I'm going to write a release note about this change and also post i

[DISCUSS] Deprecate KeyValue schema factory methods with Class parameters

2022-08-24 Thread Yunze Xu
Hi folks, Recently I'm looking into the KeyValue schema and found **FOUR** static methods in `Schema` to create a `KeyValueSchema` object: 1. KeyValue(Class key, Class value); 2. KeyValue(Class key, Class value, SchemaType type); 3. KeyValue(Schema key, Schema value); 4. KeyValue(Schema key, Sche

[GitHub] [pulsar-site] tisonkun commented on issue #173: Improve color shades for dark mode

2022-08-24 Thread GitBox
tisonkun commented on issue #173: URL: https://github.com/apache/pulsar-site/issues/173#issuecomment-1225347135 @Anonymitaet for this specific issue, I think we need UI experts to help with selecting colors series. The related code is https://github.com/apache/pulsar-site/blob/e1785a

Re: [VOTE] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-24 Thread Yunze Xu
+1 (non binding) Thanks, Yunze > 2022年8月24日 15:38,Nicolò Boschi 写道: > > +1 (non binding) > Nicolò Boschi > > > Il giorno mer 24 ago 2022 alle ore 09:11 Enrico Olivelli < > eolive...@gmail.com> ha scritto: > >> Hello, >> this is the official thread VOTE for PIP-201 Extensions mechanism for

[GitHub] [pulsar-site] Anonymitaet commented on issue #173: Improve color shades for dark mode

2022-08-24 Thread GitBox
Anonymitaet commented on issue #173: URL: https://github.com/apache/pulsar-site/issues/173#issuecomment-1225320929 @tisonkun thanks for raising this up! Even though the Pulsar website is built in the `pulsar-site` repo and many website-related data are hosted here, I still suggest rep

Re: [VOTE] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-24 Thread Nicolò Boschi
+1 (non binding) Nicolò Boschi Il giorno mer 24 ago 2022 alle ore 09:11 Enrico Olivelli < eolive...@gmail.com> ha scritto: > Hello, > this is the official thread VOTE for PIP-201 Extensions mechanism for > Pulsar Admin CLI tools > > This is the PIP link https://github.com/apache/pulsar/issues/17

[GitHub] [pulsar-site] Anonymitaet merged pull request #171: Update the website banner

2022-08-24 Thread GitBox
Anonymitaet merged PR #171: URL: https://github.com/apache/pulsar-site/pull/171 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@pulsar.a

[GitHub] [pulsar-site] tisonkun opened a new issue, #173: Improve color shades for dark mode

2022-08-24 Thread GitBox
tisonkun opened a new issue, #173: URL: https://github.com/apache/pulsar-site/issues/173 Currently, in dark mode, the contents on several pages are hard to read. For example, https://pulsar.apache.org/docs/next/tiered-storage-filesystem#configure-filesystem-offloader-driver. ht

[VOTE] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-24 Thread Enrico Olivelli
Hello, this is the official thread VOTE for PIP-201 Extensions mechanism for Pulsar Admin CLI tools This is the PIP link https://github.com/apache/pulsar/issues/17155 This is the discussion: https://lists.apache.org/thread/287ft8twc11cp4s1y4qkcx5nmh451cyo I am still working on the PR, that is the

Re: [DISCUSS] [PIP-201] Extensions mechanism for Pulsar Admin CLI tools

2022-08-24 Thread Enrico Olivelli
Yunze, I have updated the PIP with the code of a sample command. Thank you everyone for your comments, I will start a VOTE. Enrico Il giorno mar 23 ago 2022 alle ore 05:26 Michael Marshall ha scritto: > > This proposal looks good to me. I think it will be a helpful addition > to the pulsar admi

Re: [VOTE] [PIP-169] Support split bundle by flow or qps

2022-08-24 Thread Enrico Olivelli
+1 (binding) Enrico Il giorno mer 24 ago 2022 alle ore 07:13 Aloys Zhang ha scritto: > > +1 > > Haiting Jiang 于2022年8月24日周三 12:35写道: > > > +1 (non) > > > > Thanks, > > Haiting > > > > On Wed, Aug 24, 2022 at 10:19 AM guo jiwei wrote: > > > > > +1 (binding) > > > > > > > > > Regards > > > Jiwe