Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 2

2023-02-02 Thread 丛搏
+1(binding) os: mac 12.6 python: 3.9.6 python3 ./examples/consumer.py python3 ./examples/producer.py Thanks, Bo Matteo Merli 于2023年2月3日周五 03:26写道: > > +1 > -- > Matteo Merli > > > On Thu, Feb 2, 2023 at 5:57 AM Yunze Xu wrote: > > > > This is the 2nd release candidate for Apache Pulsar Client

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 2

2023-02-02 Thread Matteo Merli
+1 -- Matteo Merli On Thu, Feb 2, 2023 at 5:57 AM Yunze Xu wrote: > > This is the 2nd release candidate for Apache Pulsar Client Python, > version 3.1.0. > > It fixes the following issues: > https://github.com/apache/pulsar-client-python/milestone/2?closed=1 > > *** Please download, test and vot

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-02-02 Thread Heesung Sohn
On Thu, Feb 2, 2023 at 6:42 AM Asaf Mesika wrote: > Heesung, there are users out there which delete 2M topics in a day. The > stress we apply on ZK today due to the amount of topics is more than > enough. I don't think we should rely on ZK to also manage the deletion of > those ledgers if that me

Re: [VOTE] Reactive Java client for Apache Pulsar 0.2.0 Candidate 2

2023-02-02 Thread Dave Fisher
+1 (binding) - validated signatures and checksum - RAT check passes. Thanks Christophe! Best, Dave > On Feb 2, 2023, at 8:00 AM, Enrico Olivelli wrote: > > +1 (binding) > - built from sources on jdk11 on Mac M1 > - all tests are passing > - gradle check passes (it runs RAT) > - verified signa

Re: [Vote] PIP-242: Introduce enableStrictTopicName to reject creating topic with -partition- keyword.

2023-02-02 Thread Enrico Olivelli
Asaf, Il giorno gio 2 feb 2023 alle ore 16:03 Asaf Mesika ha scritto: > > Enrico - do we have those "rules" of conduct logged somewhere? https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md it reads... "Once some consensus is reached, there will be a vote to formally approve the p

Re: [VOTE] Reactive Java client for Apache Pulsar 0.2.0 Candidate 2

2023-02-02 Thread Enrico Olivelli
+1 (binding) - built from sources on jdk11 on Mac M1 - all tests are passing - gradle check passes (it runs RAT) - verified signatures and checksum Thank you Christophe for running the release Enrico Il giorno gio 2 feb 2023 alle ore 00:04 Christophe Bornet ha scritto: > > This is the release

Re: [Vote] PIP-242: Introduce enableStrictTopicName to reject creating topic with -partition- keyword.

2023-02-02 Thread Asaf Mesika
Enrico - do we have those "rules" of conduct logged somewhere? On Thu, Feb 2, 2023 at 4:59 PM Enrico Olivelli wrote: > Il giorno gio 2 feb 2023 alle ore 15:52 Asaf Mesika > ha scritto: > > > > I agree. I don't think we can start a vote without closing all open > issues > > raised in the discuss

Re: [DISCUSS] Redundant ServiceUrlProvider design and improper use of PIP-121

2023-02-02 Thread Asaf Mesika
Ok, makes sense. On Thu, Feb 2, 2023 at 4:02 PM Yunze Xu wrote: > Not completely different IMO. When we want to update the service URL, > we usually want to connect to another cluster. However, the cluster > could have configured authentication, TLS for security, but we cannot > guarantee two c

Re: [DISCUSS] Topic name restriction

2023-02-02 Thread Asaf Mesika
NamedEntity is not allowing underscores - does it make sense? On Thu, Feb 2, 2023 at 8:35 AM Michael Marshall wrote: > Thanks for starting this thread, Mattison. > > > The topic name character validation is already done by > > `NamedEntity#checkName`. > > Based on my reading of the code, only

Re: [Vote] PIP-242: Introduce enableStrictTopicName to reject creating topic with -partition- keyword.

2023-02-02 Thread Enrico Olivelli
Il giorno gio 2 feb 2023 alle ore 15:52 Asaf Mesika ha scritto: > > I agree. I don't think we can start a vote without closing all open issues > raised in the discussion, until a given timeout - 3 days is not > enough timeout IMO Agreed Also many people don't follow the mailing list during the

Re: [Vote] PIP-242: Introduce enableStrictTopicName to reject creating topic with -partition- keyword.

2023-02-02 Thread Asaf Mesika
I agree. I don't think we can start a vote without closing all open issues raised in the discussion, until a given timeout - 3 days is not enough timeout IMO On Wed, Feb 1, 2023 at 9:16 AM Michael Marshall wrote: > We did not have this discussion or vote open long enough. The > discussion starte

Re: [DISCUSS] PIP-242: Introduce enableStrictTopicName to reject creating topic with -partition- keyword.

2023-02-02 Thread Asaf Mesika
IMO the logic should be defined properly, and examples should help you understand it. Regarding last step >1. Make enableStrictTopicName=true in the next major release. > > Maybe just delete the flag? Just always do it? On Mon, Jan 30, 2023 at 6:31 AM wrote: > Hi, Asaf, Yunze > > You mea

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-02-02 Thread Asaf Mesika
Heesung, there are users out there which delete 2M topics in a day. The stress we apply on ZK today due to the amount of topics is more than enough. I don't think we should rely on ZK to also manage the deletion of those ledgers if that means adding more nodes / more reads and writes to it. I total

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-02-02 Thread Asaf Mesika
Heesung points out really good points, which actually made me add one more: Can you please describe all the triggers for ledger deletion? Some are user facing, some not. On Mon, Jan 30, 2023 at 8:19 PM Heesung Sohn wrote: > Hi, > > > I assume the deletion APIs are async(when a user requests de

Re: [DISCUSS] PIP-186: Introduce two phase deletion protocol based on system topic

2023-02-02 Thread Asaf Mesika
> > When pulsar wants to delete a ledger, ManagedLedger uses > ledgerDeletionService to send a message, the message content contains the > waiting delete ledger info. After sending success, delete the ledger id > from the metadata store. > The consumer receives the message, it will use PulsarClient

Re: [DISCUSS] Code freeze for Pulsar 2.12

2023-02-02 Thread Enrico Olivelli
Il giorno gio 2 feb 2023 alle ore 08:08 Haiting Jiang ha scritto: > > > Following PIP-175, we have to provide the first LTS release which will be > > 3.0. > > Actuall as discussed in [1], the first LTS release is 2.10 for being > the last Java 8 release. > The major version 3.0 bump would simply

Re: [DISCUSS] Redundant ServiceUrlProvider design and improper use of PIP-121

2023-02-02 Thread Yunze Xu
Not completely different IMO. When we want to update the service URL, we usually want to connect to another cluster. However, the cluster could have configured authentication, TLS for security, but we cannot guarantee two clusters share the same TLS certificates or authentication configs. I think w

[VOTE] Pulsar Client Python Release 3.1.0 Candidate 2

2023-02-02 Thread Yunze Xu
This is the 2nd release candidate for Apache Pulsar Client Python, version 3.1.0. It fixes the following issues: https://github.com/apache/pulsar-client-python/milestone/2?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Python wheel

Re: [DISCUSS] Redundant ServiceUrlProvider design and improper use of PIP-121

2023-02-02 Thread Asaf Mesika
Ok, the last two methods IMO are a completely different topic. I wonder what the maintainers think about this. On Mon, Jan 30, 2023 at 4:16 AM Yunze Xu wrote: > In summary, the core issue is that ServiceUrlProvider could be > misused. A user might want to implement its own ServiceUrlProvider by