Re: [DISCUSS] PIP-254: Support configuring client version at SDK level

2023-03-08 Thread Zike Yang
Hi Yunze, > I have changed this proposal to just add a config to `ClientBuilder`. I propose to add a field named `clientVersionSuffix` rather than the `clientVersion`. As I said before: https://lists.apache.org/thread/g0128l85fkcmw4821188mjjznxbo4lhd This is helpful for debugging. Especially for

Re: [VOTE] Pulsar Release 2.10.4 Candidate 1

2023-03-08 Thread Xiangying Meng
Thanks for the reminder. I will make a release later. Thanks. Xiangying On Thu, Mar 9, 2023 at 2:17 PM Haiting Jiang wrote: > Seems like we should include this PR in this release. > https://github.com/apache/pulsar/pull/19754 > > See https://lists.apache.org/thread/odofmj9h8ln6blozhgkgmx0mbyll

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-08 Thread Zike Yang
Hi Yunze The crash issue still exists in python 3.7. Here is the log ``` ^CTraceback (most recent call last): File "/Users/aaronrobert/codebase/pulsar-client-python/examples/consumer.py", line 32, in msg = consumer.receive() File "/Users/aaronrobert/.pyenv/versions/3.7.16/lib/python3.7/s

Re: [Discuss] PIP-248: Add backlog eviction metric

2023-03-08 Thread 太上玄元道君
> backlogQuotaLimitSize > should be `backlogQuotaSizeBytes` > backlogQuotaLimitTime > should be `backlogQuotaTimeSeconds` > So you need to rename the metric. > "pulsar_storage_backlog_quota_count" --> > `pulsar_storage_backlog_eviction_count` > the topic's existing subscription. > "subscription"

Re: [DISCUSS] new idea: reverse reading a topic

2023-03-08 Thread Haiting Jiang
Hi Kannar, +1 to find the position first and then read like normal as mentioned by Yong and Michael. Another problem of reading reverse is that it would break all the read ahead techniques in the storage and result in very poor performance. > This would work but it will need something to store

Re: [VOTE] Pulsar Release 2.10.4 Candidate 1

2023-03-08 Thread Haiting Jiang
Seems like we should include this PR in this release. https://github.com/apache/pulsar/pull/19754 See https://lists.apache.org/thread/odofmj9h8ln6blozhgkgmx0mbyll45dp Thanks, Haiting On Thu, Mar 9, 2023 at 2:07 PM 丛搏 wrote: > > +1 (binding) > > os: mac 12.3.1, Intel > java: OpenJDK 17.0.1 > > -

Re: [VOTE] Pulsar Release 2.10.4 Candidate 1

2023-03-08 Thread 丛搏
+1 (binding) os: mac 12.3.1, Intel java: OpenJDK 17.0.1 - Checked the signature - Checked LICENSE - Start standalone - Publish and consume messages - Verified Function and State Function - Verified Cassandra connector - Build from the source package (maven 3.6.1, openJDK 11.0.12) - Run a simple t

Re: [DISCUSS] Critical problem report - session notification thread deadlock

2023-03-08 Thread PengHui Li
Thanks, Qiang, And for the upcoming patch releases 2.11.1, 2.10.4, 2.9.5 Please ship the fix to the release. Although it's not a fix for breaking change. But it fixed a critical issue from previous releases. Thanks, Penghui On Thu, Mar 9, 2023 at 11:44 AM wrote: > Hi, All > > We found a crit

Re: [DISCUSS] PIP-246: Improved PROTOBUF_NATIVE schema compatibility checks without using avro-protobuf

2023-03-08 Thread 丛搏
Hi siNan: >From my point of view, it is just a plug-in. I don't think it is necessary to add configuration for the plugin. This is meaningless, and it will increase the difficulty of use for users. SiNan Liu 于2023年3月8日周三 15:54写道: > > Hi, bo. > > 1. I understand what you say, to develop a new >

[DISCUSS] Critical problem report - session notification thread deadlock

2023-03-08 Thread mattisonchao
Hi, All We found a critical problem that will cause the pulsar cluster to part “deaf” status. the broker can’t receive zookeeper session notification to revalidate namespace bundle ownership and leader election. That means it will cause one topic may have two owner brokers, and the leader elect

Re: [DISCUSS] new idea: reverse reading a topic

2023-03-08 Thread Zike Yang
> Have you looked at the seek implementation to see if it would be feasible to extend the implementation and add a method to "seekBefore" a message id in the way you described? I think it's not very feasible for this case. Seeking before can lead to consumer reconnection, which can cause significa

Re: [DISCUSS] new idea: reverse reading a topic

2023-03-08 Thread Yong Zhang
Kannar, Why not find the stop position first, then read the message until a given position? Does the stop position change dynamically? You only know it once you meet it? Yong On Wed, 8 Mar 2023 at 21:37, Alexandre DUVAL wrote: > Hi Michael, > > This would work but it will need something to s

Re: [VOTE] Apache Pulsar Adapters Release 2.11.0 Candidate 3

2023-03-08 Thread Michael Marshall
+1 (binding) I verified 1 signature and 1 checksum. One nit, the checksum has file extension `.sha512sum` instead of the usual `.sha512`. I am assuming this is fine. While trying to build the project with `mvn clean install`, it failed with the following error [ERROR] Failed to execute goal on p

Re: [Discussion] Allowing configure if function consumer should skip to latest

2023-03-08 Thread Neng Lu
Hi everyone, This discussion has been one week old. If there's no objection or concerns, I'll move forward and close the discussion with the conclusion that we are good with the proposed change. This will result in the PR merge (although it was already merged, so the merged change won't be rev

Re: [DISCUSS] new idea: reverse reading a topic

2023-03-08 Thread Alexandre DUVAL
Hi Michael, This would work but it will need something to store every messages read to reverse them before answer which can be heavy in RAM usages. The key point of the future is to read message by message from a MessageId to past with stop read possible conditions. Best, Kannar On 3/7/23

[VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-08 Thread Yunze Xu
This is the 4th release candidate for Apache Pulsar Client Python, version 3.1.0. It fixes the following issues: https://github.com/apache/pulsar-client-python/milestone/2?closed=1 *** Please download, test and vote on this release. This vote will stay open for at least 72 hours *** Python wheel

Re: [VOTE] Apache Pulsar Adapters Release 2.11.0 Candidate 3

2023-03-08 Thread Nicolò Boschi
+1 (binding) - verified checksum/signatures - build and tests passing w jdk17 on Mac Intel Nicolò Boschi Il giorno mar 7 mar 2023 alle ore 09:57 Enrico Olivelli ha scritto: > Nice work Christophe, thanks for driving this release > > +1 (binding) > > - verified checksums/signatures > - built on

Re: [DISCUSS] PIP-254: Support configuring client version at SDK level

2023-03-08 Thread Yunze Xu
Hi, I have changed this proposal to just add a config to `ClientBuilder`. And here is the demo implementation: https://github.com/BewareMyPower/pulsar/pull/21/files PTAL again. Thanks, Yunze On Sat, Mar 4, 2023 at 10:39 PM Yunze Xu wrote: > > Hi Enrico, > > Thanks for your suggestion. It makes

Re: [DISCUSS] PIP-247: Notifications for partitions update

2023-03-08 Thread houxiaoyu
Hi Michael, > is there a reason that we couldn't also use this to improve PIP 145? The protocol described in this PIP could also be used to improve PIP-145. However I think that it' not a good reason that we use the regex sub watcher to implement the partitioned update watcher because of the oth