Re: [DISCUSS] Retry topic should not create for a retry topic

2023-03-10 Thread 丛搏
+1, I agree with you. We should prohibit users from creating Retry Topic and DLQ Topic in a loop. It will make uncontrollable behavior. If we allow that, It may cause great trouble to users. Thanks, Bo Asaf Mesika 于2023年2月14日周二 03:02写道: > > Sounds like a bug for sure. > How did you plan on so

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-10 Thread 丛搏
+1 (binding) python version: 3.7.6 - Checked the signature - Install the python .whl file (pulsar_client-3.1.0-cp37-cp37m-macosx_10_15_universal2.whl) on macOS 12.3.1 - Start the standalone (2.11.0) - Start consumer (python3 ./examples/consumer.py) - Start producer (python3 ./examples/producer.py)

Re: [VOTE] PIP-250: Add proxyVersion to CommandConnect

2023-03-10 Thread Yubiao Feng
+1 (non-binding) Thanks Yubiao Feng On Sat, Mar 11, 2023 at 3:31 AM Michael Marshall wrote: > Hello Pulsar Community, > > This thread is to start the vote for PIP 250. > > Discussion: > https://lists.apache.org/thread/ntzwkdz23d6s6ycyn2r198c515npp7vt > Issue: https://github.com/apache/pulsar/is

Re: [DISCUSS] PIP-253: Expose producer metrics for deadLetterProducer and retryLetterProducer

2023-03-10 Thread Kai Levy
I made a start on the implementation with `setRetryLetterProducer`. Unfortunately, the spotbugs plugin has issues with it, because now ConsumerImpl is returning a mutable object from getStats. You can see my progress here

Re: [VOTE] PIP-250: Add proxyVersion to CommandConnect

2023-03-10 Thread ZhangJian He
+1 (non-binding) Thanks ZhangJian He On Sat, 11 Mar 2023 at 05:36, Enrico Olivelli wrote: > +1 (binding) > > Enrico > > Il Ven 10 Mar 2023, 20:31 Michael Marshall ha > scritto: > > > Hello Pulsar Community, > > > > This thread is to start the vote for PIP 250. > > > > Discussion: > > https://

Re: [VOTE] PIP-250: Add proxyVersion to CommandConnect

2023-03-10 Thread Enrico Olivelli
+1 (binding) Enrico Il Ven 10 Mar 2023, 20:31 Michael Marshall ha scritto: > Hello Pulsar Community, > > This thread is to start the vote for PIP 250. > > Discussion: > https://lists.apache.org/thread/ntzwkdz23d6s6ycyn2r198c515npp7vt > Issue: https://github.com/apache/pulsar/issues/19623 > Work

Re: [VOTE] PIP-253 Expose producer metrics for deadLetterProducer and retryLetterProducer

2023-03-10 Thread Enrico Olivelli
+1 (binding) Enrico Il Ven 10 Mar 2023, 21:36 Michael Marshall ha scritto: > +1 (binding) > > Thanks for your PIP! Feel free to tag me to help review the PR when we > get to that step. > > Thanks, > Michael > > On Fri, Mar 10, 2023 at 2:27 PM Kai Levy wrote: > > > > Hello, > > > > This thread

Re: [VOTE] PIP-253 Expose producer metrics for deadLetterProducer and retryLetterProducer

2023-03-10 Thread Michael Marshall
+1 (binding) Thanks for your PIP! Feel free to tag me to help review the PR when we get to that step. Thanks, Michael On Fri, Mar 10, 2023 at 2:27 PM Kai Levy wrote: > > Hello, > > This thread is to start a vote for PIP-253 > > Discussion: https://lists.apache.org/thread/570x5yodg0bog4thgtstrgk

[VOTE] PIP-253 Expose producer metrics for deadLetterProducer and retryLetterProducer

2023-03-10 Thread Kai Levy
Hello, This thread is to start a vote for PIP-253 Discussion: https://lists.apache.org/thread/570x5yodg0bog4thgtstrgkgpthxmgfd Issue: https://github.com/apache/pulsar/issues/19698 Voting will be open at least 48 hours. Thanks! Kai

[VOTE] PIP-250: Add proxyVersion to CommandConnect

2023-03-10 Thread Michael Marshall
Hello Pulsar Community, This thread is to start the vote for PIP 250. Discussion: https://lists.apache.org/thread/ntzwkdz23d6s6ycyn2r198c515npp7vt Issue: https://github.com/apache/pulsar/issues/19623 Work in Progress Implementation: https://github.com/apache/pulsar/pull/19618 I'll update the imp

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-10 Thread Matteo Merli
+1 (binding) -- Matteo Merli On Fri, Mar 10, 2023 at 7:44 AM Yunze Xu wrote: > Hi Zike, > > It's not a regression. This error applies for Python client 3.0.0 as > well. Before 3.0.0, the Python client cannot be interrupted by a > signal. I'd rather treat it as the case that the implementation

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-10 Thread Yunze Xu
Hi Zike, It's not a regression. This error applies for Python client 3.0.0 as well. Before 3.0.0, the Python client cannot be interrupted by a signal. I'd rather treat it as the case that the implementation of handling the UNIX signals is not so perfect. Here is the issue: https://github.com/apach

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-10 Thread Zike Yang
+1 (non-binding) My environment: * macOS x86_64 * python 3.7, 3.9, and 3.10 - Check sha512 checksum - Check gpg signature - Install the wheel - Run the producer and consumer example Thanks, Zike Yang On Fri, Mar 10, 2023 at 4:27 PM PengHui Li wrote: > > +1(binding) > > - Install the wheel on m

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-10 Thread PengHui Li
+1(binding) - Install the wheel on macOS (python 3.9) - Start a standalone - Run the consumer and producer example Thanks, Penghui On Fri, Mar 10, 2023 at 4:25 PM Zike Yang wrote: > Hi, Yunze > > > However, with the latest example, the output should be the following > > logs if you pressed the

Re: [VOTE] Pulsar Client Python Release 3.1.0 Candidate 4

2023-03-10 Thread Zike Yang
Hi, Yunze > However, with the latest example, the output should be the following > logs if you pressed the Ctrl+C: Thanks for your explanation. It works fine for me now. > I think it should not be a blocker, we can open an issue for that. The > official example uses a try-except block to avoid t