Re: [DISCUSS] Change PIP template

Great news: the PR containing the new template of the PIP has been merged. All voters - please check to see the template is used. The most important bit in the template is its header - please mind that when reviewing PIPs. I'm quoting it here: RULES > * Never place a link to an external site lik

Re: [DISCUSS] Change PIP template

Bo, I need a review of the PR :) On Wed, Mar 29, 2023 at 4:35 PM 丛搏 wrote: > +1 > > Good discussion! > > Thanks, > Bo > > Asaf Mesika 于2023年3月29日周三 20:11写道： > > > > So far only 1 PMC member reviewed it. > > Any other PMC member would like to review

Re: [DISCUSS] Change PIP template

+1 Good discussion! Thanks, Bo Asaf Mesika 于2023年3月29日周三 20:11写道： > > So far only 1 PMC member reviewed it. > Any other PMC member would like to review the new template for PIP? > > On Wed, Mar 22, 2023 at 1:10 PM Asaf Mesika wrote: > > > Any other PMC member can take a look at the new templat

Re: [DISCUSS] Change PIP template

So far only 1 PMC member reviewed it. Any other PMC member would like to review the new template for PIP? On Wed, Mar 22, 2023 at 1:10 PM Asaf Mesika wrote: > Any other PMC member can take a look at the new template PR > ? > Ideally I would like to ha

Re: [DISCUSS] Change PIP template

Any other PMC member can take a look at the new template PR ? Ideally I would like to have 2-3 PMC member approval for this. > On 17 Mar 2023, at 18:23, Michael Marshall wrote: > > Thanks for this initiative, Asaf. > > As part of this process, I w

Re: [DISCUSS] Change PIP template

Thanks for this initiative, Asaf. As part of this process, I would like for us to add a security and a multi-tenancy section to the PIP template. As you suggest, the template conveys what the community values, and these two sections must always be considered when changing Pulsar in fundamental wa

Re: [DISCUSS] Change PIP template

Here's the PR to remove the form and add a new issue template in Markdown containing the suggested structure and description for each section. https://github.com/apache/pulsar/pull/19832 On Wed, Mar 1, 2023 at 3:43 PM Elliot West wrote: > +1 Asaf > > I'd also suggest that we encourage the subm

Re: [DISCUSS] Change PIP template

+1 Asaf I'd also suggest that we encourage the submission of relevant diagrams. This is trivial to do with the GitHub markdown editor, but I suspect is often neglected because users do not know the feature exists. On Wed, 1 Mar 2023 at 13:22, Asaf Mesika wrote: > Ok. > > I'll draft a PR and lin

Re: [DISCUSS] Change PIP template

Ok. I'll draft a PR and link it here when I'm done. Thanks! On Tue, Feb 28, 2023 at 7:08 AM PengHui Li wrote: > +1 > > Penghui > > On Mon, Feb 27, 2023 at 9:24 PM Asaf Mesika wrote: > > > Mails don't support things like markdown diagrams or images and are > > generally less easy to read. > > M

Re: [DISCUSS] Change PIP template

+1 Penghui On Mon, Feb 27, 2023 at 9:24 PM Asaf Mesika wrote: > Mails don't support things like markdown diagrams or images and are > generally less easy to read. > My proposal includes a required section called Links in which you need to > fill in the discussion thread in DEV mailing list and

Re: [DISCUSS] Change PIP template

Mails don't support things like markdown diagrams or images and are generally less easy to read. My proposal includes a required section called Links in which you need to fill in the discussion thread in DEV mailing list and vote thread. On Mon, Feb 27, 2023 at 3:08 PM Girish Sharma wrote: > H

Re: [DISCUSS] Change PIP template

Hi Asaf, I was referring to the PIP process, as a whole, as explained in https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md Someone looking at GitHub ticket would find and almost empty PIP GH issue while the same PIP has had many discussions over here in the ML. There is scope of i

Re: [DISCUSS] Change PIP template

Can someone direct me to the places I need to change exactly, so I won't make mistakes in the PR? On Mon, Feb 27, 2023 at 9:56 AM Enrico Olivelli wrote: > +1 great suggestions > > Enrico > > Il giorno lun 27 feb 2023 alle ore 02:54 ha > scritto: > > > > +1 > > > > Best, > > Mattison > > On Feb

Re: [DISCUSS] Change PIP template

On Sun, Feb 26, 2023 at 5:02 PM Dave Fisher wrote: > Excellent proposal. > > Inline below. > > Sent from my iPhone > > > On Feb 26, 2023, at 3:19 AM, Asaf Mesika wrote: > > > > Hi, > > > > I would like to suggest two changes I'd like to make to the PIP design > > template: > > 1. Remove the for

Re: [DISCUSS] Change PIP template

On Sun, Feb 26, 2023 at 2:49 PM Girish Sharma wrote: > Good proposal Asaf. > I've also wondered why the PIP creation and discussion process is so > separated. The PIP discussion and voting starts off as a GitHub issue, but > all of its discussion happens here on the mailing list. Is there scope o

Re: [DISCUSS] Change PIP template

+1 great suggestions Enrico Il giorno lun 27 feb 2023 alle ore 02:54 ha scritto: > > +1 > > Best, > Mattison > On Feb 26, 2023, 23:02 +0800, Dave Fisher , wrote: > > Excellent proposal. > > > > Inline below. > > > > Sent from my iPhone > > > > > On Feb 26, 2023, at 3:19 AM, Asaf Mesika wrote: >

Re: [DISCUSS] Change PIP template

+1 Best, Mattison On Feb 26, 2023, 23:02 +0800, Dave Fisher , wrote: > Excellent proposal. > > Inline below. > > Sent from my iPhone > > > On Feb 26, 2023, at 3:19 AM, Asaf Mesika wrote: > > > > Hi, > > > > I would like to suggest two changes I'd like to make to the PIP design > > template: > > 1

Re: [DISCUSS] Change PIP template

Excellent proposal. Inline below. Sent from my iPhone > On Feb 26, 2023, at 3:19 AM, Asaf Mesika wrote: > > Hi, > > I would like to suggest two changes I'd like to make to the PIP design > template: > 1. Remove the form - just have a markdown template fill the issue body as > it is created.

Re: [DISCUSS] Change PIP template

Good proposal Asaf. I've also wondered why the PIP creation and discussion process is so separated. The PIP discussion and voting starts off as a GitHub issue, but all of its discussion happens here on the mailing list. Is there scope of improvement in that process as well? Regards On Sun, Feb 26

Re: [DISCUSS] Change PIP template

Hi Asaf, I agree that, generally, a PIP is written as a whole and paste as the body. So +1 for your proposal. Additionally, I'm thinking of moving the doc of procedure (wiki/PIP.md) to the contributions guide and use the new markdown template to supersede the wiki/PIP-template.md. Then we don't n

[DISCUSS] Change PIP template

Hi, I would like to suggest two changes I'd like to make to the PIP design template: 1. Remove the form - just have a markdown template fill the issue body as it is created. 2. Change the PIP template structure == Removing the form Today, when you want to submit a PIP, you are required to fill o