Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-28 Thread Dave Fisher
+1 (binding) Sent from my iPhone > On Sep 26, 2022, at 2:38 AM, Enrico Olivelli wrote: > > +100 to this ! > > Thanks for this proposal > > Enrico > >> Il giorno lun 26 set 2022 alle ore 10:04 Zike Yang ha >> scritto: >> >> +1. Looks good to me. >> >> Do we need to move the `Apache

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-28 Thread Qiang Huang
+1 Zixuan Liu 于2022年9月26日周一 23:42写道: > +1 > > Thanks, > Zixuan > > Anon Hxy 于2022年9月26日周一 17:52写道: > > > +1 LGTM > > > > Thanks, > > Xiaoyu Hou > > > > Enrico Olivelli 于2022年9月26日周一 17:39写道: > > > > > +100 to this ! > > > > > > Thanks for this proposal > > > > > > Enrico > > > > > > Il giorno

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-26 Thread Zixuan Liu
+1 Thanks, Zixuan Anon Hxy 于2022年9月26日周一 17:52写道: > +1 LGTM > > Thanks, > Xiaoyu Hou > > Enrico Olivelli 于2022年9月26日周一 17:39写道: > > > +100 to this ! > > > > Thanks for this proposal > > > > Enrico > > > > Il giorno lun 26 set 2022 alle ore 10:04 Zike Yang ha > > scritto: > > > > > > +1.

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-26 Thread Anon Hxy
+1 LGTM Thanks, Xiaoyu Hou Enrico Olivelli 于2022年9月26日周一 17:39写道: > +100 to this ! > > Thanks for this proposal > > Enrico > > Il giorno lun 26 set 2022 alle ore 10:04 Zike Yang ha > scritto: > > > > +1. Looks good to me. > > > > Do we need to move the `Apache Pulsar / Multi Clients` Github

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-26 Thread Enrico Olivelli
+100 to this ! Thanks for this proposal Enrico Il giorno lun 26 set 2022 alle ore 10:04 Zike Yang ha scritto: > > +1. Looks good to me. > > Do we need to move the `Apache Pulsar / Multi Clients` Github project > to the corresponding repos? > > Thanks, > Zike Yang > > Zike Yang > > > On Fri,

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-26 Thread Zike Yang
+1. Looks good to me. Do we need to move the `Apache Pulsar / Multi Clients` Github project to the corresponding repos? Thanks, Zike Yang Zike Yang On Fri, Sep 23, 2022 at 7:22 AM Matteo Merli wrote: > > -- > Matteo Merli > > > On Tue, Sep 20, 2022 at 8:14 PM Michael Marshall wrote: > > >

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-22 Thread Matteo Merli
-- Matteo Merli On Tue, Sep 20, 2022 at 8:14 PM Michael Marshall wrote: > > Great proposal, thanks Matteo. > > I think I agree with splitting out the client into two repos. One > issue is that new C++ features will lag in the python client because > the C++ client will first need to be

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-20 Thread Michael Marshall
Great proposal, thanks Matteo. I think I agree with splitting out the client into two repos. One issue is that new C++ features will lag in the python client because the C++ client will first need to be released. Quick releases will likely help there. > Instead of just fetching the main repo

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-20 Thread Matteo Merli
-- Matteo Merli On Mon, Sep 19, 2022 at 7:30 PM Baodi Shi wrote: > > The suggestion is to start the new releases for both C++ and Python from > > 3.0.0. > > In the future, Can we need to maintain a compatibility list? For the user, > how should he choose the appropriate client version to

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-20 Thread Matteo Merli
On Tue, Sep 20, 2022 at 9:32 AM Yunze Xu wrote: > > Hi Tison & Matteo, > > I noticed a comment here: > https://github.com/apache/pulsar/pull/17733#discussion_r975552686 > > Currently the Python Functions relies on the Python client. I see there are > still some Python Function examples in

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-20 Thread Yunze Xu
Hi Tison & Matteo, I noticed a comment here: https://github.com/apache/pulsar/pull/17733#discussion_r975552686 Currently the Python Functions relies on the Python client. I see there are still some Python Function examples in pulsar-functions/python-examples directory. How should we deal with

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-20 Thread tison
One more thing to mention here: Currently, Pulsar Docker Image bundles C++ client and Python client, and from my perspective, the image is mainly used as a server, perhaps we can remove these clients from bundling. Best, tison. Yunze Xu 于2022年9月20日周二 16:50写道: > Hi Tison, > > Sorry I just

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-20 Thread Yunze Xu
Hi Tison, Sorry I just missed that. Thanks for your reminder. Thanks, Yunze > On Sep 20, 2022, at 16:35, tison wrote: > > Hi Yunze, > >> Just wondering if there is a way to retain the git history in the > pulsar-client-cpp directory? > > Matteo's proposal already write: > >> git

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-20 Thread tison
I agree that we need to work on a more comprehensive documentation-building process. Perhaps let's start with removing old code https://github.com/apache/pulsar-site/pull/215. I'd say it needs a code bash to sort current logic - it's somewhat brittle depending on relative path, coupled shell

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-20 Thread tison
Hi Yunze, > Just wondering if there is a way to retain the git history in the pulsar-client-cpp directory? Matteo's proposal already write: > git filter-repo --subdirectory-filter pulsar-client-cpp So you will retain the git history. Best, tison. Yunze Xu 于2022年9月20日周二 16:27写道: > LGTM. I

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-20 Thread Yunze Xu
LGTM. I also listed the related files outside the pulsar-client-cpp directory recently: - pulsar-common/src/main/proto/PulsarApi.proto: the Pulsar binary proto file - src/gen-pulsar-version-macro.py: generate the internal version info - pulsar-client/src/test/proto/*.proto: test the protobuf

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-19 Thread Dave Fisher
Sent from my iPhone > On Sep 19, 2022, at 7:29 PM, Baodi Shi wrote: > > Hi, @merlimat. Looks good to me. > >> Both C++ and Python clients will continue with their own individual >> versioning. >> >> In order to not break anything or cause more confusion, we would need to use >> a new

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-19 Thread Dave Fisher
Hi - This is great and I agree with the plan except for one missing discussion. The work needs to either include how to create documentation in the new repository and move it to the pulsar-site repository. (This might be better as a new PIP which could also include the go and node clients

Re: [DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-19 Thread Baodi Shi
Hi, @merlimat. Looks good to me. > Both C++ and Python clients will continue with their own individual > versioning. > > In order to not break anything or cause more confusion, we would need to use > a new version that is bigger than the current version (2.11.x). > > The suggestion is to

[DISCUSS] PIP-209: Separate C++/Python clients to own repositories

2022-09-19 Thread Matteo Merli
https://github.com/apache/pulsar/issues/17724 ## Motivation Pulsar C++ code base is in the same main repository for the Pulsar project. While the decision was the right one at the time, there is a considerable overhead in keeping the C++ client in its current position. ### Issues with the