Re: [VOTE] PIP-290 Support WSS E2E encryption and not need to expose the private key to the WebSocket Proxy

Close the vote with 3(binding). Thanks Yubiao Feng On Mon, Aug 21, 2023 at 4:07 PM Yubiao Feng wrote: > Hello, Guys > > Since there are no concerns in the discussion mail, I'd like to start > voting for this PIP. > > The PIP link: https://github.com/apache/pulsar/pull/ >

Re: [VOTE] PIP-290 Support WSS E2E encryption and not need to expose the private key to the WebSocket Proxy

+1 (binding) The changes are minimal, and the concept is easy for users to understand. I support this PIP. Thanks, Bo Yubiao Feng 于2023年8月23日周三 10:49写道： > > Hi Mattison > > > but anyway. IMO, it's better to split the > > implementation PR into multiple that > > will help the reviewer review

Re: [VOTE] PIP-290 Support WSS E2E encryption and not need to expose the private key to the WebSocket Proxy

Hi Mattison > but anyway. IMO, it's better to split the > implementation PR into multiple that > will help the reviewer review this > PR more easily. Good suggestion. After removing tests, the amount of code lines should be very little. Mainly changes in the class `ProducerHandler`. > IMO,

Re: [VOTE] PIP-290 Support WSS E2E encryption and not need to expose the private key to the WebSocket Proxy

+1 (binding) This proposal looks great to me. But I've got several concerns which will not affect this PIP voting. 1. You mixed compression and E2E encryption support in one proposal. I am unsure if we should split them into two parts(compression & E2E) to help make the proposal not too

Re: [VOTE] PIP-290 Support WSS E2E encryption and not need to expose the private key to the WebSocket Proxy

+1(binding) - The motivation looks good to me. The proposal will provide a real e2e encryption solution for the WebSocket proxy - The solution looks good to me. It will not introduce break changes and will use public APIs as much as possible. And it will not introduce any extra configuration. The

Re: [VOTE] PIP-290 Support WSS E2E encryption and not need to expose the private key to the WebSocket Proxy

Sorry, the PR link in the last email is ambiguous, https://github.com/apache/pulsar/pull/20923 is the correct one. Thanks Yubiao Feng On Mon, Aug 21, 2023 at 4:07 PM Yubiao Feng wrote: > Hello, Guys > > Since there are no concerns in the discussion mail, I'd like to start > voting for this

[VOTE] PIP-290 Support WSS E2E encryption and not need to expose the private key to the WebSocket Proxy

Hello, Guys Since there are no concerns in the discussion mail, I'd like to start voting for this PIP. The PIP link: https://github.com/apache/pulsar/pull/ 20923 Thanks Yubiao Feng