Re: [DISCUSS] Skip tests for documentation related changes

2019-03-07 Thread Sijie Guo
I have talked to a few Flink committers. They are using a `flinkbot` for automating their review process. It sounds very interesting. It is a process that they might be looking for. The `flinkbot` code is here - https://github.com/rmetzger/flink-community-tools There is a discussion thread in

Re: [DISCUSS] Skip tests for documentation related changes

2019-01-28 Thread Dave Fisher
Hi - Inline Sent from my iPhone > On Jan 28, 2019, at 1:12 PM, Sijie Guo wrote: > > both adding tag or checkbox are developer driven. but it is easier to > achieve with current github pull request builder in Jenkins. > so I think the responsibility of this approach is kind of spreading across

Re: [DISCUSS] Skip tests for documentation related changes

2019-01-28 Thread Sijie Guo
both adding tag or checkbox are developer driven. but it is easier to achieve with current github pull request builder in Jenkins. so I think the responsibility of this approach is kind of spreading across contributors and committers. It is also a way to educate pulsar contributors to understand

Re: [DISCUSS] Skip tests for documentation related changes

2019-01-28 Thread Joe F
+1 to Sanjeev's suggestion On Mon, Jan 28, 2019 at 12:15 PM Sanjeev Kulkarni wrote: > If developers are in charge of checking the checkbox, it might lead to > errors. Any way to make it automatic? Since docs are restricted to certain > areas of repo, maybe we can have some rules around that? >

Re: [DISCUSS] Skip tests for documentation related changes

2019-01-28 Thread Ali Ahmed
I support it maybe a tag in the commit Header ie [Documentation] . On Mon, Jan 28, 2019 at 12:12 PM Sijie Guo wrote: > Hi all, > > Currently for every documentation change, we have run 3 precommit jobs, > java, c++ and integrationt tests. None of them is actually testing the > documentation

Re: [DISCUSS] Skip tests for documentation related changes

2019-01-28 Thread Sanjeev Kulkarni
If developers are in charge of checking the checkbox, it might lead to errors. Any way to make it automatic? Since docs are restricted to certain areas of repo, maybe we can have some rules around that? On Mon, Jan 28, 2019 at 12:12 PM Sijie Guo wrote: > Hi all, > > Currently for every