+1
- Local build passed
- Apache License formats are ok
- Binary packages look ok by verifying local standalone
Tested on MacOS 10.13.5
On Fri, 21 Dec 2018 at 12:52, Masahiro Sakamoto
wrote:
> +1 (binding)
>
> - check signatures
> - RAT check
> - compile and unit tests
> -
Hi All,
+1.
I have also a couple of addition:
1- Issue Id can also be added to title if we have. This template is also
used by Apache Spark.
e.g: [Issue-Id][Component] Title
2- If created PR is a following one with existing PR, it can be useful to
be linked/mentioned in new one for reviewers.
Agree. For System like pulsar Documentation and Stability is far more
important to gain large-scale adoption.
On Fri, 21 Dec 2018 at 11:24, Sijie Guo wrote:
> Hi all,
>
> With the increase of contributions, more and more features are added pretty
> quickly.
> However, these features are either
+1 (binding)
- check signatures
- RAT check
- compile and unit tests
- standalone/producer/consumer/function/connector worked
- can build Go client using RPM/DEB packages
However, `go get` and `go build` seem to fail unless they are executed in the
following steps:
# go get -u -d
+1 (binding)
- check signatures
- compile the source
- standalone/producer/consumer worked
- function/connector worked
- can build go client using rpm/deb packages
Nozomi
差出人: Jia Zhai
送信日時: 2018年12月21日 19:03:20
宛先: dev@pulsar.apache.org
件名: Re: [VOTE] Pulsar
+1 binding
macOS 10.14.1
- compile the source
- signatures are good
- binary package is good by verifying standalone
On Fri, Dec 21, 2018 at 2:04 PM Sijie Guo wrote:
> +1 binding
>
> - compile the source
> - signatures are good
> - binary package is good by verifying standalone
>
> - Sijie
>
>
