Re: [PROPOSAL] PIP 75: Replace protobuf code generator

2020-12-23 Thread Matteo Merli
On Wed, Dec 23, 2020 at 11:45 AM Enrico Olivelli wrote: > I guess we cannot leverage it on BK as we are with Protobuf 3.x The initial focus was for Proto2, though with few changes we can also support the proto3 syntax. -- Matteo Merli

Re: [PROPOSAL] PIP 75: Replace protobuf code generator

2020-12-23 Thread Enrico Olivelli
Dave, Il Mer 23 Dic 2020, 19:58 Dave Fisher ha scritto: > > > > On Dec 23, 2020, at 10:55 AM, Matteo Merli > wrote: > > > > Hi Dave, > > > > these are not dependencies that are needed (or would be pulled) from > > the Pulsar build. > > > > The JMH is only used if someone wants to run a

Re: [PROPOSAL] PIP 75: Replace protobuf code generator

2020-12-23 Thread Dave Fisher
> On Dec 23, 2020, at 10:55 AM, Matteo Merli wrote: > > Hi Dave, > > these are not dependencies that are needed (or would be pulled) from > the Pulsar build. > > The JMH is only used if someone wants to run a benchmark on the > LightProto code. Pulsar does not depend on that. Excellent.

Re: [PROPOSAL] PIP 75: Replace protobuf code generator

2020-12-23 Thread Matteo Merli
Hi Dave, these are not dependencies that are needed (or would be pulled) from the Pulsar build. The JMH is only used if someone wants to run a benchmark on the LightProto code. Pulsar does not depend on that. >From Pulsar build we would need: 1. At build time -> The LightProto Maven Plugin

Re: [PROPOSAL] PIP 75: Replace protobuf code generator

2020-12-23 Thread Dave Fisher
Hi Matteo, I looked at the dependencies in Splunk LightPro and the following are not acceptable in an Apache Binary: org.openjdk.jmh jmh-core ${jmh.version} org.openjdk.jmh

[PROPOSAL] PIP 75: Replace protobuf code generator

2020-12-23 Thread Matteo Merli
## Motivation In the Pulsar wire protocol, we are using Google Protobuf in order to perform serialization/deserialization of the commands that are exchanged between clients and brokers. Because of the overhead involved with the regular Protobuf implementation, since very early on, we have been