Re: CI builds on Jenkins

2017-08-02 Thread Rajan Dhabalia
> Another option would be to make the Jenkins build status non-mandatory for merging the PRs. Then we might want to be careful before merging because flaky tests might be failing due to genuine reason or bug. Probably, we can keep it enable for sometime and disable if we really think that flaky te

Re: CI builds on Jenkins

2017-08-02 Thread Matteo Merli
Another option would be to make the Jenkins build status non-mandatory for merging the PRs. In this case, if we see any known flaky tests, we could proceed with merging. For any new failing test, we should re-run the build and create a new issue to track it. Pros: * We don't have to spend big

Re: CI builds on Jenkins

2017-08-02 Thread Matteo Merli
Reading on the Jenkins Github plugin documentation at https://wiki.jenkins.io/display/JENKINS/GitHub+pull+request+builder+plugin You can trigger the build of a PR by adding a comment "retest this please" on the PR itself. This will kick a new build that will properly update the PR status. This wi

Re: CI builds on Jenkins

2017-08-02 Thread Matteo Merli
As most of you have seen, we have a bunch of intermittent test failures. This, added to the difficulties in rebuilding a pull-request and updating the status lead to a bit of a cumbersome process to get a PR merged. I have created issues for the tests I've seen failing and marked them with label

CI builds on Jenkins

2017-08-01 Thread Matteo Merli
As we discussed some time back, I have added CI builds in Jenkins. Jenkins seems to be much more stable compare to Travis and it's bit more flexible in terms of what we can do. For example, for C++ build we can use custom Docker image with all the dependencies we require to build the Pulsar client