Re: PIP 20: Mechanism to revoke TLS authentication

2018-09-06 Thread Ivan Kelly
That said, it is stored in Json so it wouldn't be much work to sort one of the values as a list of strings. -Ivan On Thu, Sep 6, 2018 at 10:55 AM, Ivan Kelly wrote: > PIP updated. The one thing that isn't 100% clean with the dynamic > configuration keys is that they only support string as value,

Re: PIP 20: Mechanism to revoke TLS authentication

2018-09-06 Thread Ivan Kelly
PIP updated. The one thing that isn't 100% clean with the dynamic configuration keys is that they only support string as value, so the list of revoked keys needs some sort of serialization. -Ivan On Thu, Sep 6, 2018 at 10:41 AM, Ivan Kelly wrote: > On Tue, Aug 21, 2018 at 3:57 AM, Rajan Dhabalia

Re: PIP 20: Mechanism to revoke TLS authentication

2018-09-06 Thread Ivan Kelly
On Tue, Aug 21, 2018 at 3:57 AM, Rajan Dhabalia wrote: >> I will consider both this and system topics and update the PIP. > > I think we should avoid more complexity by introducing system topic to > store "subject key" and then process it. Instead we can store it to > global/config zk as it requir

Re: PIP 20: Mechanism to revoke TLS authentication

2018-08-20 Thread Rajan Dhabalia
> I will consider both this and system topics and update the PIP. I think we should avoid more complexity by introducing system topic to store "subject key" and then process it. Instead we can store it to global/config zk as it requires to store keys with few bytes. I think dynamic-configuration m

Re: PIP 20: Mechanism to revoke TLS authentication

2018-08-20 Thread Sijie Guo
On Mon, Aug 20, 2018 at 5:59 AM Ivan Kelly wrote: > > Instead of using zookeeper, can we consider using a managed ledger or a > system topic for keeping all these revoked keys? > > Do we already have an example of a system topic in use? Functions is using system topics. And all its topics are u

Re: PIP 20: Mechanism to revoke TLS authentication

2018-08-20 Thread Ivan Kelly
> Here, we would like to configure "subject-key-identifier" at every broker in the cluster dynamically. We also want to perform certain actions once this configuration-value has been changed. Ah, i didn't know this existed. Very useful. I will consider both this and system topics and update the PI

Re: PIP 20: Mechanism to revoke TLS authentication

2018-08-20 Thread Ivan Kelly
> Instead of using zookeeper, can we consider using a managed ledger or a system topic for keeping all these revoked keys? Do we already have an example of a system topic in use? Is there a custom namespace that's restricted to the admin role? -Ivan

Re: PIP 20: Mechanism to revoke TLS authentication

2018-08-14 Thread Rajan Dhabalia
Hi, Here, we would like to configure "subject-key-identifier" at every broker in the cluster dynamically. We also want to perform certain actions once this configuration-value has been changed. Broker's dynamic configuration is introduced for such usecases where dynamic-config value gets stored i

Re: PIP 20: Mechanism to revoke TLS authentication

2018-08-13 Thread Sanjeev Kulkarni
+1 to Sijie's suggestion to keep this inside a managed ledger. On Mon, Aug 13, 2018 at 3:34 PM Sijie Guo wrote: > Ivan, > > Thank you for writing this up. This PIP looks great to me! +1 > > just one question: > > > This will add the subject key identifier to zookeeper under > /tls/revoked/. All

Re: PIP 20: Mechanism to revoke TLS authentication

2018-08-13 Thread Sijie Guo
Ivan, Thank you for writing this up. This PIP looks great to me! +1 just one question: > This will add the subject key identifier to zookeeper under /tls/revoked/. All brokers and proxies cache the children /tls/revoked. Instead of using zookeeper, can we consider using a managed ledger or a sy

PIP 20: Mechanism to revoke TLS authentication

2018-08-07 Thread Ivan Kelly
Hi folks, This is a PIP to add a mechanism to block TLS client certs from accessing Pulsar if they have been compromised. This is a relatively small change, but I thought it best to put it to the community before moving ahead with it, as people may have opinions on the approach. The PIP is here: