Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-04 Thread Francis Liu
Done.  Thanks for the reminder Dave. Francis On Friday, August 4, 2017 12:52 PM, Dave Fisher wrote: Hi Francis, Would you mention your vote on the general@incubator thread? That will give 3 +1 IPMC Binding VOTEs! Regards, Dave > On Aug 4, 2017, at 11:25 AM,

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-04 Thread Dave Fisher
Hi Francis, Would you mention your vote on the general@incubator thread? That will give 3 +1 IPMC Binding VOTEs! Regards, Dave > On Aug 4, 2017, at 11:25 AM, Francis Liu wrote: > > I see thanks for confirming the flakey tests. >> Shouldn't that be "apache-rat:check" the

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-04 Thread Francis Liu
I see thanks for confirming the flakey tests.  > Shouldn't that be "apache-rat:check" the official tool?Yes you are right my >bad. It seems rat:check runs a very old version of the tool which ignored the >rat configurations in the pom.  > Would it be ok to fix in next release?Yes. Not familiar

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-03 Thread Matteo Merli
Thanks Francis, On Thu, Aug 3, 2017 at 5:39 PM Francis Liu wrote: > Ran mvn clean install on my macbook pro (sierra) twice and it failed > during unit testing. Are these just flakey? (jdk 1.8.0_45-b14) > DiscoveryServiceTest.testClientServerConnectionTls:149 expected [true]

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-03 Thread Francis Liu
Ran mvn clean install on my macbook pro (sierra) twice and it failed during unit testing. Are these just flakey? (jdk 1.8.0_45-b14) DiscoveryServiceTest.testClientServerConnectionTls:149 expected [true] but found [false]

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-03 Thread Jai Asher
+1 Release! - Checked build success - Ran the binaries on my local machine Jai On Thu, Aug 3, 2017 at 4:19 PM, Sahaya Andrews wrote: > +1 > > Environment: RHEL 6.4 > - Verified checksum > - Ran local build against the src distribution > - Ran standalone server from the

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-03 Thread Sahaya Andrews
+1 Environment: RHEL 6.4 - Verified checksum - Ran local build against the src distribution - Ran standalone server from the binary distribution - Ran perf producer and consumer test against locally built binary and binary distribution I did not see any errors in producer/consumer/pulsar logs.

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-03 Thread Yuki Shiga
--- > From: Jia Zhai [mailto:zhaiji...@gmail.com] > Sent: Thursday, August 03, 2017 10:59 AM > To: dev@pulsar.incubator.apache.org > Subject: Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0 > > +1 (non-binding) > - verified the packages (

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-02 Thread Jia Zhai
+1 (non-binding) - verified the packages (md5, sha1 and signature) - Checked the build success - Run the binaries by 'bin/pulsar standalone' On Thu, Aug 3, 2017 at 8:57 AM, Nozomi Kurihara wrote: > +1 > > - Confirmed md5 > - Checked the build success > - Ran the binaries

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-02 Thread Nozomi Kurihara
+1 - Confirmed md5 - Checked the build success - Ran the binaries Thanks! Nozomi 2017/08/03 9:32 に、"Sijie Guo" を書き込みました: +1 (non-binding) - verified the packages (md5, sha1 and signature) - maven artifacts looks good to me. - successfully build the

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-02 Thread Sijie Guo
+1 (non-binding) - verified the packages (md5, sha1 and signature) - maven artifacts looks good to me. - successfully build the source package - run the binary package following the instructions in the website - Sijie On Wed, Aug 2, 2017 at 3:07 PM, Rajan Dhabalia wrote:

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-02 Thread Rajan Dhabalia
+1. I ran the regression-tests and few of the load-tests with this version and looks fine. Thanks, Rajan On Wed, Aug 2, 2017 at 1:36 PM, Dave Fisher wrote: > Hi - > > I will cast an IPMC vote. > > +1 Release! > > I checked the source and binary package hashes. > I built

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-02 Thread Dave Fisher
Hi - I will cast an IPMC vote. +1 Release! I checked the source and binary package hashes. I built the project with Maven from the source package. I ran the rat check and checked the rat report. Discussed the Category B issues which look good for now. Regards, Dave > On Aug 2, 2017, at 12:47

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-02 Thread Matteo Merli
Remainder for all committers: please check the release artifacts and vote on this thread, before tomorrow 3pm PDT. Vote as in : [ ] +1 Release this package [ ] 0 I don't feel strongly about it, but don't object [ ] -1 Do not release this package because... The documentation on the release