Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-04 Thread Francis Liu 
Done. 
Thanks for the reminder Dave.
Francis 

On Friday, August 4, 2017 12:52 PM, Dave Fisher <dave2w...@comcast.net> 
wrote:
 

 Hi Francis,

Would you mention your vote on the general@incubator thread? That will give 3 
+1 IPMC Binding VOTEs!

Regards,
Dave

> On Aug 4, 2017, at 11:25 AM, Francis Liu <tof...@apache.org> wrote:
> 
> I see thanks for confirming the flakey tests.
>>  Shouldn't that be "apache-rat:check" the official tool?Yes you are right my 
>>bad. It seems rat:check runs a very old version of the tool which ignored the 
>>rat configurations in the pom.
>>  Would it be ok to fix in next release?Yes. Not familiar with the file but 
>>looks fairly straightforward.
> +1, verified sha,md5 and gpg.
> 
>    On Thursday, August 3, 2017 6:05 PM, Matteo Merli <mme...@apache.org> 
>wrote:
> 
> 
> Thanks Francis,
> 
> On Thu, Aug 3, 2017 at 5:39 PM Francis Liu <tof...@apache.org> wrote:
> 
>> Ran mvn clean install on my macbook pro (sierra) twice and it failed
>> during unit testing. Are these just flakey? (jdk 1.8.0_45-b14)
>> DiscoveryServiceTest.testClientServerConnectionTls:149 expected [true] but
>> found [false]
>> 
> 
> This test was flakey, but in theory should have been fixed long ago in
> https://github.com/apache/incubator-pulsar/issues/116
> I haven't seen it failing in a long time.
> 
> org.apache.pulsar.broker.admin.AdminApiTest.testIncrementPartitionsOfTopic(org.apache.pulsar.broker.admin.AdminApiTest)
>> Run 1: AdminApiTest.
> 
> ...
> 
> on AdminApiTest there is testIncrementPartitionsOfTopic which a flaky test
> for which we have an issue open at:
> https://github.com/apache/incubator-pulsar/issues/635
> 
> This test causes the subsequent tests on the same class to fail as well.
> 
> 
>> Also ran mvn rat:check. Was wondering if this file needs a header:
>> dashboard/conf/uwsgi_params?
>> 
> 
> Shouldn't that be "apache-rat:check" the official tool? We run it in CI
> builds and I've run it multiple times on src package as well and it should
> work.
> For "dashboard/conf/uwsgi_params" I wasn't sure if the uwsgi tools were
> handling comments correctly. I will test it out and and add headers if it
> works.
> Would it be ok to fix in next release?
> 
> 
> 
> Matteo
> --
> Matteo Merli
> <mme...@apache.org>
> 
>

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-04 Thread Francis Liu 
I see thanks for confirming the flakey tests. 
> Shouldn't that be "apache-rat:check" the official tool?Yes you are right my 
>bad. It seems rat:check runs a very old version of the tool which ignored the 
>rat configurations in the pom. 
> Would it be ok to fix in next release?Yes. Not familiar with the file but 
>looks fairly straightforward. 
+1, verified sha,md5 and gpg. 

On Thursday, August 3, 2017 6:05 PM, Matteo Merli <mme...@apache.org> wrote:
 

 Thanks Francis,

On Thu, Aug 3, 2017 at 5:39 PM Francis Liu <tof...@apache.org> wrote:

> Ran mvn clean install on my macbook pro (sierra) twice and it failed
> during unit testing. Are these just flakey? (jdk 1.8.0_45-b14)
> DiscoveryServiceTest.testClientServerConnectionTls:149 expected [true] but
> found [false]
>

This test was flakey, but in theory should have been fixed long ago in
https://github.com/apache/incubator-pulsar/issues/116
I haven't seen it failing in a long time.

org.apache.pulsar.broker.admin.AdminApiTest.testIncrementPartitionsOfTopic(org.apache.pulsar.broker.admin.AdminApiTest)
> Run 1: AdminApiTest.

...

on AdminApiTest there is testIncrementPartitionsOfTopic which a flaky test
for which we have an issue open at:
https://github.com/apache/incubator-pulsar/issues/635

This test causes the subsequent tests on the same class to fail as well.


> Also ran mvn rat:check. Was wondering if this file needs a header:
> dashboard/conf/uwsgi_params?
>

Shouldn't that be "apache-rat:check" the official tool? We run it in CI
builds and I've run it multiple times on src package as well and it should
work.
For "dashboard/conf/uwsgi_params" I wasn't sure if the uwsgi tools were
handling comments correctly. I will test it out and and add headers if it
works.
Would it be ok to fix in next release?



Matteo
-- 
Matteo Merli
<mme...@apache.org>

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

2017-08-03 Thread Francis Liu 
Ran mvn clean install on my macbook pro (sierra) twice and it failed during 
unit testing. Are these just flakey? (jdk 1.8.0_45-b14)
DiscoveryServiceTest.testClientServerConnectionTls:149 expected [true] but 
found [false]

org.apache.pulsar.broker.admin.AdminApiTest.testIncrementPartitionsOfTopic(org.apache.pulsar.broker.admin.AdminApiTest)
  Run 1: AdminApiTest.testIncrementPartitionsOfTopic » ServerSideError Some 
error occou...  Run 2: AdminApiTest.testIncrementPartitionsOfTopic:1761 
expected [8] but found [12]
  AdminApiTest.testNamespaceSplitBundle:878 null: lists don't have the same 
size expected [1] but found [13]  AdminApiTest.testNamespaceUnloadBundle:898 
null: lists don't have the same size expected [0] but found [12]  
AdminApiTest.testPersistentTopicsExpireMessages:1489 null: lists don't have the 
same size expected [1] but found 
[13]org.apache.pulsar.broker.admin.AdminApiTest.testPulsarAdminForUriAndUrlEncoding(org.apache.pulsar.broker.admin.AdminApiTest)
  Run 1: AdminApiTest.testPulsarAdminForUriAndUrlEncoding:1690 expected [1] but 
found [3]  Run 2: AdminApiTest.testPulsarAdminForUriAndUrlEncoding:1690 
expected [1] but found [3]
Also ran mvn rat:check. Was wondering if this file needs a header: 
dashboard/conf/uwsgi_params?
Thanks,Francis
 

On Thursday, August 3, 2017 5:53 AM, Masakazu Kitajo  
wrote:
 

 +0

Ran standalone server on macOS 10.12 / Java 8, with Java client.

I saw lots of warnings and a few errors during building from the source
package, I was able to run standalone server and successfully transferred a
message with pulsar-client though. It seems they are not critical. I'll
create issues for each warnings and errors later.

Also, I followed Getting started on our documentation, however, the steps
to build are only on README file. It's not user friendly. We should improve
it before announcing the release.

Committers, it would be great if you could write down about your
environment (e.g. OS, Java version, compiler, etc) when you cast a vote.
Since we support Linux and macOS (and a few languages for clients), we
should confirm that the new version works on the environments we support.

Thanks,
Masakazu



On Thu, Aug 3, 2017 at 4:47 AM, Matteo Merli  wrote:

> Remainder for all committers:
>
> please check the release artifacts and vote on this thread, before tomorrow
> 3pm PDT.
>
> Vote as in :
>
> [ ] +1 Release this package
> [ ] 0 I don't feel strongly about it, but don't object
> [ ] -1 Do not release this package because...
>
>
> The documentation on the release process and what needs to be included can
> be found at:
>    - https://incubator.apache.org/guides/releasemanagement.html
>    - http://www.apache.org/legal/release-policy.html
>    - http://www.apache.org/dev/release-distribution.html
>    - http://www.apache.org/dev/release-publishing.html
>    - http://www.apache.org/dev/publishing-maven-artifacts.html
>
> --
> Matteo Merli
> 
>
> On Mon, Jul 31, 2017 at 2:39 PM, Matteo Merli  wrote:
>
> > This is the first release candidate for Apache Pulsar, version
> > 1.19.0-incubating.
> >
> > Major changes included in this release are:
> >  * Added stateless Pulsar proxy
> >  * Support for non-persistent topics
> >  * Upgraded RocksDB to comply with ASF policy
> >  * Instrumentation of ZooKeeper client to expose metrics
> >  * Fixes for TLS auth in WebSocket proxy
> >
> >
> > Complete list of changes can be found at:
> >
> > https://github.com/apache/incubator-pulsar/milestone/8?closed=1
> >
> > *** Please download, test and vote by August 3th 2017, 15:00 PDT.
> >
> > Note that we are voting upon the source (tag), binaries are provided for
> > convenience.
> >
> > Source and binary files:
> > https://dist.apache.org/repos/dist/dev/incubator/pulsar/
> > pulsar-1.19.0-incubating-candidate-0/
> >
> > Maven staging repo:
> > https://repository.apache.org/content/repositories/orgapachepulsar-1000/
> >
> > The tag to be voted upon:
> > v1.19.0-incubating-candidate-0 (5125279b50f7a3da8c211b698580e1
> d2f4dd65e2)
> >
> > Pulsar's KEYS file containing PGP keys we use to sign the release:
> > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> >
> > Please download the the source package, and follow the README to build
> > and run the Pulsar standalone service.
> >
> >
> >
> > --
> > Matteo Merli
> > 
> >
>