Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Francis Liu]

Done. 
Thanks for the reminder Dave.
Francis 

On Friday, August 4, 2017 12:52 PM, Dave Fisher  
wrote:
 

 Hi Francis,

Would you mention your vote on the general@incubator thread? That will give 3 
+1 IPMC Binding VOTEs!

Regards,
Dave

> On Aug 4, 2017, at 11:25 AM, Francis Liu  wrote:
> 
> I see thanks for confirming the flakey tests.
>>  Shouldn't that be "apache-rat:check" the official tool?Yes you are right my 
>>bad. It seems rat:check runs a very old version of the tool which ignored the 
>>rat configurations in the pom.
>>  Would it be ok to fix in next release?Yes. Not familiar with the file but 
>>looks fairly straightforward.
> +1, verified sha,md5 and gpg.
> 
>    On Thursday, August 3, 2017 6:05 PM, Matteo Merli  
>wrote:
> 
> 
> Thanks Francis,
> 
> On Thu, Aug 3, 2017 at 5:39 PM Francis Liu  wrote:
> 
>> Ran mvn clean install on my macbook pro (sierra) twice and it failed
>> during unit testing. Are these just flakey? (jdk 1.8.0_45-b14)
>> DiscoveryServiceTest.testClientServerConnectionTls:149 expected [true] but
>> found [false]
>> 
> 
> This test was flakey, but in theory should have been fixed long ago in
> https://github.com/apache/incubator-pulsar/issues/116
> I haven't seen it failing in a long time.
> 
> org.apache.pulsar.broker.admin.AdminApiTest.testIncrementPartitionsOfTopic(org.apache.pulsar.broker.admin.AdminApiTest)
>> Run 1: AdminApiTest.
> 
> ...
> 
> on AdminApiTest there is testIncrementPartitionsOfTopic which a flaky test
> for which we have an issue open at:
> https://github.com/apache/incubator-pulsar/issues/635
> 
> This test causes the subsequent tests on the same class to fail as well.
> 
> 
>> Also ran mvn rat:check. Was wondering if this file needs a header:
>> dashboard/conf/uwsgi_params?
>> 
> 
> Shouldn't that be "apache-rat:check" the official tool? We run it in CI
> builds and I've run it multiple times on src package as well and it should
> work.
> For "dashboard/conf/uwsgi_params" I wasn't sure if the uwsgi tools were
> handling comments correctly. I will test it out and and add headers if it
> works.
> Would it be ok to fix in next release?
> 
> 
> 
> Matteo
> --
> Matteo Merli
> 
> 
> 


   

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Dave Fisher]

Hi Francis,

Would you mention your vote on the general@incubator thread? That will give 3 
+1 IPMC Binding VOTEs!

Regards,
Dave

> On Aug 4, 2017, at 11:25 AM, Francis Liu  wrote:
> 
> I see thanks for confirming the flakey tests.
>>  Shouldn't that be "apache-rat:check" the official tool?Yes you are right my 
>> bad. It seems rat:check runs a very old version of the tool which ignored 
>> the rat configurations in the pom.
>>  Would it be ok to fix in next release?Yes. Not familiar with the file but 
>> looks fairly straightforward.
> +1, verified sha,md5 and gpg.
> 
>On Thursday, August 3, 2017 6:05 PM, Matteo Merli  
> wrote:
> 
> 
> Thanks Francis,
> 
> On Thu, Aug 3, 2017 at 5:39 PM Francis Liu  wrote:
> 
>> Ran mvn clean install on my macbook pro (sierra) twice and it failed
>> during unit testing. Are these just flakey? (jdk 1.8.0_45-b14)
>> DiscoveryServiceTest.testClientServerConnectionTls:149 expected [true] but
>> found [false]
>> 
> 
> This test was flakey, but in theory should have been fixed long ago in
> https://github.com/apache/incubator-pulsar/issues/116
> I haven't seen it failing in a long time.
> 
> org.apache.pulsar.broker.admin.AdminApiTest.testIncrementPartitionsOfTopic(org.apache.pulsar.broker.admin.AdminApiTest)
>> Run 1: AdminApiTest.
> 
> ...
> 
> on AdminApiTest there is testIncrementPartitionsOfTopic which a flaky test
> for which we have an issue open at:
> https://github.com/apache/incubator-pulsar/issues/635
> 
> This test causes the subsequent tests on the same class to fail as well.
> 
> 
>> Also ran mvn rat:check. Was wondering if this file needs a header:
>> dashboard/conf/uwsgi_params?
>> 
> 
> Shouldn't that be "apache-rat:check" the official tool? We run it in CI
> builds and I've run it multiple times on src package as well and it should
> work.
> For "dashboard/conf/uwsgi_params" I wasn't sure if the uwsgi tools were
> handling comments correctly. I will test it out and and add headers if it
> works.
> Would it be ok to fix in next release?
> 
> 
> 
> Matteo
> --
> Matteo Merli
> 
> 
> 



signature.asc
Description: Message signed with OpenPGP

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Francis Liu]

I see thanks for confirming the flakey tests. 
> Shouldn't that be "apache-rat:check" the official tool?Yes you are right my 
>bad. It seems rat:check runs a very old version of the tool which ignored the 
>rat configurations in the pom. 
> Would it be ok to fix in next release?Yes. Not familiar with the file but 
>looks fairly straightforward. 
+1, verified sha,md5 and gpg. 

On Thursday, August 3, 2017 6:05 PM, Matteo Merli  wrote:
 

 Thanks Francis,

On Thu, Aug 3, 2017 at 5:39 PM Francis Liu  wrote:

> Ran mvn clean install on my macbook pro (sierra) twice and it failed
> during unit testing. Are these just flakey? (jdk 1.8.0_45-b14)
> DiscoveryServiceTest.testClientServerConnectionTls:149 expected [true] but
> found [false]
>

This test was flakey, but in theory should have been fixed long ago in
https://github.com/apache/incubator-pulsar/issues/116
I haven't seen it failing in a long time.

org.apache.pulsar.broker.admin.AdminApiTest.testIncrementPartitionsOfTopic(org.apache.pulsar.broker.admin.AdminApiTest)
> Run 1: AdminApiTest.

...

on AdminApiTest there is testIncrementPartitionsOfTopic which a flaky test
for which we have an issue open at:
https://github.com/apache/incubator-pulsar/issues/635

This test causes the subsequent tests on the same class to fail as well.


> Also ran mvn rat:check. Was wondering if this file needs a header:
> dashboard/conf/uwsgi_params?
>

Shouldn't that be "apache-rat:check" the official tool? We run it in CI
builds and I've run it multiple times on src package as well and it should
work.
For "dashboard/conf/uwsgi_params" I wasn't sure if the uwsgi tools were
handling comments correctly. I will test it out and and add headers if it
works.
Would it be ok to fix in next release?



Matteo
-- 
Matteo Merli



   

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Matteo Merli]

Thanks Francis,

On Thu, Aug 3, 2017 at 5:39 PM Francis Liu  wrote:

> Ran mvn clean install on my macbook pro (sierra) twice and it failed
> during unit testing. Are these just flakey? (jdk 1.8.0_45-b14)
> DiscoveryServiceTest.testClientServerConnectionTls:149 expected [true] but
> found [false]
>

This test was flakey, but in theory should have been fixed long ago in
https://github.com/apache/incubator-pulsar/issues/116
I haven't seen it failing in a long time.

org.apache.pulsar.broker.admin.AdminApiTest.testIncrementPartitionsOfTopic(org.apache.pulsar.broker.admin.AdminApiTest)
> Run 1: AdminApiTest.

...

on AdminApiTest there is testIncrementPartitionsOfTopic which a flaky test
for which we have an issue open at:
https://github.com/apache/incubator-pulsar/issues/635

This test causes the subsequent tests on the same class to fail as well.


> Also ran mvn rat:check. Was wondering if this file needs a header:
> dashboard/conf/uwsgi_params?
>

Shouldn't that be "apache-rat:check" the official tool? We run it in CI
builds and I've run it multiple times on src package as well and it should
work.
For "dashboard/conf/uwsgi_params" I wasn't sure if the uwsgi tools were
handling comments correctly. I will test it out and and add headers if it
works.
Would it be ok to fix in next release?



Matteo
-- 
Matteo Merli

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Francis Liu]

Ran mvn clean install on my macbook pro (sierra) twice and it failed during 
unit testing. Are these just flakey? (jdk 1.8.0_45-b14)
DiscoveryServiceTest.testClientServerConnectionTls:149 expected [true] but 
found [false]

org.apache.pulsar.broker.admin.AdminApiTest.testIncrementPartitionsOfTopic(org.apache.pulsar.broker.admin.AdminApiTest)
  Run 1: AdminApiTest.testIncrementPartitionsOfTopic » ServerSideError Some 
error occou...  Run 2: AdminApiTest.testIncrementPartitionsOfTopic:1761 
expected [8] but found [12]
  AdminApiTest.testNamespaceSplitBundle:878 null: lists don't have the same 
size expected [1] but found [13]  AdminApiTest.testNamespaceUnloadBundle:898 
null: lists don't have the same size expected [0] but found [12]  
AdminApiTest.testPersistentTopicsExpireMessages:1489 null: lists don't have the 
same size expected [1] but found 
[13]org.apache.pulsar.broker.admin.AdminApiTest.testPulsarAdminForUriAndUrlEncoding(org.apache.pulsar.broker.admin.AdminApiTest)
  Run 1: AdminApiTest.testPulsarAdminForUriAndUrlEncoding:1690 expected [1] but 
found [3]  Run 2: AdminApiTest.testPulsarAdminForUriAndUrlEncoding:1690 
expected [1] but found [3]
Also ran mvn rat:check. Was wondering if this file needs a header: 
dashboard/conf/uwsgi_params?
Thanks,Francis
 

On Thursday, August 3, 2017 5:53 AM, Masakazu Kitajo  
wrote:
 

 +0

Ran standalone server on macOS 10.12 / Java 8, with Java client.

I saw lots of warnings and a few errors during building from the source
package, I was able to run standalone server and successfully transferred a
message with pulsar-client though. It seems they are not critical. I'll
create issues for each warnings and errors later.

Also, I followed Getting started on our documentation, however, the steps
to build are only on README file. It's not user friendly. We should improve
it before announcing the release.

Committers, it would be great if you could write down about your
environment (e.g. OS, Java version, compiler, etc) when you cast a vote.
Since we support Linux and macOS (and a few languages for clients), we
should confirm that the new version works on the environments we support.

Thanks,
Masakazu



On Thu, Aug 3, 2017 at 4:47 AM, Matteo Merli  wrote:

> Remainder for all committers:
>
> please check the release artifacts and vote on this thread, before tomorrow
> 3pm PDT.
>
> Vote as in :
>
> [ ] +1 Release this package
> [ ] 0 I don't feel strongly about it, but don't object
> [ ] -1 Do not release this package because...
>
>
> The documentation on the release process and what needs to be included can
> be found at:
>    - https://incubator.apache.org/guides/releasemanagement.html
>    - http://www.apache.org/legal/release-policy.html
>    - http://www.apache.org/dev/release-distribution.html
>    - http://www.apache.org/dev/release-publishing.html
>    - http://www.apache.org/dev/publishing-maven-artifacts.html
>
> --
> Matteo Merli
> 
>
> On Mon, Jul 31, 2017 at 2:39 PM, Matteo Merli  wrote:
>
> > This is the first release candidate for Apache Pulsar, version
> > 1.19.0-incubating.
> >
> > Major changes included in this release are:
> >  * Added stateless Pulsar proxy
> >  * Support for non-persistent topics
> >  * Upgraded RocksDB to comply with ASF policy
> >  * Instrumentation of ZooKeeper client to expose metrics
> >  * Fixes for TLS auth in WebSocket proxy
> >
> >
> > Complete list of changes can be found at:
> >
> > https://github.com/apache/incubator-pulsar/milestone/8?closed=1
> >
> > *** Please download, test and vote by August 3th 2017, 15:00 PDT.
> >
> > Note that we are voting upon the source (tag), binaries are provided for
> > convenience.
> >
> > Source and binary files:
> > https://dist.apache.org/repos/dist/dev/incubator/pulsar/
> > pulsar-1.19.0-incubating-candidate-0/
> >
> > Maven staging repo:
> > https://repository.apache.org/content/repositories/orgapachepulsar-1000/
> >
> > The tag to be voted upon:
> > v1.19.0-incubating-candidate-0 (5125279b50f7a3da8c211b698580e1
> d2f4dd65e2)
> >
> > Pulsar's KEYS file containing PGP keys we use to sign the release:
> > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> >
> > Please download the the source package, and follow the README to build
> > and run the Pulsar standalone service.
> >
> >
> >
> > --
> > Matteo Merli
> > 
> >
>


   

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Jai Asher]

+1 Release!

- Checked build success
- Ran the binaries on my local machine

Jai

On Thu, Aug 3, 2017 at 4:19 PM, Sahaya Andrews  wrote:

> +1
>
> Environment: RHEL 6.4
> - Verified checksum
> - Ran local build against the src distribution
> - Ran standalone server from the binary distribution
> - Ran perf producer and consumer test against locally built binary and
> binary distribution
>
> I did not see any errors in producer/consumer/pulsar logs.
>
> Thanks,
> Andrews.
>
>
> On Thu, Aug 3, 2017 at 5:53 AM, Masakazu Kitajo  wrote:
> > +0
> >
> > Ran standalone server on macOS 10.12 / Java 8, with Java client.
> >
> > I saw lots of warnings and a few errors during building from the source
> > package, I was able to run standalone server and successfully
> transferred a
> > message with pulsar-client though. It seems they are not critical. I'll
> > create issues for each warnings and errors later.
> >
> > Also, I followed Getting started on our documentation, however, the steps
> > to build are only on README file. It's not user friendly. We should
> improve
> > it before announcing the release.
> >
> > Committers, it would be great if you could write down about your
> > environment (e.g. OS, Java version, compiler, etc) when you cast a vote.
> > Since we support Linux and macOS (and a few languages for clients), we
> > should confirm that the new version works on the environments we support.
> >
> > Thanks,
> > Masakazu
> >
> >
> >
> > On Thu, Aug 3, 2017 at 4:47 AM, Matteo Merli  wrote:
> >
> >> Remainder for all committers:
> >>
> >> please check the release artifacts and vote on this thread, before
> tomorrow
> >> 3pm PDT.
> >>
> >> Vote as in :
> >>
> >> [ ] +1 Release this package
> >> [ ] 0 I don't feel strongly about it, but don't object
> >> [ ] -1 Do not release this package because...
> >>
> >>
> >> The documentation on the release process and what needs to be included
> can
> >> be found at:
> >>- https://incubator.apache.org/guides/releasemanagement.html
> >>- http://www.apache.org/legal/release-policy.html
> >>- http://www.apache.org/dev/release-distribution.html
> >>- http://www.apache.org/dev/release-publishing.html
> >>- http://www.apache.org/dev/publishing-maven-artifacts.html
> >>
> >> --
> >> Matteo Merli
> >> 
> >>
> >> On Mon, Jul 31, 2017 at 2:39 PM, Matteo Merli 
> wrote:
> >>
> >> > This is the first release candidate for Apache Pulsar, version
> >> > 1.19.0-incubating.
> >> >
> >> > Major changes included in this release are:
> >> >  * Added stateless Pulsar proxy
> >> >  * Support for non-persistent topics
> >> >  * Upgraded RocksDB to comply with ASF policy
> >> >  * Instrumentation of ZooKeeper client to expose metrics
> >> >  * Fixes for TLS auth in WebSocket proxy
> >> >
> >> >
> >> > Complete list of changes can be found at:
> >> >
> >> > https://github.com/apache/incubator-pulsar/milestone/8?closed=1
> >> >
> >> > *** Please download, test and vote by August 3th 2017, 15:00 PDT.
> >> >
> >> > Note that we are voting upon the source (tag), binaries are provided
> for
> >> > convenience.
> >> >
> >> > Source and binary files:
> >> > https://dist.apache.org/repos/dist/dev/incubator/pulsar/
> >> > pulsar-1.19.0-incubating-candidate-0/
> >> >
> >> > Maven staging repo:
> >> > https://repository.apache.org/content/repositories/
> orgapachepulsar-1000/
> >> >
> >> > The tag to be voted upon:
> >> > v1.19.0-incubating-candidate-0 (5125279b50f7a3da8c211b698580e1
> >> d2f4dd65e2)
> >> >
> >> > Pulsar's KEYS file containing PGP keys we use to sign the release:
> >> > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> >> >
> >> > Please download the the source package, and follow the README to build
> >> > and run the Pulsar standalone service.
> >> >
> >> >
> >> >
> >> > --
> >> > Matteo Merli
> >> > 
> >> >
> >>
>

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Sahaya Andrews]

+1

Environment: RHEL 6.4
- Verified checksum
- Ran local build against the src distribution
- Ran standalone server from the binary distribution
- Ran perf producer and consumer test against locally built binary and
binary distribution

I did not see any errors in producer/consumer/pulsar logs.

Thanks,
Andrews.


On Thu, Aug 3, 2017 at 5:53 AM, Masakazu Kitajo  wrote:
> +0
>
> Ran standalone server on macOS 10.12 / Java 8, with Java client.
>
> I saw lots of warnings and a few errors during building from the source
> package, I was able to run standalone server and successfully transferred a
> message with pulsar-client though. It seems they are not critical. I'll
> create issues for each warnings and errors later.
>
> Also, I followed Getting started on our documentation, however, the steps
> to build are only on README file. It's not user friendly. We should improve
> it before announcing the release.
>
> Committers, it would be great if you could write down about your
> environment (e.g. OS, Java version, compiler, etc) when you cast a vote.
> Since we support Linux and macOS (and a few languages for clients), we
> should confirm that the new version works on the environments we support.
>
> Thanks,
> Masakazu
>
>
>
> On Thu, Aug 3, 2017 at 4:47 AM, Matteo Merli  wrote:
>
>> Remainder for all committers:
>>
>> please check the release artifacts and vote on this thread, before tomorrow
>> 3pm PDT.
>>
>> Vote as in :
>>
>> [ ] +1 Release this package
>> [ ] 0 I don't feel strongly about it, but don't object
>> [ ] -1 Do not release this package because...
>>
>>
>> The documentation on the release process and what needs to be included can
>> be found at:
>>- https://incubator.apache.org/guides/releasemanagement.html
>>- http://www.apache.org/legal/release-policy.html
>>- http://www.apache.org/dev/release-distribution.html
>>- http://www.apache.org/dev/release-publishing.html
>>- http://www.apache.org/dev/publishing-maven-artifacts.html
>>
>> --
>> Matteo Merli
>> 
>>
>> On Mon, Jul 31, 2017 at 2:39 PM, Matteo Merli  wrote:
>>
>> > This is the first release candidate for Apache Pulsar, version
>> > 1.19.0-incubating.
>> >
>> > Major changes included in this release are:
>> >  * Added stateless Pulsar proxy
>> >  * Support for non-persistent topics
>> >  * Upgraded RocksDB to comply with ASF policy
>> >  * Instrumentation of ZooKeeper client to expose metrics
>> >  * Fixes for TLS auth in WebSocket proxy
>> >
>> >
>> > Complete list of changes can be found at:
>> >
>> > https://github.com/apache/incubator-pulsar/milestone/8?closed=1
>> >
>> > *** Please download, test and vote by August 3th 2017, 15:00 PDT.
>> >
>> > Note that we are voting upon the source (tag), binaries are provided for
>> > convenience.
>> >
>> > Source and binary files:
>> > https://dist.apache.org/repos/dist/dev/incubator/pulsar/
>> > pulsar-1.19.0-incubating-candidate-0/
>> >
>> > Maven staging repo:
>> > https://repository.apache.org/content/repositories/orgapachepulsar-1000/
>> >
>> > The tag to be voted upon:
>> > v1.19.0-incubating-candidate-0 (5125279b50f7a3da8c211b698580e1
>> d2f4dd65e2)
>> >
>> > Pulsar's KEYS file containing PGP keys we use to sign the release:
>> > https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
>> >
>> > Please download the the source package, and follow the README to build
>> > and run the Pulsar standalone service.
>> >
>> >
>> >
>> > --
>> > Matteo Merli
>> > 
>> >
>>

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Yuki Shiga]

+1

- Checked build success
- Ran the binaries

Yuki Shiga
2017/08/03 17:19 "Masahiro Sakamoto" <massa...@yahoo-corp.jp> wrote:

+1

- Checked the build success
- Run the binaries and it looked fine

Masahiro Sakamoto

> -Original Message-
> From: Jia Zhai [mailto:zhaiji...@gmail.com]
> Sent: Thursday, August 03, 2017 10:59 AM
> To: dev@pulsar.incubator.apache.org
> Subject: Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0
> 
> +1 (non-binding)
> - verified the packages (md5, sha1 and signature)
> - Checked the build success
> - Run the binaries by 'bin/pulsar standalone'
> 
> On Thu, Aug 3, 2017 at 8:57 AM, Nozomi Kurihara <nkuri...@yahoo-corp.jp>
> wrote:
> 
> > +1
> >
> > - Confirmed md5
> > - Checked the build success
> > - Ran the binaries
> >
> > Thanks!
> >
> > Nozomi
> >
> > 2017/08/03 9:32 に、"Sijie Guo" <guosi...@gmail.com> を書き込みました:
> >
> > +1 (non-binding)
> >
> > - verified the packages (md5, sha1 and signature)
> > - maven artifacts looks good to me.
> > - successfully build the source package
> > - run the binary package following the instructions in the website
> >
> > - Sijie
> >
> > On Wed, Aug 2, 2017 at 3:07 PM, Rajan Dhabalia 
<rdhaba...@apache.org>
> > wrote:
> >
> > > +1. I ran the regression-tests and few of the load-tests with this
> > version
> > > and looks fine.
> > >
> > > Thanks,
> > > Rajan
> > >
> > > On Wed, Aug 2, 2017 at 1:36 PM, Dave Fisher 
<dave2w...@comcast.net>
> > wrote:
> > >
> > > > Hi -
> > > >
> > > > I will cast an IPMC vote.
> > > >
> > > > +1 Release!
> > > >
> > > > I checked the source and binary package hashes.
> > > > I built the project with Maven from the source package.
> > > > I ran the rat check and checked the rat report.
> > > > Discussed the Category B issues which look good for now.
> > > >
> > > > Regards,
> > > > Dave
> > > >
> > > > > On Aug 2, 2017, at 12:47 PM, Matteo Merli <mme...@apache.org>
> > wrote:
> > > > >
> > > > > Remainder for all committers:
> > > > >
> > > > > please check the release artifacts and vote on this thread,
> > before
> > > > tomorrow
> > > > > 3pm PDT.
> > > > >
> > > > > Vote as in :
> > > > >
> > > > > [ ] +1 Release this package
> > > > > [ ] 0 I don't feel strongly about it, but don't object
> > > > > [ ] -1 Do not release this package because...
> > > > >
> > > > >
> > > > > The documentation on the release process and what needs to be
> > included
> > > > can
> > > > > be found at:
> > > > >   -
> https://incubator.apache.org/guides/releasemanagement.html
> > > > >   - http://www.apache.org/legal/release-policy.html
> > > > >   - http://www.apache.org/dev/release-distribution.html
> > > > >   - http://www.apache.org/dev/release-publishing.html
> > > > >   -
> http://www.apache.org/dev/publishing-maven-artifacts.html
> > > > >
> > > > > --
> > > > > Matteo Merli
> > > > > <mme...@apache.org>
> > > > >
> > > > > On Mon, Jul 31, 2017 at 2:39 PM, Matteo Merli 
<mme...@apache.org
> > >
> > > wrote:
> > > > >
> > > > >> This is the first release candidate for Apache Pulsar, 
version
> > > > >> 1.19.0-incubating.
> > > > >>
> > > > >> Major changes included in this release are:
> > > > >> * Added stateless Pulsar proxy
> > &

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Jia Zhai]

+1 (non-binding)
- verified the packages (md5, sha1 and signature)
- Checked the build success
- Run the binaries by 'bin/pulsar standalone'

On Thu, Aug 3, 2017 at 8:57 AM, Nozomi Kurihara 
wrote:

> +1
>
> - Confirmed md5
> - Checked the build success
> - Ran the binaries
>
> Thanks!
>
> Nozomi
>
> 2017/08/03 9:32 に、"Sijie Guo"  を書き込みました:
>
> +1 (non-binding)
>
> - verified the packages (md5, sha1 and signature)
> - maven artifacts looks good to me.
> - successfully build the source package
> - run the binary package following the instructions in the website
>
> - Sijie
>
> On Wed, Aug 2, 2017 at 3:07 PM, Rajan Dhabalia 
> wrote:
>
> > +1. I ran the regression-tests and few of the load-tests with this
> version
> > and looks fine.
> >
> > Thanks,
> > Rajan
> >
> > On Wed, Aug 2, 2017 at 1:36 PM, Dave Fisher 
> wrote:
> >
> > > Hi -
> > >
> > > I will cast an IPMC vote.
> > >
> > > +1 Release!
> > >
> > > I checked the source and binary package hashes.
> > > I built the project with Maven from the source package.
> > > I ran the rat check and checked the rat report.
> > > Discussed the Category B issues which look good for now.
> > >
> > > Regards,
> > > Dave
> > >
> > > > On Aug 2, 2017, at 12:47 PM, Matteo Merli 
> wrote:
> > > >
> > > > Remainder for all committers:
> > > >
> > > > please check the release artifacts and vote on this thread,
> before
> > > tomorrow
> > > > 3pm PDT.
> > > >
> > > > Vote as in :
> > > >
> > > > [ ] +1 Release this package
> > > > [ ] 0 I don't feel strongly about it, but don't object
> > > > [ ] -1 Do not release this package because...
> > > >
> > > >
> > > > The documentation on the release process and what needs to be
> included
> > > can
> > > > be found at:
> > > >   - https://incubator.apache.org/guides/releasemanagement.html
> > > >   - http://www.apache.org/legal/release-policy.html
> > > >   - http://www.apache.org/dev/release-distribution.html
> > > >   - http://www.apache.org/dev/release-publishing.html
> > > >   - http://www.apache.org/dev/publishing-maven-artifacts.html
> > > >
> > > > --
> > > > Matteo Merli
> > > > 
> > > >
> > > > On Mon, Jul 31, 2017 at 2:39 PM, Matteo Merli  >
> > wrote:
> > > >
> > > >> This is the first release candidate for Apache Pulsar, version
> > > >> 1.19.0-incubating.
> > > >>
> > > >> Major changes included in this release are:
> > > >> * Added stateless Pulsar proxy
> > > >> * Support for non-persistent topics
> > > >> * Upgraded RocksDB to comply with ASF policy
> > > >> * Instrumentation of ZooKeeper client to expose metrics
> > > >> * Fixes for TLS auth in WebSocket proxy
> > > >>
> > > >>
> > > >> Complete list of changes can be found at:
> > > >>
> > > >> https://github.com/apache/incubator-pulsar/milestone/8?closed=1
> > > >>
> > > >> *** Please download, test and vote by August 3th 2017, 15:00
> PDT.
> > > >>
> > > >> Note that we are voting upon the source (tag), binaries are
> provided
> > for
> > > >> convenience.
> > > >>
> > > >> Source and binary files:
> > > >> https://dist.apache.org/repos/dist/dev/incubator/pulsar/
> > > >> pulsar-1.19.0-incubating-candidate-0/
> > > >>
> > > >> Maven staging repo:
> > > >> https://repository.apache.org/content/repositories/
> > > orgapachepulsar-1000/
> > > >>
> > > >> The tag to be voted upon:
> > > >> v1.19.0-incubating-candidate-0 (5125279b50f7a3da8c211b698580e1
> > > d2f4dd65e2)
> > > >>
> > > >> Pulsar's KEYS file containing PGP keys we use to sign the
> release:
> > > >> https://dist.apache.org/repos/dist/release/incubator/pulsar/
> KEYS
> > > >>
> > > >> Please download the the source package, and follow the README
> to build
> > > >> and run the Pulsar standalone service.
> > > >>
> > > >>
> > > >>
> > > >> --
> > > >> Matteo Merli
> > > >> 
> > > >>
> > >
> > >
> >
>
>
>

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Nozomi Kurihara]

+1

- Confirmed md5
- Checked the build success
- Ran the binaries

Thanks!

Nozomi

2017/08/03 9:32 に、"Sijie Guo"  を書き込みました:

+1 (non-binding)

- verified the packages (md5, sha1 and signature)
- maven artifacts looks good to me.
- successfully build the source package
- run the binary package following the instructions in the website

- Sijie

On Wed, Aug 2, 2017 at 3:07 PM, Rajan Dhabalia  wrote:

> +1. I ran the regression-tests and few of the load-tests with this version
> and looks fine.
>
> Thanks,
> Rajan
>
> On Wed, Aug 2, 2017 at 1:36 PM, Dave Fisher  wrote:
>
> > Hi -
> >
> > I will cast an IPMC vote.
> >
> > +1 Release!
> >
> > I checked the source and binary package hashes.
> > I built the project with Maven from the source package.
> > I ran the rat check and checked the rat report.
> > Discussed the Category B issues which look good for now.
> >
> > Regards,
> > Dave
> >
> > > On Aug 2, 2017, at 12:47 PM, Matteo Merli  wrote:
> > >
> > > Remainder for all committers:
> > >
> > > please check the release artifacts and vote on this thread, before
> > tomorrow
> > > 3pm PDT.
> > >
> > > Vote as in :
> > >
> > > [ ] +1 Release this package
> > > [ ] 0 I don't feel strongly about it, but don't object
> > > [ ] -1 Do not release this package because...
> > >
> > >
> > > The documentation on the release process and what needs to be included
> > can
> > > be found at:
> > >   - https://incubator.apache.org/guides/releasemanagement.html
> > >   - http://www.apache.org/legal/release-policy.html
> > >   - http://www.apache.org/dev/release-distribution.html
> > >   - http://www.apache.org/dev/release-publishing.html
> > >   - http://www.apache.org/dev/publishing-maven-artifacts.html
> > >
> > > --
> > > Matteo Merli
> > > 
> > >
> > > On Mon, Jul 31, 2017 at 2:39 PM, Matteo Merli 
> wrote:
> > >
> > >> This is the first release candidate for Apache Pulsar, version
> > >> 1.19.0-incubating.
> > >>
> > >> Major changes included in this release are:
> > >> * Added stateless Pulsar proxy
> > >> * Support for non-persistent topics
> > >> * Upgraded RocksDB to comply with ASF policy
> > >> * Instrumentation of ZooKeeper client to expose metrics
> > >> * Fixes for TLS auth in WebSocket proxy
> > >>
> > >>
> > >> Complete list of changes can be found at:
> > >>
> > >> https://github.com/apache/incubator-pulsar/milestone/8?closed=1
> > >>
> > >> *** Please download, test and vote by August 3th 2017, 15:00 PDT.
> > >>
> > >> Note that we are voting upon the source (tag), binaries are provided
> for
> > >> convenience.
> > >>
> > >> Source and binary files:
> > >> https://dist.apache.org/repos/dist/dev/incubator/pulsar/
> > >> pulsar-1.19.0-incubating-candidate-0/
> > >>
> > >> Maven staging repo:
> > >> https://repository.apache.org/content/repositories/
> > orgapachepulsar-1000/
> > >>
> > >> The tag to be voted upon:
> > >> v1.19.0-incubating-candidate-0 (5125279b50f7a3da8c211b698580e1
> > d2f4dd65e2)
> > >>
> > >> Pulsar's KEYS file containing PGP keys we use to sign the release:
> > >> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> > >>
> > >> Please download the the source package, and follow the README to 
build
> > >> and run the Pulsar standalone service.
> > >>
> > >>
> > >>
> > >> --
> > >> Matteo Merli
> > >> 
> > >>
> >
> >
>

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Sijie Guo]

+1 (non-binding)

- verified the packages (md5, sha1 and signature)
- maven artifacts looks good to me.
- successfully build the source package
- run the binary package following the instructions in the website

- Sijie

On Wed, Aug 2, 2017 at 3:07 PM, Rajan Dhabalia  wrote:

> +1. I ran the regression-tests and few of the load-tests with this version
> and looks fine.
>
> Thanks,
> Rajan
>
> On Wed, Aug 2, 2017 at 1:36 PM, Dave Fisher  wrote:
>
> > Hi -
> >
> > I will cast an IPMC vote.
> >
> > +1 Release!
> >
> > I checked the source and binary package hashes.
> > I built the project with Maven from the source package.
> > I ran the rat check and checked the rat report.
> > Discussed the Category B issues which look good for now.
> >
> > Regards,
> > Dave
> >
> > > On Aug 2, 2017, at 12:47 PM, Matteo Merli  wrote:
> > >
> > > Remainder for all committers:
> > >
> > > please check the release artifacts and vote on this thread, before
> > tomorrow
> > > 3pm PDT.
> > >
> > > Vote as in :
> > >
> > > [ ] +1 Release this package
> > > [ ] 0 I don't feel strongly about it, but don't object
> > > [ ] -1 Do not release this package because...
> > >
> > >
> > > The documentation on the release process and what needs to be included
> > can
> > > be found at:
> > >   - https://incubator.apache.org/guides/releasemanagement.html
> > >   - http://www.apache.org/legal/release-policy.html
> > >   - http://www.apache.org/dev/release-distribution.html
> > >   - http://www.apache.org/dev/release-publishing.html
> > >   - http://www.apache.org/dev/publishing-maven-artifacts.html
> > >
> > > --
> > > Matteo Merli
> > > 
> > >
> > > On Mon, Jul 31, 2017 at 2:39 PM, Matteo Merli 
> wrote:
> > >
> > >> This is the first release candidate for Apache Pulsar, version
> > >> 1.19.0-incubating.
> > >>
> > >> Major changes included in this release are:
> > >> * Added stateless Pulsar proxy
> > >> * Support for non-persistent topics
> > >> * Upgraded RocksDB to comply with ASF policy
> > >> * Instrumentation of ZooKeeper client to expose metrics
> > >> * Fixes for TLS auth in WebSocket proxy
> > >>
> > >>
> > >> Complete list of changes can be found at:
> > >>
> > >> https://github.com/apache/incubator-pulsar/milestone/8?closed=1
> > >>
> > >> *** Please download, test and vote by August 3th 2017, 15:00 PDT.
> > >>
> > >> Note that we are voting upon the source (tag), binaries are provided
> for
> > >> convenience.
> > >>
> > >> Source and binary files:
> > >> https://dist.apache.org/repos/dist/dev/incubator/pulsar/
> > >> pulsar-1.19.0-incubating-candidate-0/
> > >>
> > >> Maven staging repo:
> > >> https://repository.apache.org/content/repositories/
> > orgapachepulsar-1000/
> > >>
> > >> The tag to be voted upon:
> > >> v1.19.0-incubating-candidate-0 (5125279b50f7a3da8c211b698580e1
> > d2f4dd65e2)
> > >>
> > >> Pulsar's KEYS file containing PGP keys we use to sign the release:
> > >> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> > >>
> > >> Please download the the source package, and follow the README to build
> > >> and run the Pulsar standalone service.
> > >>
> > >>
> > >>
> > >> --
> > >> Matteo Merli
> > >> 
> > >>
> >
> >
>

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Rajan Dhabalia]

+1. I ran the regression-tests and few of the load-tests with this version
and looks fine.

Thanks,
Rajan

On Wed, Aug 2, 2017 at 1:36 PM, Dave Fisher  wrote:

> Hi -
>
> I will cast an IPMC vote.
>
> +1 Release!
>
> I checked the source and binary package hashes.
> I built the project with Maven from the source package.
> I ran the rat check and checked the rat report.
> Discussed the Category B issues which look good for now.
>
> Regards,
> Dave
>
> > On Aug 2, 2017, at 12:47 PM, Matteo Merli  wrote:
> >
> > Remainder for all committers:
> >
> > please check the release artifacts and vote on this thread, before
> tomorrow
> > 3pm PDT.
> >
> > Vote as in :
> >
> > [ ] +1 Release this package
> > [ ] 0 I don't feel strongly about it, but don't object
> > [ ] -1 Do not release this package because...
> >
> >
> > The documentation on the release process and what needs to be included
> can
> > be found at:
> >   - https://incubator.apache.org/guides/releasemanagement.html
> >   - http://www.apache.org/legal/release-policy.html
> >   - http://www.apache.org/dev/release-distribution.html
> >   - http://www.apache.org/dev/release-publishing.html
> >   - http://www.apache.org/dev/publishing-maven-artifacts.html
> >
> > --
> > Matteo Merli
> > 
> >
> > On Mon, Jul 31, 2017 at 2:39 PM, Matteo Merli  wrote:
> >
> >> This is the first release candidate for Apache Pulsar, version
> >> 1.19.0-incubating.
> >>
> >> Major changes included in this release are:
> >> * Added stateless Pulsar proxy
> >> * Support for non-persistent topics
> >> * Upgraded RocksDB to comply with ASF policy
> >> * Instrumentation of ZooKeeper client to expose metrics
> >> * Fixes for TLS auth in WebSocket proxy
> >>
> >>
> >> Complete list of changes can be found at:
> >>
> >> https://github.com/apache/incubator-pulsar/milestone/8?closed=1
> >>
> >> *** Please download, test and vote by August 3th 2017, 15:00 PDT.
> >>
> >> Note that we are voting upon the source (tag), binaries are provided for
> >> convenience.
> >>
> >> Source and binary files:
> >> https://dist.apache.org/repos/dist/dev/incubator/pulsar/
> >> pulsar-1.19.0-incubating-candidate-0/
> >>
> >> Maven staging repo:
> >> https://repository.apache.org/content/repositories/
> orgapachepulsar-1000/
> >>
> >> The tag to be voted upon:
> >> v1.19.0-incubating-candidate-0 (5125279b50f7a3da8c211b698580e1
> d2f4dd65e2)
> >>
> >> Pulsar's KEYS file containing PGP keys we use to sign the release:
> >> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> >>
> >> Please download the the source package, and follow the README to build
> >> and run the Pulsar standalone service.
> >>
> >>
> >>
> >> --
> >> Matteo Merli
> >> 
> >>
>
>

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Dave Fisher]

Hi -

I will cast an IPMC vote.

+1 Release!

I checked the source and binary package hashes.
I built the project with Maven from the source package.
I ran the rat check and checked the rat report.
Discussed the Category B issues which look good for now.

Regards,
Dave

> On Aug 2, 2017, at 12:47 PM, Matteo Merli  wrote:
> 
> Remainder for all committers:
> 
> please check the release artifacts and vote on this thread, before tomorrow
> 3pm PDT.
> 
> Vote as in :
> 
> [ ] +1 Release this package
> [ ] 0 I don't feel strongly about it, but don't object
> [ ] -1 Do not release this package because...
> 
> 
> The documentation on the release process and what needs to be included can
> be found at:
>   - https://incubator.apache.org/guides/releasemanagement.html
>   - http://www.apache.org/legal/release-policy.html
>   - http://www.apache.org/dev/release-distribution.html
>   - http://www.apache.org/dev/release-publishing.html
>   - http://www.apache.org/dev/publishing-maven-artifacts.html
> 
> --
> Matteo Merli
> 
> 
> On Mon, Jul 31, 2017 at 2:39 PM, Matteo Merli  wrote:
> 
>> This is the first release candidate for Apache Pulsar, version
>> 1.19.0-incubating.
>> 
>> Major changes included in this release are:
>> * Added stateless Pulsar proxy
>> * Support for non-persistent topics
>> * Upgraded RocksDB to comply with ASF policy
>> * Instrumentation of ZooKeeper client to expose metrics
>> * Fixes for TLS auth in WebSocket proxy
>> 
>> 
>> Complete list of changes can be found at:
>> 
>> https://github.com/apache/incubator-pulsar/milestone/8?closed=1
>> 
>> *** Please download, test and vote by August 3th 2017, 15:00 PDT.
>> 
>> Note that we are voting upon the source (tag), binaries are provided for
>> convenience.
>> 
>> Source and binary files:
>> https://dist.apache.org/repos/dist/dev/incubator/pulsar/
>> pulsar-1.19.0-incubating-candidate-0/
>> 
>> Maven staging repo:
>> https://repository.apache.org/content/repositories/orgapachepulsar-1000/
>> 
>> The tag to be voted upon:
>> v1.19.0-incubating-candidate-0 (5125279b50f7a3da8c211b698580e1d2f4dd65e2)
>> 
>> Pulsar's KEYS file containing PGP keys we use to sign the release:
>> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
>> 
>> Please download the the source package, and follow the README to build
>> and run the Pulsar standalone service.
>> 
>> 
>> 
>> --
>> Matteo Merli
>> 
>> 



signature.asc
Description: Message signed with OpenPGP

Re: [VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Matteo Merli]

Remainder for all committers:

please check the release artifacts and vote on this thread, before tomorrow
3pm PDT.

Vote as in :

[ ] +1 Release this package
[ ] 0 I don't feel strongly about it, but don't object
[ ] -1 Do not release this package because...


The documentation on the release process and what needs to be included can
be found at:
   - https://incubator.apache.org/guides/releasemanagement.html
   - http://www.apache.org/legal/release-policy.html
   - http://www.apache.org/dev/release-distribution.html
   - http://www.apache.org/dev/release-publishing.html
   - http://www.apache.org/dev/publishing-maven-artifacts.html

--
Matteo Merli


On Mon, Jul 31, 2017 at 2:39 PM, Matteo Merli  wrote:

> This is the first release candidate for Apache Pulsar, version
> 1.19.0-incubating.
>
> Major changes included in this release are:
>  * Added stateless Pulsar proxy
>  * Support for non-persistent topics
>  * Upgraded RocksDB to comply with ASF policy
>  * Instrumentation of ZooKeeper client to expose metrics
>  * Fixes for TLS auth in WebSocket proxy
>
>
> Complete list of changes can be found at:
>
> https://github.com/apache/incubator-pulsar/milestone/8?closed=1
>
> *** Please download, test and vote by August 3th 2017, 15:00 PDT.
>
> Note that we are voting upon the source (tag), binaries are provided for
> convenience.
>
> Source and binary files:
> https://dist.apache.org/repos/dist/dev/incubator/pulsar/
> pulsar-1.19.0-incubating-candidate-0/
>
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachepulsar-1000/
>
> The tag to be voted upon:
> v1.19.0-incubating-candidate-0 (5125279b50f7a3da8c211b698580e1d2f4dd65e2)
>
> Pulsar's KEYS file containing PGP keys we use to sign the release:
> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
>
> Please download the the source package, and follow the README to build
> and run the Pulsar standalone service.
>
>
>
> --
> Matteo Merli
> 
>

Re: [DISCUSS][VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Dave Fisher]

> On Aug 2, 2017, at 10:03 AM, Matteo Merli  wrote:
> 
> On Wed, Aug 2, 2017 at 8:30 AM, Dave Fisher  wrote:
> 
>>> We use AspectJ to instrument ZooKeeper server and client, in order to
>>> collect and expose metrics that are not available in ZooKeeper itself.
>>> At this point is not optional and it's not possible to turn it off.
>> 
>> If someone took the Source release and built the product then AspectJ
>> would be included. This means that they would need to take an EPL 1.0
>> license. It is my understanding that this must be avoided.
>> 
>> I think that we can probably include this in the first Incubating release.
>> These issues are why we incubate.
> 
> 
> I've been checking about Cat-B dependencies. So, we also have Jersey jars
> which is under CDDL (again Cat-B). All the Servlet and Rest services API
> from Java are all licensed with CDDL.
> 
> Just doing a quick check, I'm seeing many Apache TLPs are bundling these
> dependencies (EPL and CDDL) in the binary releases (and depending on them
> in src releases). For example:
> 
> Spark : https://github.com/apache/spark/blob/master/NOTICE
> Kafka: https://github.com/apache/kafka/blob/trunk/NOTICE
> Hadoop: https://github.com/apache/hadoop/blob/trunk/NOTICE.txt
> Samza: https://github.com/apache/samza/blob/master/LICENSE

Wow. It is not clear how much each is dependent, but they are there.

I say let’s VOTE and push this release. We can debate on general@incubator and 
then legal-discuss@

Regards,
Dave

> 
> 
> 
>> I would ask if there is another AOP that could be used to expose ZK
>> metrics? For example, I wonder what Apache Solr or BookKeeper do.
>> 
> 
> BookKeeper doesn't "bundle" ZooKeeper as well, it just instruct you to have
> ZK cluster running. So BK doesn't have this problem because it doesn't deal
> it.
> 
> In Pulsar, to facilitate the deployment we provide scripts to also start
> BookKeeper and ZooKeeper.
> And when we run ZooKeeper we instrument with AOP and expose metrics in the
> same way as Pulsar broker and BookKeeper.



signature.asc
Description: Message signed with OpenPGP

Re: [DISCUSS][VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Matteo Merli]

On Wed, Aug 2, 2017 at 8:30 AM, Dave Fisher  wrote:

> > We use AspectJ to instrument ZooKeeper server and client, in order to
> > collect and expose metrics that are not available in ZooKeeper itself.
> > At this point is not optional and it's not possible to turn it off.
>
> If someone took the Source release and built the product then AspectJ
> would be included. This means that they would need to take an EPL 1.0
> license. It is my understanding that this must be avoided.
>
> I think that we can probably include this in the first Incubating release.
> These issues are why we incubate.


I've been checking about Cat-B dependencies. So, we also have Jersey jars
which is under CDDL (again Cat-B). All the Servlet and Rest services API
from Java are all licensed with CDDL.

Just doing a quick check, I'm seeing many Apache TLPs are bundling these
dependencies (EPL and CDDL) in the binary releases (and depending on them
in src releases). For example:

Spark : https://github.com/apache/spark/blob/master/NOTICE
Kafka: https://github.com/apache/kafka/blob/trunk/NOTICE
Hadoop: https://github.com/apache/hadoop/blob/trunk/NOTICE.txt
Samza: https://github.com/apache/samza/blob/master/LICENSE



> I would ask if there is another AOP that could be used to expose ZK
> metrics? For example, I wonder what Apache Solr or BookKeeper do.
>

BookKeeper doesn't "bundle" ZooKeeper as well, it just instruct you to have
ZK cluster running. So BK doesn't have this problem because it doesn't deal
it.

In Pulsar, to facilitate the deployment we provide scripts to also start
BookKeeper and ZooKeeper.
And when we run ZooKeeper we instrument with AOP and expose metrics in the
same way as Pulsar broker and BookKeeper.

Re: [DISCUSS][VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Dave Fisher]

Hi Matteo:

> On Jul 31, 2017, at 5:10 PM, Matteo Merli  wrote:
> 
> On Mon, Jul 31, 2017 at 4:53 PM, Dave Fisher  wrote:
> 
>> Hi Pulsar Team,
>> 
>> I’ve been doing my checks so far so good. I do have two concerns:
>> 
>> The license for Aspect J is the EPL 1.0 which is Category B -
>> https://www.apache.org/legal/resolved.html#category-b
>> 
>> Is this optional?
>> 
> 
> We use AspectJ to instrument ZooKeeper server and client, in order to
> collect and expose metrics that are not available in ZooKeeper itself.
> At this point is not optional and it's not possible to turn it off.

If someone took the Source release and built the product then AspectJ would be 
included. This means that they would need to take an EPL 1.0 license. It is my 
understanding that this must be avoided.

I think that we can probably include this in the first Incubating release. 
These issues are why we incubate.

I would ask if there is another AOP that could be used to expose ZK metrics? 
For example, I wonder what Apache Solr or BookKeeper do.

> 
> I've been reading the Cat-B section and, in my understanding it should be
> fine to include it in form of binary dependencies.
> Quoting from that page:
> 
>>> Software under the following licenses may be included in binary form
> within an Apache product if the inclusion is appropriately labeled (see
> below)
> 
> and
> 
>>> By including only the object/binary form, there is less exposed surface
> area of the third-party work from which a work might be derived; this
> addresses the second guiding principle of this policy.
> 
> 
> Also - is everything in the binary’s notice file necessary?
>> 
>> I have a feeling that a DEPENDENCIES file might make sense.
> 
> 
> I have created 2 different NOTICE files, one for src and one for the bin
> dist package.
> I have been following the guide at http://apache.org/legal/
> src-headers.html#notice plus I've peaked at what other TLPs are currently
> including in NOTICE files.

It looks good, let’s see what happens when the VOTE goes to general@incubator, 
or if any of the other mentors weighs in on this.

> 
> The bulk of the file comes from :
> 
>>> The remainder of the NOTICE file is to be used for required third-party
> notices.
>>> The NOTICE file may also include copyright notices moved from source
> files submitted to the ASF.
> 
> Basically, I've interpreted this as to include the NOTICEs from all the
> dependencies. In most cases it was just the copyright line. In other cases,
> like Netty, the NOTICE file was much bigger.
> 
> I'd be glad to slim it down :)

Yup.

Regards,
Dave

> 
> 
> 
> 
> --
> Matteo Merli
> 



signature.asc
Description: Message signed with OpenPGP

[DISCUSS][VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Dave Fisher]

Hi Pulsar Team,

I’ve been doing my checks so far so good. I do have two concerns:

The license for Aspect J is the EPL 1.0 which is Category B - 
https://www.apache.org/legal/resolved.html#category-b

Is this optional?

Also - is everything in the binary’s notice file necessary?

I have a feeling that a DEPENDENCIES file might make sense.

What do the other Mentors think?

Regards,
Dave

> On Jul 31, 2017, at 2:39 PM, Matteo Merli  wrote:
> 
> This is the first release candidate for Apache Pulsar, version
> 1.19.0-incubating.
> 
> Major changes included in this release are:
> * Added stateless Pulsar proxy
> * Support for non-persistent topics
> * Upgraded RocksDB to comply with ASF policy
> * Instrumentation of ZooKeeper client to expose metrics
> * Fixes for TLS auth in WebSocket proxy
> 
> 
> Complete list of changes can be found at:
> 
> https://github.com/apache/incubator-pulsar/milestone/8?closed=1
> 
> *** Please download, test and vote by August 3th 2017, 15:00 PDT.
> 
> Note that we are voting upon the source (tag), binaries are provided for
> convenience.
> 
> Source and binary files:
> https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-1.19.0-incubating-candidate-0/
> 
> Maven staging repo:
> https://repository.apache.org/content/repositories/orgapachepulsar-1000/
> 
> The tag to be voted upon:
> v1.19.0-incubating-candidate-0 (5125279b50f7a3da8c211b698580e1d2f4dd65e2)
> 
> Pulsar's KEYS file containing PGP keys we use to sign the release:
> https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS
> 
> Please download the the source package, and follow the README to build
> and run the Pulsar standalone service.
> 
> 
> 
> --
> Matteo Merli
> 



signature.asc
Description: Message signed with OpenPGP

[VOTE] Pulsar 1.19.0-incubating Release Candidate 0

[Matteo Merli]

This is the first release candidate for Apache Pulsar, version
1.19.0-incubating.

Major changes included in this release are:
 * Added stateless Pulsar proxy
 * Support for non-persistent topics
 * Upgraded RocksDB to comply with ASF policy
 * Instrumentation of ZooKeeper client to expose metrics
 * Fixes for TLS auth in WebSocket proxy


Complete list of changes can be found at:

https://github.com/apache/incubator-pulsar/milestone/8?closed=1

*** Please download, test and vote by August 3th 2017, 15:00 PDT.

Note that we are voting upon the source (tag), binaries are provided for
convenience.

Source and binary files:
https://dist.apache.org/repos/dist/dev/incubator/pulsar/pulsar-1.19.0-incubating-candidate-0/

Maven staging repo:
https://repository.apache.org/content/repositories/orgapachepulsar-1000/

The tag to be voted upon:
v1.19.0-incubating-candidate-0 (5125279b50f7a3da8c211b698580e1d2f4dd65e2)

Pulsar's KEYS file containing PGP keys we use to sign the release:
https://dist.apache.org/repos/dist/release/incubator/pulsar/KEYS

Please download the the source package, and follow the README to build
and run the Pulsar standalone service.



--
Matteo Merli