[jira] [Created] (QPID-4195) Add AMQP 1.0 JMS client to release script

2012-08-07 Thread Rob Godfrey (JIRA)
Rob Godfrey created QPID-4195: - Summary: Add AMQP 1.0 JMS client to release script Key: QPID-4195 URL: https://issues.apache.org/jira/browse/QPID-4195 Project: Qpid Issue Type: Improvement

[jira] [Resolved] (QPID-4195) Add AMQP 1.0 JMS client to release script

2012-08-07 Thread Rob Godfrey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rob Godfrey resolved QPID-4195. --- Resolution: Fixed Add AMQP 1.0 JMS client to release script

Re: Yet more requests for inclusion in 0.18

2012-08-07 Thread Rob Godfrey
Can I request QPID-4195 - a change to the release.sh script to include the AMQP 1.0 JMS client? I know you (Robbie) have reviewed this already. Should be very low risk, and it will allow the people who are looking for a JMS client for AMQP 1.0 to get one :-) -- Rob On 3 August 2012 12:26,

[jira] [Commented] (QPID-4191) HA removing self address breaks if a VIP is used.

2012-08-07 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13430287#comment-13430287 ] Gordon Sim commented on QPID-4191: -- I have reviewed the change and would support its

[jira] [Commented] (QPID-4195) Add AMQP 1.0 JMS client to release script

2012-08-07 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13430342#comment-13430342 ] Robbie Gemmell commented on QPID-4195: -- Reviewed (by me), approved for 0.18.

[jira] [Commented] (QPID-4191) HA removing self address breaks if a VIP is used.

2012-08-07 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13430343#comment-13430343 ] Robbie Gemmell commented on QPID-4191: -- Reviewed by Gordon, approved for 0.18.

Re: Yet more requests for inclusion in 0.18

2012-08-07 Thread Robbie Gemmell
Approved for inclusion. Robbie On 7 August 2012 09:50, Rob Godfrey rob.j.godf...@gmail.com wrote: Can I request QPID-4195 - a change to the release.sh script to include the AMQP 1.0 JMS client? I know you (Robbie) have reviewed this already. Should be very low risk, and it will allow the

[jira] [Commented] (QPID-4177) Writing wrong filter in a QMF method causes the filter is ignored

2012-08-07 Thread Pavel Moravec (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4177?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13430348#comment-13430348 ] Pavel Moravec commented on QPID-4177: - Preliminary patch that does not resolve adjacent

Re: Review Request: patches for mingw

2012-08-07 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6302/#review9957 ---

Re: Review Request: patches for mingw

2012-08-07 Thread Rafael Schloming
On Aug. 7, 2012, 1:37 p.m., Kenneth Giusti wrote: http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/driver.h, line 192 https://reviews.apache.org/r/6302/diff/1-2/?file=132726#file132726line192 Minor artistic flourish - how about we change this api to

Request inclusion for 0.18

2012-08-07 Thread Alan Conway
I'd like to include in 0.18: https://issues.apache.org/jira/browse/QPID-4191 : HA removing self address breaks if a VIP is used. Its a very serious bug (prevents users from using VIPs which is what we recommend they do) and the fix is fairly simple. Cheers, Alan.

Re: Request inclusion for 0.18

2012-08-07 Thread Robbie Gemmell
Approved for inclusion (before you sent the email :P) Robbie On 7 August 2012 14:54, Alan Conway acon...@redhat.com wrote: I'd like to include in 0.18: https://issues.apache.org/jira/browse/QPID-4191 : HA removing self address breaks if a VIP is used. Its a very serious bug (prevents

0.18 request -- QPID-4194

2012-08-07 Thread mick
0.18 request QPID-4194 Very low risk 2-line change to Cluster.cpp, to enable queue events in CATCHUP mode. Otherwise a clustered broker, if it is a newbie that is in CATCHUP mode, and if it gets a message, and if there is a replication queue from this broker to somewhere else -- the newbie

Re: 0.18 request -- QPID-4194

2012-08-07 Thread Robbie Gemmell
If someone familiar with the cluster code can review it first then I will consider it for inclusion. Robbie. On 7 Aug 2012 15:22, mick mgoul...@redhat.com wrote: 0.18 request QPID-4194 Very low risk 2-line change to Cluster.cpp, to enable queue events in CATCHUP mode. Otherwise a

Re: Review Request: patches for mingw

2012-08-07 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6302/#review9964 --- I think this is pretty much what I was thinking. I don't really like

Re: 0.18 request -- QPID-4194

2012-08-07 Thread Alan Conway
On Tue, 2012-08-07 at 15:36 +0100, Robbie Gemmell wrote: If someone familiar with the cluster code can review it first then I will consider it for inclusion. I reviewed and agree it is suitable for inclusion in 0.18. I'll put a comment on the JIRA as soon as JIRA is up and running againn.

[jira] [Created] (QPID-4196) Provides %contract assurances in the swig layer for language bindings.

2012-08-07 Thread Darryl L. Pierce (JIRA)
Darryl L. Pierce created QPID-4196: -- Summary: Provides %contract assurances in the swig layer for language bindings. Key: QPID-4196 URL: https://issues.apache.org/jira/browse/QPID-4196 Project: Qpid

[jira] [Updated] (QPID-4196) Provides %contract assurances in the swig layer for language bindings.

2012-08-07 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce updated QPID-4196: --- Attachment: 0001-Provides-contract-guarantees-to-language-bindings.patch Provides

Re: Review Request: Race condition in LinkRegistry.cpp

2012-08-07 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6396/#review9965 --- Where is the assignment is done outside of the lock in the old code?

Re: 0.18 request -- QPID-4194

2012-08-07 Thread Robbie Gemmell
Thanks Alan. Consider it approved Mick. Robbie On 7 August 2012 17:29, Alan Conway acon...@redhat.com wrote: On Tue, 2012-08-07 at 15:36 +0100, Robbie Gemmell wrote: If someone familiar with the cluster code can review it first then I will consider it for inclusion. I reviewed and agree

Re: Review Request: patches for mingw

2012-08-07 Thread Rafael Schloming
On Aug. 7, 2012, 1:37 p.m., Kenneth Giusti wrote: http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/driver.h, line 192 https://reviews.apache.org/r/6302/diff/1-2/?file=132726#file132726line192 Minor artistic flourish - how about we change this api to

Re: Review Request: patches for mingw

2012-08-07 Thread Rafael Schloming
On Aug. 7, 2012, 3:58 p.m., Andrew Stitcher wrote: I think this is pretty much what I was thinking. I don't really like the actual client file doing the #include winsock2 but in the circumstances it's better than the previous alternative. Another possibility is to move the

Re: Review Request: patches for mingw

2012-08-07 Thread Cliff Jansen
On Aug. 7, 2012, 1:37 p.m., Kenneth Giusti wrote: http://svn.apache.org/repos/asf/qpid/proton/trunk/proton-c/include/proton/driver.h, line 192 https://reviews.apache.org/r/6302/diff/1-2/?file=132726#file132726line192 Minor artistic flourish - how about we change this api to

Re: Review Request: patches for mingw

2012-08-07 Thread Cliff Jansen
On Aug. 7, 2012, 3:58 p.m., Andrew Stitcher wrote: I think this is pretty much what I was thinking. I don't really like the actual client file doing the #include winsock2 but in the circumstances it's better than the previous alternative. Another possibility is to move the

[jira] [Resolved] (QPID-4191) HA removing self address breaks if a VIP is used.

2012-08-07 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved QPID-4191. --- Resolution: Fixed Committed to 0.18 r1370308 HA removing self address breaks if a

[jira] [Commented] (QPID-4194) cluster should enable queue events in CATCHUP state

2012-08-07 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13430452#comment-13430452 ] Alan Conway commented on QPID-4194: --- Change looks correct very low risk, it is suitable

[jira] [Updated] (QPID-4192) Provide a Perl language binding on top of the Swig bindings

2012-08-07 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce updated QPID-4192: --- Attachment: (was: 0001-New-Perl-language-bindings-for-Qpid.patch) Provide a Perl

[jira] [Updated] (QPID-4192) Provide a Perl language binding on top of the Swig bindings

2012-08-07 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce updated QPID-4192: --- Attachment: (was: 0002-Updated-all-Perl-examples-to-work-with-the-new-Perl-.patch)

[jira] [Updated] (QPID-4192) Provide a Perl language binding on top of the Swig bindings

2012-08-07 Thread Darryl L. Pierce (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Darryl L. Pierce updated QPID-4192: --- Attachment: 0002-Updated-all-Perl-examples-to-work-with-the-new-Perl-.patch

Re: Review Request: Race condition in LinkRegistry.cpp

2012-08-07 Thread Kenneth Giusti
On Aug. 7, 2012, 4:51 p.m., Alan Conway wrote: Where is the assignment is done outside of the lock in the old code? The assignment in notifyConnection seems to have the same locking in both old and new code. You're correct, the call to link::established() still happens outside the lock

Re: Review Request: Race condition in LinkRegistry.cpp

2012-08-07 Thread Alan Conway
On Aug. 7, 2012, 4:51 p.m., Alan Conway wrote: Where is the assignment is done outside of the lock in the old code? The assignment in notifyConnection seems to have the same locking in both old and new code. Kenneth Giusti wrote: You're correct, the call to link::established()

Re: Review Request: Race condition in LinkRegistry.cpp

2012-08-07 Thread Kenneth Giusti
On Aug. 7, 2012, 4:51 p.m., Alan Conway wrote: Where is the assignment is done outside of the lock in the old code? The assignment in notifyConnection seems to have the same locking in both old and new code. Kenneth Giusti wrote: You're correct, the call to link::established()

Re: Review Request: Race condition in LinkRegistry.cpp

2012-08-07 Thread Alan Conway
On Aug. 7, 2012, 4:51 p.m., Alan Conway wrote: Where is the assignment is done outside of the lock in the old code? The assignment in notifyConnection seems to have the same locking in both old and new code. Kenneth Giusti wrote: You're correct, the call to link::established()

Re: Review Request: Race condition in LinkRegistry.cpp

2012-08-07 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6396/#review9991 --- Ship it! Ship It! - Alan Conway On Aug. 6, 2012, 5:51 p.m.,