Re: Review Request: Patch to allow proton to compile in C++

2013-01-24 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8223/ --- (Updated Jan. 24, 2013, 8:14 a.m.) Review request for qpid, Andrew Stitcher,

Review Request: part 2 of gcc flags for C++ compatibility

2013-01-24 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9085/ --- Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and

Review Request: part 3 of gcc flags for C++ compatibility

2013-01-24 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9086/ --- Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and

Review Request: part 4 of gcc flags for C++ compatibility

2013-01-24 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9088/ --- Review request for qpid, Andrew Stitcher, Kenneth Giusti, Rafael Schloming, and

Re: Review Request: part 4 of gcc flags for C++ compatibility

2013-01-24 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9088/ --- (Updated Jan. 24, 2013, 8:49 a.m.) Review request for qpid, Andrew Stitcher,

Re: Review Request: part 4 of gcc flags for C++ compatibility

2013-01-24 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9088/ --- (Updated Jan. 24, 2013, 8:49 a.m.) Review request for qpid, Andrew Stitcher,

Re: Review Request: Add the ability to turn message replay on/off.

2013-01-24 Thread Keith Wall
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9027/#review15629 ---

Re: Review Request: Add the ability to turn message replay on/off.

2013-01-24 Thread rajith attapattu
On Jan. 24, 2013, 9:38 a.m., Keith Wall wrote: http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/XASessionImpl.java, line 91 https://reviews.apache.org/r/9027/diff/2/?file=250239#file250239line91 Rather than extending the argument

[jira] [Assigned] (QPID-4281) Java tests logging broken because log4j.configuration is not a valid URL

2013-01-24 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy reassigned QPID-4281: Assignee: Alex Rudyy (was: Robbie Gemmell) I am going to review and commit the patch attached.

Jira subversion or git integration

2013-01-24 Thread Andrew Stitcher
Last July (2012) The Jira subversion integration was disabled. Speaking personally (and I expect for a good number of members of the qpid team) I'm finding it much harder to follow jiras into the changes that relate to them. Indeed, previously Qpid put in place a policy that led to most Qpid

Re: Review Request: Patch to allow proton to compile in C++

2013-01-24 Thread Mary Hinton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8223/#review15661 --- Ship it! Ship It! - Mary Hinton On Jan. 24, 2013, 8:14 a.m.,

Re: Review Request: part 2 of gcc flags for C++ compatibility

2013-01-24 Thread Mary Hinton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9085/#review15666 --- Ship it! Ship It! - Mary Hinton On Jan. 24, 2013, 8:24 a.m.,

Re: Review Request: part 3 of gcc flags for C++ compatibility

2013-01-24 Thread Mary Hinton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9086/#review15668 --- Ship it! Ship It! - Mary Hinton On Jan. 24, 2013, 8:30 a.m.,

Re: Review Request: part 4 of gcc flags for C++ compatibility

2013-01-24 Thread Mary Hinton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9088/#review15669 --- Patch 1 makes the needed change to PN_ENSURE PN_ENSUREZ in util.h.

Re: Review Request: part 4 of gcc flags for C++ compatibility

2013-01-24 Thread Cliff Jansen
On Jan. 25, 2013, 1:23 a.m., Mary Hinton wrote: Patch 1 makes the needed change to PN_ENSURE PN_ENSUREZ in util.h. Also makes the changes for these macros in messenger.c and engine.c. Patch 4 adds new PN_ENSURE macros in proton.c and codec.c, but is using the old PN_ENSURE macro.