Re: 0.22 Inclusion Request - QPID-4698

2013-04-09 Thread Alan Conway
On 04/08/2013 10:05 AM, Darryl L. Pierce wrote: Fixes needed for the CMake build system when installing files. Corrects the installation for several pieces, including Python site packages, a couple of configuration files and a SysVInit script. http://issues.apache.org/jira/browse/QPID-4698

[jira] [Commented] (QPID-4728) Allow option to configure credit on Federation sessions.

2013-04-09 Thread Ken Giusti (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13626673#comment-13626673 ] Ken Giusti commented on QPID-4728: -- Proposed fix available at Reviewboard:

[jira] [Assigned] (QPID-4731) Java Broker: topic subscription with selector bug can silently prevent temporary queue deletion

2013-04-09 Thread Philip Harvey (JIRA)
[ https://issues.apache.org/jira/browse/QPID-4731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Harvey reassigned QPID-4731: --- Assignee: Philip Harvey Java Broker: topic subscription with selector bug can silently

Re: Review Request: Get cmake package working.

2013-04-09 Thread Alan Conway
On April 9, 2013, 3:25 p.m., Steve Huston wrote: While I agree with Andrew that getting a good RPM/DEB/MSI installer from the cmake is probably not a worthy goal, it is important to get the install part working simply because it can be used to support the installers. For example, the

Re: Review Request: Get cmake package working.

2013-04-09 Thread Alan Conway
On April 9, 2013, 3:25 p.m., Steve Huston wrote: While I agree with Andrew that getting a good RPM/DEB/MSI installer from the cmake is probably not a worthy goal, it is important to get the install part working simply because it can be used to support the installers. For example, the

Re: 0.22 Inclusion Request - QPID-4698

2013-04-09 Thread Darryl L. Pierce
On Tue, Apr 09, 2013 at 10:11:53AM -0400, Alan Conway wrote: On 04/08/2013 10:05 AM, Darryl L. Pierce wrote: Fixes needed for the CMake build system when installing files. Corrects the installation for several pieces, including Python site packages, a couple of configuration files and a

Re: Review Request: Get cmake package working.

2013-04-09 Thread Darryl L. Pierce
On Tue, Apr 09, 2013 at 03:30:30PM -, Alan Conway wrote: It only works if you are installing directly to the install-prefix. In order to build packages you need to be able to install to a temporary location to create the tree, and then package it up. That's what is broken by absolute

Re: Review Request: Get cmake package working.

2013-04-09 Thread Darryl L. Pierce
On Tue, Apr 09, 2013 at 03:32:08PM -, Andrew Stitcher wrote: You are supposed to use DESTDIR for that - is that broken? AFAICT it works fine. -- Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc. Delivering value year after year. Red Hat ranks #1 in value among software vendors.

Re: Review Request: QPID-4728: add 'credit' parameter to Federation Bridge configuration

2013-04-09 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10373/#review18870 --- Ship it! Ship It! - Alan Conway On April 9, 2013, 4:02 p.m.,