Re: Review Request 15083: Add ability create, delete and list objects of arbitrary types

2013-10-31 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15083/ --- (Updated Oct. 31, 2013, 8:20 a.m.) Review request for qpid, Justin Ross,

Re: Review Request 14882: on-demand node creation policies

2013-10-31 Thread Gordon Sim
On Oct. 30, 2013, 2:03 p.m., Kenneth Giusti wrote: /trunk/qpid/cpp/src/qpid/broker/amqp/NodePolicy.cpp, line 114 https://reviews.apache.org/r/14882/diff/1-2/?file=369941#file369941line114 My brain just stack dumped - durable is set to true if AUTO_DELETE is explicitly specified

[jira] [Created] (QPID-5279) [AMQP 1.0] 1.0 receiver can consume from someone else's exclusive queue

2013-10-31 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-5279: Summary: [AMQP 1.0] 1.0 receiver can consume from someone else's exclusive queue Key: QPID-5279 URL: https://issues.apache.org/jira/browse/QPID-5279 Project: Qpid

[jira] [Updated] (QPID-5278) Queue flow limit validation ignores size parameters

2013-10-31 Thread Pavel Moravec (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Moravec updated QPID-5278: Description: Broker allows a queue creation with --max-queue-size=1 --flow-stop-size=100. Further,

[jira] [Updated] (QPID-5278) Queue flow limit validation ignores size parameters

2013-10-31 Thread Pavel Moravec (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pavel Moravec updated QPID-5278: Description: Broker allows a queue creation with --max-queue-size=1 --flow-stop-size=100. Further,

[jira] [Created] (QPID-5280) exclusivity of queue not enforced for bind/unbind

2013-10-31 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-5280: Summary: exclusivity of queue not enforced for bind/unbind Key: QPID-5280 URL: https://issues.apache.org/jira/browse/QPID-5280 Project: Qpid Issue Type: Bug

[jira] [Created] (QPID-5281) Creating a queue with invalid settings results in no queue but only its management object exists

2013-10-31 Thread Pavel Moravec (JIRA)
Pavel Moravec created QPID-5281: --- Summary: Creating a queue with invalid settings results in no queue but only its management object exists Key: QPID-5281 URL: https://issues.apache.org/jira/browse/QPID-5281

Re: Review Request 15094: QPID-5278: Queue flow limit validation ignores size parameters

2013-10-31 Thread Pavel Moravec
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15094/ --- (Updated Oct. 31, 2013, 12:50 p.m.) Review request for qpid, Gordon Sim and

Re: Review Request 15094: QPID-5278 QPID-5281: Queue flow limit validation ignores size parameters Creating a queue with invalid settings results in no queue but only its management object exists

2013-10-31 Thread Pavel Moravec
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15094/ --- (Updated Oct. 31, 2013, 12:51 p.m.) Review request for qpid, Gordon Sim and

Re: Review Request 15094: QPID-5278 QPID-5281: Queue flow limit validation ignores size parameters Creating a queue with invalid settings results in no queue but only its management object exists

2013-10-31 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15094/#review27889 --- /trunk/qpid/cpp/src/qpid/broker/QueueSettings.cpp

Re: Review Request 15083: Add ability create, delete and list objects of arbitrary types

2013-10-31 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15083/#review27890 --- Ship it! Just one small, optional request: the output is not very

Re: Review Request 15083: Add ability create, delete and list objects of arbitrary types

2013-10-31 Thread Gordon Sim
On Oct. 31, 2013, 12:57 p.m., Kenneth Giusti wrote: Just one small, optional request: the output is not very pretty. Maybe add column headers for name and value? Or line-wrap the values string? Again, not essential, but IMHO the current output is a bit hard to read. Good feedback,

Re: Review Request 15094: QPID-5278 QPID-5281: Queue flow limit validation ignores size parameters Creating a queue with invalid settings results in no queue but only its management object exists

2013-10-31 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15094/#review27895 --- Ship it! I like your idea for splitting out a public static

Re: Review Request 14882: on-demand node creation policies

2013-10-31 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14882/#review27897 --- Ship it! Ship It! - Kenneth Giusti On Oct. 30, 2013, 11:27

Re: Review Request 14882: on-demand node creation policies

2013-10-31 Thread Kenneth Giusti
On Oct. 30, 2013, 2:03 p.m., Kenneth Giusti wrote: /trunk/qpid/cpp/src/qpid/broker/amqp/NodePolicy.cpp, line 114 https://reviews.apache.org/r/14882/diff/1-2/?file=369941#file369941line114 My brain just stack dumped - durable is set to true if AUTO_DELETE is explicitly specified

[jira] [Commented] (QPID-5279) [AMQP 1.0] 1.0 receiver can consume from someone else's exclusive queue

2013-10-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810270#comment-13810270 ] ASF subversion and git services commented on QPID-5279: --- Commit

[jira] [Commented] (QPID-5280) exclusivity of queue not enforced for bind/unbind

2013-10-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810271#comment-13810271 ] ASF subversion and git services commented on QPID-5280: --- Commit

[jira] [Created] (QPID-5282) Sender timeouts may allow the peer to suffer an AMQFrameDecodingException

2013-10-31 Thread Keith Wall (JIRA)
Keith Wall created QPID-5282: Summary: Sender timeouts may allow the peer to suffer an AMQFrameDecodingException Key: QPID-5282 URL: https://issues.apache.org/jira/browse/QPID-5282 Project: Qpid

[jira] [Commented] (QPID-5282) Sender timeouts may allow the peer to suffer an AMQFrameDecodingException

2013-10-31 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810317#comment-13810317 ] Keith Wall commented on QPID-5282: -- The IoSender is also used by the Qpid JMS client. If

[jira] [Updated] (QPID-5282) Sender timeouts may allow the peer to suffer an AMQFrameDecodingException

2013-10-31 Thread Keith Wall (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keith Wall updated QPID-5282: - Description: If an IoSender#send suffers a timeout (IoSender.java#159) whilst awaiting space in the

Re: Review Request 15083: Add ability create, delete and list objects of arbitrary types

2013-10-31 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15083/#review27899 --- Ship it! Nice work, moving towards more consolidated configuration

[jira] [Created] (QPID-5283) exclusive declare granted even if queue has existing consumer

2013-10-31 Thread Gordon Sim (JIRA)
Gordon Sim created QPID-5283: Summary: exclusive declare granted even if queue has existing consumer Key: QPID-5283 URL: https://issues.apache.org/jira/browse/QPID-5283 Project: Qpid Issue

[jira] [Commented] (QPID-5283) exclusive declare granted even if queue has existing consumer

2013-10-31 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13810536#comment-13810536 ] ASF subversion and git services commented on QPID-5283: --- Commit

[jira] [Resolved] (QPID-5279) [AMQP 1.0] 1.0 receiver can consume from someone else's exclusive queue

2013-10-31 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-5279. -- Resolution: Fixed [AMQP 1.0] 1.0 receiver can consume from someone else's exclusive queue

[jira] [Resolved] (QPID-5283) exclusive declare granted even if queue has existing consumer

2013-10-31 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-5283. -- Resolution: Fixed exclusive declare granted even if queue has existing consumer

[jira] [Resolved] (QPID-5280) exclusivity of queue not enforced for bind/unbind

2013-10-31 Thread Gordon Sim (JIRA)
[ https://issues.apache.org/jira/browse/QPID-5280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gordon Sim resolved QPID-5280. -- Resolution: Fixed exclusivity of queue not enforced for bind/unbind