[GitHub] qpid-proton issue #160: WIP: option version of connection_options getters

2018-09-28 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/qpid-proton/pull/160 # [Codecov](https://codecov.io/gh/apache/qpid-proton/pull/160?src=pr&el=h1) Report > Merging [#160](https://codecov.io/gh/apache/qpid-proton/pull/160?src=pr&el=desc) into [master](https:

[GitHub] qpid-proton issue #160: WIP: option version of connection_options getters

2018-09-28 Thread alanconway
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/160 Here's the final version, I'll hold off till after release to take a bit of time to consider API impact. @astitcher @ssorj --- -

[jira] [Created] (DISPATCH-1134) Console tests should be skipped (instead of failing) if console is not installed

2018-09-28 Thread Ernest Allen (JIRA)
Ernest Allen created DISPATCH-1134: -- Summary: Console tests should be skipped (instead of failing) if console is not installed Key: DISPATCH-1134 URL: https://issues.apache.org/jira/browse/DISPATCH-1134

[jira] [Updated] (QPIDJMS-411) Improve output of the frame tracing loggers to include the binary payload

2018-09-28 Thread Robbie Gemmell (JIRA)
[ https://issues.apache.org/jira/browse/QPIDJMS-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robbie Gemmell updated QPIDJMS-411: --- Summary: Improve output of the frame tracing loggers to include the binary payload (was: Im

[jira] [Commented] (QPID-8245) [Broker-J] [AMQP 0-8..0-91] Decode FiledTable fields on demand

2018-09-28 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16632089#comment-16632089 ] Alex Rudyy commented on QPID-8245: -- [~rgodfrey], I attached patch {{0007-QPID-8245-Chang

[GitHub] qpid-proton issue #160: WIP: option version of connection_options getters

2018-09-28 Thread alanconway
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/160 > Perhaps we could have a C++11 only explicit bool conversion as well as is_set(). However we would need to experiment a bit as some of the options themselves are also bools so this might be

[jira] [Updated] (QPID-8245) [Broker-J] [AMQP 0-8..0-91] Decode FiledTable fields on demand

2018-09-28 Thread Alex Rudyy (JIRA)
[ https://issues.apache.org/jira/browse/QPID-8245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alex Rudyy updated QPID-8245: - Attachment: 0007-QPID-8245-Change-decoding-to-decode-only-value-for-t.patch 0006-QPID-8245-

[GitHub] qpid-proton issue #160: WIP: option version of connection_options getters

2018-09-28 Thread astitcher
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/160 I definitely like making option a class in common rather than duplicating it. I think that this is the correct way to expose options in the API, but perhaps we could make the API a bi

[jira] [Commented] (PROTON-1703) [cpp] Remove auto_settle from receiver options

2018-09-28 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631970#comment-16631970 ] Alan Conway commented on PROTON-1703: - Un-assigning myself and linking this as "is c

[jira] [Assigned] (PROTON-1943) Review features mark deprecated and consider removing them.

2018-09-28 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1943: --- Assignee: Justin Ross > Review features mark deprecated and consider removing them. > -

[jira] [Created] (PROTON-1943) Review features mark deprecated and consider removing them.

2018-09-28 Thread Alan Conway (JIRA)
Alan Conway created PROTON-1943: --- Summary: Review features mark deprecated and consider removing them. Key: PROTON-1943 URL: https://issues.apache.org/jira/browse/PROTON-1943 Project: Qpid Proton

[jira] [Assigned] (PROTON-1703) [cpp] Remove auto_settle from receiver options

2018-09-28 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway reassigned PROTON-1703: --- Assignee: (was: Alan Conway) > [cpp] Remove auto_settle from receiver options > ---

[jira] [Resolved] (PROTON-1935) [cpp] Read a config file to get default connection parameters

2018-09-28 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved PROTON-1935. - Resolution: Fixed > [cpp] Read a config file to get default connection parameters > ---

[jira] [Resolved] (PROTON-1940) [c] normalize encoding of multiple="true" fields

2018-09-28 Thread Alan Conway (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Conway resolved PROTON-1940. - Resolution: Fixed > [c] normalize encoding of multiple="true" fields > -

[jira] [Commented] (PROTON-1831) [c] duplicate link names cause invalid read in pn_transport_unbind_handles

2018-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631833#comment-16631833 ] ASF GitHub Bot commented on PROTON-1831: Github user alanconway commented on the

[GitHub] qpid-proton pull request #151: Install tests

2018-09-28 Thread alanconway
Github user alanconway closed the pull request at: https://github.com/apache/qpid-proton/pull/151 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #151: Install tests

2018-09-28 Thread alanconway
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/151 Merged: 393f8a67 * PROTON-1798: [c, cpp, ruby] Installable tests for proton --- - To unsubscribe, e-mail: dev-unsubscr...@

[jira] [Commented] (PROTON-1940) [c] normalize encoding of multiple="true" fields

2018-09-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631838#comment-16631838 ] ASF subversion and git services commented on PROTON-1940: - Commi

[GitHub] qpid-proton issue #159: PROTON-1940: [c] normalize encoding of multiple="tru...

2018-09-28 Thread alanconway
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/159 Merged, if there are still objections to using a vfill code lets open a new issue --- - To unsubscribe, e-mail: dev-unsub

[jira] [Commented] (PROTON-1940) [c] normalize encoding of multiple="true" fields

2018-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631840#comment-16631840 ] ASF GitHub Bot commented on PROTON-1940: Github user asfgit closed the pull requ

[jira] [Commented] (PROTON-1940) [c] normalize encoding of multiple="true" fields

2018-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631841#comment-16631841 ] ASF GitHub Bot commented on PROTON-1940: Github user alanconway commented on the

[GitHub] qpid-proton pull request #159: PROTON-1940: [c] normalize encoding of multip...

2018-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/qpid-proton/pull/159 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[jira] [Commented] (PROTON-1831) [c] duplicate link names cause invalid read in pn_transport_unbind_handles

2018-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631834#comment-16631834 ] ASF GitHub Bot commented on PROTON-1831: Github user alanconway closed the pull

[GitHub] qpid-proton pull request #142: PROTON-1831: Incorrect open/close sequence fo...

2018-09-28 Thread alanconway
Github user alanconway closed the pull request at: https://github.com/apache/qpid-proton/pull/142 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #142: PROTON-1831: Incorrect open/close sequence for same ...

2018-09-28 Thread alanconway
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/142 Merged, see JIRA --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@q

[jira] [Commented] (PROTON-1798) Installed example self-tests for proton

2018-09-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/PROTON-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631828#comment-16631828 ] ASF GitHub Bot commented on PROTON-1798: Github user alanconway commented on the

[GitHub] qpid-proton pull request #157: WIP: extract connection_options_impl for test...

2018-09-28 Thread alanconway
Github user alanconway closed the pull request at: https://github.com/apache/qpid-proton/pull/157 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #157: WIP: extract connection_options_impl for tests and i...

2018-09-28 Thread alanconway
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/157 Dropped this approch, see #160 for a public API using proton::option --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.a

[GitHub] qpid-proton pull request #160: WIP: option version of connection_options ...

2018-09-28 Thread alanconway
GitHub user alanconway opened a pull request: https://github.com/apache/qpid-proton/pull/160 WIP: option version of connection_options getters This is the template approach to option getters - memory safe. Needs to be extended to all the _options classes, but I want agreement on