[GitHub] [qpid-proton] astitcher merged pull request #376: NO-JIRA: Fix type of `bytes` test data for message id in python tests

2023-04-05 Thread via GitHub
astitcher merged PR #376: URL: https://github.com/apache/qpid-proton/pull/376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@qpid.apach

[jira] [Commented] (PROTON-2401) on_link_closed is not called when remote detaches link and locally link is also closed.

2023-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709116#comment-17709116 ] ASF GitHub Bot commented on PROTON-2401: astitcher commented on PR #391: URL: ht

[GitHub] [qpid-proton] astitcher commented on pull request #391: PROTON-2401: [Python] on_xxx_closed should be called on locally closed after remote close

2023-04-05 Thread via GitHub
astitcher commented on PR #391: URL: https://github.com/apache/qpid-proton/pull/391#issuecomment-1498188256 I've modified the original PR: * The same logic should apply to the connection and session events too * No need to call xxx_close as you'll only get the _close event after the xx

[jira] [Commented] (PROTON-2401) on_link_closed is not called when remote detaches link and locally link is also closed.

2023-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709114#comment-17709114 ] ASF GitHub Bot commented on PROTON-2401: astitcher opened a new pull request, #3

[GitHub] [qpid-proton] astitcher opened a new pull request, #391: PROTON-2401: [Python] on_xxx_closed should be called on locally closed after remote close

2023-04-05 Thread via GitHub
astitcher opened a new pull request, #391: URL: https://github.com/apache/qpid-proton/pull/391 When links/sessions/connections are remotely closed then locally closed the on_xxx_closed event should still fire. The existing code only fires this event for local then remote close. This

[jira] [Assigned] (PROTON-2401) on_link_closed is not called when remote detaches link and locally link is also closed.

2023-04-05 Thread Andrew Stitcher (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Stitcher reassigned PROTON-2401: --- Assignee: Andrew Stitcher > on_link_closed is not called when remote detaches link

[GitHub] [qpid-proton] Jmennius commented on pull request #388: NO-JIRA: [Python] Allow configuration of container ID

2023-04-05 Thread via GitHub
Jmennius commented on PR #388: URL: https://github.com/apache/qpid-proton/pull/388#issuecomment-1497843962 > @Jmennius I've merged a neater version of this change with a test to make sure it works. Note you'll likely get a faster response at least from me) if you include a test or two for y

[GitHub] [qpid-proton] astitcher commented on pull request #388: NO-JIRA: [Python] Allow configuration of container ID

2023-04-05 Thread via GitHub
astitcher commented on PR #388: URL: https://github.com/apache/qpid-proton/pull/388#issuecomment-1497829984 @Jmennius I've merged a neater version of this change with a test to make sure it works. Note you'll likely get a faster response at least from me) if you include a test or two for yo

[jira] [Commented] (PROTON-2706) [Python] Allow setting the container id for containers/connections

2023-04-05 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17709016#comment-17709016 ] ASF subversion and git services commented on PROTON-2706: - Commi

[GitHub] [qpid-proton] asfgit closed pull request #388: NO-JIRA: [Python] Allow configuration of container ID

2023-04-05 Thread via GitHub
asfgit closed pull request #388: NO-JIRA: [Python] Allow configuration of container ID URL: https://github.com/apache/qpid-proton/pull/388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Created] (PROTON-2706) [Python] Allow setting the container id for containers/connections

2023-04-05 Thread Andrew Stitcher (Jira)
Andrew Stitcher created PROTON-2706: --- Summary: [Python] Allow setting the container id for containers/connections Key: PROTON-2706 URL: https://issues.apache.org/jira/browse/PROTON-2706 Project: Qpi

[jira] [Commented] (PROTON-2183) [cpp client] No messaging_handler callback for aborted messages

2023-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708821#comment-17708821 ] ASF GitHub Bot commented on PROTON-2183: DreamPearl commented on PR #387: URL: h

[jira] [Commented] (PROTON-2183) [cpp client] No messaging_handler callback for aborted messages

2023-04-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PROTON-2183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17708822#comment-17708822 ] ASF GitHub Bot commented on PROTON-2183: DreamPearl closed pull request #387: PR

[GitHub] [qpid-proton] DreamPearl commented on pull request #387: PROTON-2183: [cpp] Fix aborted messages exception.

2023-04-05 Thread via GitHub
DreamPearl commented on PR #387: URL: https://github.com/apache/qpid-proton/pull/387#issuecomment-1497338754 PR merged as https://github.com/apache/qpid-proton/commit/058e2928dad9d016fe14a8b6690547e39cdfd0fd. TODO: Add test (in-progress) -- This is an automated message from the Apa

[GitHub] [qpid-proton] DreamPearl closed pull request #387: PROTON-2183: [cpp] Fix aborted messages exception.

2023-04-05 Thread via GitHub
DreamPearl closed pull request #387: PROTON-2183: [cpp] Fix aborted messages exception. URL: https://github.com/apache/qpid-proton/pull/387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif