[GitHub] qpid-dispatch pull request #424: DISPATCH-1187: add options to log in UTC an...

2018-12-06 Thread grs
Github user grs closed the pull request at: https://github.com/apache/qpid-dispatch/pull/424 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-dispatch pull request #424: DISPATCH-1187: add options to log in UTC an...

2018-12-04 Thread grs
GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/424 DISPATCH-1187: add options to log in UTC and to give control over the… … precise format of the date/time logged You can merge this pull request into a Git repository by running: $ git

[GitHub] qpid-dispatch pull request #418: DISPATCH-1181: add hint about treatment to ...

2018-11-09 Thread grs
GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/418 DISPATCH-1181: add hint about treatment to MAU ...and use that on receipt if there is no locally defined treatment You can merge this pull request into a Git repository by running: $ git

[GitHub] qpid-dispatch pull request #373: DISPATCH-1117: suggested doc fixes

2018-10-22 Thread grs
Github user grs closed the pull request at: https://github.com/apache/qpid-dispatch/pull/373 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton pull request #150: PROTON-1888: allow configuration of connectio...

2018-09-26 Thread grs
Github user grs closed the pull request at: https://github.com/apache/qpid-proton/pull/150 --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h...@qpid.apache.org

[GitHub] qpid-proton issue #150: PROTON-1888: allow configuration of connection detai...

2018-09-25 Thread grs
Github user grs commented on the issue: https://github.com/apache/qpid-proton/pull/150 Rebased and updated to align with commit for PROTON-1935 for c++ --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org

[GitHub] qpid-dispatch issue #372: DISPATCH-1116: prevent module being updated on log...

2018-09-06 Thread grs
Github user grs commented on the issue: https://github.com/apache/qpid-dispatch/pull/372 @ganeshmurthy @ted-ross does this look ok? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional

[GitHub] qpid-dispatch issue #373: DISPATCH-1117: suggested doc fixes

2018-09-06 Thread grs
Github user grs commented on the issue: https://github.com/apache/qpid-dispatch/pull/373 @bhardesty does this look ok? --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail

[GitHub] qpid-dispatch pull request #373: DISPATCH-1117: suggested doc fixes

2018-09-06 Thread grs
GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/373 DISPATCH-1117: suggested doc fixes You can merge this pull request into a Git repository by running: $ git pull https://github.com/grs/qpid-dispatch DISPATCH-1117 Alternatively you can

[GitHub] qpid-dispatch pull request #372: DISPATCH-1116: prevent module being updated...

2018-09-06 Thread grs
GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/372 DISPATCH-1116: prevent module being updated on log instances You can merge this pull request into a Git repository by running: $ git pull https://github.com/grs/qpid-dispatch DISPATCH-1116

[GitHub] qpid-dispatch issue #357: DISPATCH-1099 - Added plumbing that sends ticks in...

2018-08-10 Thread grs
Github user grs commented on the issue: https://github.com/apache/qpid-dispatch/pull/357 Possibly silly question, but is there any performance impact to this? --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] qpid-dispatch pull request #357: DISPATCH-1099 - Added plumbing that sends t...

2018-08-10 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/357#discussion_r209165667 --- Diff: src/router_core/core_timer.c --- @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] qpid-proton pull request #150: PROTON-1888: allow configuration of connectio...

2018-07-09 Thread grs
GitHub user grs opened a pull request: https://github.com/apache/qpid-proton/pull/150 PROTON-1888: allow configuration of connection details from a config … …file The file to use can be specified using the CONNECT_CONFIG environment variable. If that is not set

[GitHub] qpid-dispatch pull request #303: DISPATCH-994 - Added null checks on links/c...

2018-05-10 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/303#discussion_r187367734 --- Diff: src/router_core/connections.c --- @@ -473,7 +474,8 @@ void qdr_link_second_attach(qdr_link_t *link, qdr_terminus_t *source, qdr_termin

[GitHub] qpid-dispatch pull request #293: DISPATCH-977: Add transaction coordinator s...

2018-04-25 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/293#discussion_r184128463 --- Diff: doc/new-book/routing.adoc --- @@ -575,6 +575,20 @@ connector { For information about additional attributes, see link

[GitHub] qpid-dispatch pull request #293: DISPATCH-977: Add transaction coordinator s...

2018-04-25 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/293#discussion_r184127780 --- Diff: doc/new-book/routing.adoc --- @@ -575,6 +575,20 @@ connector { For information about additional attributes, see link

[GitHub] qpid-cpp issue #12: WIP - A batch of C++ updates

2018-03-13 Thread grs
Github user grs commented on the issue: https://github.com/apache/qpid-cpp/pull/12 Looks good to me --- - To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org For additional commands, e-mail: dev-h

[GitHub] qpid-dispatch pull request #188: DISPATCH-775: provide a plugin that will de...

2017-08-14 Thread grs
Github user grs closed the pull request at: https://github.com/apache/qpid-dispatch/pull/188 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] qpid-dispatch pull request #188: DISPATCH-775: provide a plugin that will de...

2017-08-14 Thread grs
GitHub user grs opened a pull request: https://github.com/apache/qpid-dispatch/pull/188 DISPATCH-775: provide a plugin that will delegate sasl authentication… … to a specified authentication service You can merge this pull request into a Git repository by running: $ git

[GitHub] qpid-dispatch pull request #185: DISPATCH-803 - The following changes were m...

2017-08-09 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/185#discussion_r132281323 --- Diff: src/router_core/transfer.c --- @@ -634,6 +634,23 @@ static void qdr_link_forward_CT(qdr_core_t *core, qdr_link_t *link, qdr_delivery

[GitHub] qpid-dispatch pull request #185: DISPATCH-803 - The following changes were m...

2017-08-09 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/185#discussion_r132280889 --- Diff: python/qpid_dispatch/management/qdrouter.json --- @@ -504,6 +504,13 @@ "deprecated&q

[GitHub] qpid-proton issue #106: Added command line parameters for configure URL and ...

2017-05-23 Thread grs
Github user grs commented on the issue: https://github.com/apache/qpid-proton/pull/106 One minor issue: this doesn't work at present with the defaults. It seems to be because urlparse requires a scheme. You can use Url from proton e.g. as in sync_client.py. --- If your project

[GitHub] qpid-dispatch issue #99: DISPATCH-500 - Fixed code to use qdr_field_t to pas...

2016-09-14 Thread grs
Github user grs commented on the issue: https://github.com/apache/qpid-dispatch/pull/99 Is this for DISPATCH-502? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] qpid-dispatch pull request #96: Use atomic ops for ref_counts

2016-08-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/96#discussion_r75930357 --- Diff: src/connection_manager.c --- @@ -254,9 +252,8 @@ qd_config_ssl_profile_t *qd_dispatch_configure_ssl_profile(qd_dispatch_t *qd, qd

[GitHub] qpid-dispatch pull request #96: Use atomic ops for ref_counts

2016-08-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/96#discussion_r75927487 --- Diff: src/connection_manager.c --- @@ -254,9 +252,8 @@ qd_config_ssl_profile_t *qd_dispatch_configure_ssl_profile(qd_dispatch_t *qd, qd

[GitHub] qpid issue #10: feat(disposition): respect messageAnnotation mods in modifie...

2016-06-28 Thread grs
Github user grs commented on the issue: https://github.com/apache/qpid/pull/10 Thanks again Matt! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] qpid pull request #10: feat(disposition): respect messageAnnotation mods in ...

2016-06-28 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/10#discussion_r68769620 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -108,6 +109,19 @@ void OutgoingFromQueue::write(const char* data, size_t size) pn_link_send

[GitHub] qpid issue #9: feat(disposition): support undeliverable-here in modified out...

2016-06-27 Thread grs
Github user grs commented on the issue: https://github.com/apache/qpid/pull/9 @mbroadst this is now committed. I somehow messed up the intended merge commit (I think perhaps on git svn rebase), so I'm afraid I neither marked the JIRA for this (https://issues.apache.org/jira/browse

[GitHub] qpid issue #9: feat(disposition): support undeliverable-here in modified out...

2016-06-27 Thread grs
Github user grs commented on the issue: https://github.com/apache/qpid/pull/9 Actually, I've confirmed a patch isn't necessary. I can use your PR branch. I'll give this a test today and all going well merge it in. --- If your project is set up for it, you can reply to this email

[GitHub] qpid pull request #:

2016-06-24 Thread grs
Github user grs commented on the pull request: https://github.com/apache/qpid/commit/7b8a91375dc0528e2c15686ab71c3647ac3e2f96#commitcomment-18005323 In qpid/cpp/src/qpid/broker/Queue.h: In qpid/cpp/src/qpid/broker/Queue.h on line 538: should be fixed now --- If your project

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-24 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68367813 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string&

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68322398 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string&

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68322267 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -142,11 +145,10 @@ void OutgoingFromQueue::handle(pn_delivery_t* delivery

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68299958 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -142,11 +145,10 @@ void OutgoingFromQueue::handle(pn_delivery_t* delivery

[GitHub] qpid pull request #9: feat(disposition): support undeliverable-here in modif...

2016-06-23 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid/pull/9#discussion_r68299289 --- Diff: qpid/cpp/src/qpid/broker/amqp/Outgoing.cpp --- @@ -79,6 +79,9 @@ OutgoingFromQueue::OutgoingFromQueue(Broker& broker, const std::string&

[GitHub] qpid-dispatch pull request #83: DISPATCH-401 - Verified host name by default...

2016-06-22 Thread grs
Github user grs commented on a diff in the pull request: https://github.com/apache/qpid-dispatch/pull/83#discussion_r68114603 --- Diff: python/qpid_dispatch_internal/tools/command.py --- @@ -83,6 +83,11 @@ def connection_options(options, title="Connection Op