[GitHub] qpid-proton issue #154: Replace user-defined macro WIN32 by compiler-defined...

Github user matlo607 commented on the issue: https://github.com/apache/qpid-proton/pull/154 Actually everything looks correct in the C code. Here below is the result of `git grep WIN32`. ``` CMakeLists.txt:382: if(WIN32) c/CMakeLists.txt:22:if(WIN32 AND NOT CYGWIN

[GitHub] qpid-proton pull request #154: Replace user-defined macro WIN32 by compiler-...

GitHub user matlo607 opened a pull request: https://github.com/apache/qpid-proton/pull/154 Replace user-defined macro WIN32 by compiler-defined _WIN32 On Windows, if qpid-proton is used by another build system (still compiling with VC) than a Visual Studio project, `/D WIN32

[GitHub] qpid-dispatch pull request #288: Refactor cmake to use modern feature

GitHub user matlo607 opened a pull request: https://github.com/apache/qpid-dispatch/pull/288 Refactor cmake to use modern feature I wanted to create a recipe for [Conan](https://www.conan.io/) and I experienced some issue with the build system. You can merge this pull request

[GitHub] qpid-proton pull request #141: [windows] build fails if CMAKE_MODULE_PATH is...

GitHub user matlo607 opened a pull request: https://github.com/apache/qpid-proton/pull/141 [windows] build fails if CMAKE_MODULE_PATH is not empty, use CMAKE_SOURCE_DIR instead You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] qpid-proton issue #113: [Solaris] fix build with gcc-4.9

Github user matlo607 commented on the issue: https://github.com/apache/qpid-proton/pull/113 Hello, Is the build on Windows meeting some issues ? The errors are not related at all to my changes and I met exactly the same problem in another pull request (fix-path-test

[GitHub] qpid-proton pull request #113: [Solaris] fix build with gcc-4.9

GitHub user matlo607 opened a pull request: https://github.com/apache/qpid-proton/pull/113 [Solaris] fix build with gcc-4.9 You can merge this pull request into a Git repository by running: $ git pull https://github.com/matlo607/qpid-proton fix-build-gcc49-solaris

[GitHub] qpid-proton issue #112: fix paths to test binaries

Github user matlo607 commented on the issue: https://github.com/apache/qpid-proton/pull/112 @astitcher Please could you give me some hints to fix the build on Windows ? I don't have a clue and a Windows machine too. --- If your project is set up for it, you can reply

[GitHub] qpid-proton pull request #112: fix paths to test binaries

GitHub user matlo607 opened a pull request: https://github.com/apache/qpid-proton/pull/112 fix paths to test binaries I could not execute the unit tests on Linux after a build with the package manager conan. I got various errors as below : ``` Could not find executable