[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-proton/pull/119 @jdanekrh cppcheck is a command line tool in fact this is how I ran it, you don't need to use an ide plugin if you don't want to. Also there are Jenkins plugin to add to a build

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-proton/pull/119 @astitcher https://issues.apache.org/jira/browse/PROTON-1572 just created with the output of cppcheck 1.8 run we did earlier today

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-proton/pull/119 @astitcher there is more than just that one, i note when using 1.75 there are far less things detected that 1.8, thus the question to @jdanekrh

[GitHub] qpid-proton issue #119: NO-JIRA Fix CppCheck warnings

2017-09-05 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-proton/pull/119 @jdanekrh which version of cppcheck you using? using 1.8 we get a few more warnings, e.g. detects header file method param names order don't match cpp implementation. e.g

[GitHub] qpid-jms issue #12: QPIDJMS-315: Add support for Netty KQueue transport

2017-08-25 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-jms/pull/12 @gemmellr ping - sorry for delay was on route home, didn't need to update test, forgot it was explicitly being turned on and off anyhow. as such should be good. --- If your project

[GitHub] qpid-jms issue #12: QPIDJMS-315: Add support for Netty KQueue transport

2017-08-25 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-jms/pull/12 I just have to update test case to enable kqueue on env with macOS as default is off now, and so for test I need to enable. Will update in a bit and nudge once done --- If your

[GitHub] qpid-jms issue #12: QPIDJMS-315: Add support for Netty KQueue transport

2017-08-25 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-jms/pull/12 So on this pr front: Default kqueue is now false Reverted out the extra check for lib loading, kqueue is relying like epoll on the similar isAvailable() from netty

[GitHub] qpid-jms issue #12: QPIDJMS-315: Add support for Netty KQueue transport

2017-08-25 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-jms/pull/12 @tabish121 ah good spot def will link up the issues. And yeah I'll try to make a pr there. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] qpid-jms issue #12: QPIDJMS-315: Add support for Netty KQueue transport

2017-08-25 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-jms/pull/12 @gemmellr fyi raised https://github.com/netty/netty/issues/7150 for underlying issue within netty project. --- If your project is set up for it, you can reply to this email and have

[GitHub] qpid-jms issue #12: QPIDJMS-315: Add support for Netty KQueue transport

2017-08-25 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-jms/pull/12 > Given it seems it only happens if you use a 32bit JVM and only emits a warning, I don't think its serious enough to introduce all that not-ideal code for the existing epoll bits w

[GitHub] qpid-jms issue #12: QPIDJMS-315: Add support for Netty KQueue transport

2017-08-25 Thread michaelandrepearce
Github user michaelandrepearce commented on the issue: https://github.com/apache/qpid-jms/pull/12 Hi @gemmellr > I don't think the various environment etc checking being done really belongs in the client, it seems like that stuff belongs in Netty if the isAvailable() che

[GitHub] qpid-jms pull request #12: QPIDJMS-315: Add support for Netty KQueue transpo...

2017-08-24 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/qpid-jms/pull/12 QPIDJMS-315: Add support for Netty KQueue transport Add KQueue support Also add safer epoll and kqueue env check to protect from lib loading failure (as found in apache activemq

[GitHub] qpid-jms pull request #11: QPIDJMS-315: Add support for Netty KQueue transpo...

2017-08-24 Thread michaelandrepearce
Github user michaelandrepearce closed the pull request at: https://github.com/apache/qpid-jms/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] qpid-jms pull request #11: QPIDJMS-315: Add support for Netty KQueue transpo...

2017-08-24 Thread michaelandrepearce
GitHub user michaelandrepearce opened a pull request: https://github.com/apache/qpid-jms/pull/11 QPIDJMS-315: Add support for Netty KQueue transport Add KQueue support Also add safer epoll and kqueue env check to protect from lib loading failure (as found in apache activemq