[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #1416: DISPATCH-1958: Fixed error in qdstat when memory stats are turned off…

2021-11-02 Thread GitBox
ganeshmurthy commented on pull request #1416: URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957887593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #1416: DISPATCH-1958: Fixed error in qdstat when memory stats are turned off…

2021-11-02 Thread GitBox
ganeshmurthy commented on pull request #1416: URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-958128206 > Let's do this the simple way and remove the flag. Sounds good. I will add a commit to this PR removing the flag. Thanks. -- This is an automated message fro

[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #1416: DISPATCH-1958: Fixed error in qdstat when memory stats are turned off…

2021-11-02 Thread GitBox
ganeshmurthy commented on pull request #1416: URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957887593 > hmmm... I wonder if it would be simpler to make QD_MEMORY_STATS non-configurable? IOW, get rid of the flag and just always provide memory statistics. It's pretty ob

[GitHub] [qpid-dispatch] ganeshmurthy commented on pull request #1416: DISPATCH-1958: Fixed error in qdstat when memory stats are turned off…

2021-11-02 Thread GitBox
ganeshmurthy commented on pull request #1416: URL: https://github.com/apache/qpid-dispatch/pull/1416#issuecomment-957887593 > hmmm... I wonder if it would be simpler to make QD_MEMORY_STATS non-configurable? IOW, get rid of the flag and just always provide memory statistics. It's pretty ob