[GitHub] [qpid-proton] cliffjansen commented on a diff in pull request #402: PROTON-2748: Raw connection async close fix and tests.

2023-09-08 Thread via GitHub
cliffjansen commented on code in PR #402: URL: https://github.com/apache/qpid-proton/pull/402#discussion_r1320289915 ## c/src/proactor/epoll_raw_connection.c: ## @@ -318,12 +319,18 @@ static pn_event_t *pni_raw_batch_next(pn_event_batch_t *batch) { unlock(>task.mutex);

[GitHub] [qpid-proton] cliffjansen commented on a diff in pull request #402: PROTON-2748: Raw connection async close fix and tests.

2023-09-08 Thread via GitHub
cliffjansen commented on code in PR #402: URL: https://github.com/apache/qpid-proton/pull/402#discussion_r1320281476 ## c/src/proactor/raw_connection.c: ## @@ -721,6 +723,14 @@ pn_event_t *pni_raw_event_next(pn_raw_connection_t *conn) { } while (true); } +pn_event_t

[GitHub] [qpid-proton] cliffjansen commented on a diff in pull request #402: PROTON-2748: Raw connection async close fix and tests.

2023-09-08 Thread via GitHub
cliffjansen commented on code in PR #402: URL: https://github.com/apache/qpid-proton/pull/402#discussion_r1320280918 ## c/src/proactor/epoll_raw_connection.c: ## @@ -442,24 +458,31 @@ void pni_raw_connection_done(praw_connection_t *rc) { // The task may be in the ready state

[GitHub] [qpid-proton] cliffjansen commented on a diff in pull request #402: PROTON-2748: Raw connection async close fix and tests.

2023-09-08 Thread via GitHub
cliffjansen commented on code in PR #402: URL: https://github.com/apache/qpid-proton/pull/402#discussion_r1320280088 ## c/src/proactor/epoll_raw_connection.c: ## @@ -408,32 +415,41 @@ pn_event_batch_t *pni_raw_connection_process(task_t *t, uint32_t io_events, bool }

[GitHub] [qpid-proton] cliffjansen commented on a diff in pull request #402: PROTON-2748: Raw connection async close fix and tests.

2023-09-08 Thread via GitHub
cliffjansen commented on code in PR #402: URL: https://github.com/apache/qpid-proton/pull/402#discussion_r1320280431 ## c/src/proactor/epoll_raw_connection.c: ## @@ -318,12 +319,18 @@ static pn_event_t *pni_raw_batch_next(pn_event_batch_t *batch) { unlock(>task.mutex);

[GitHub] [qpid-proton] cliffjansen commented on a diff in pull request #402: PROTON-2748: Raw connection async close fix and tests.

2023-09-08 Thread via GitHub
cliffjansen commented on code in PR #402: URL: https://github.com/apache/qpid-proton/pull/402#discussion_r1320279795 ## c/src/proactor/epoll_raw_connection.c: ## @@ -304,7 +305,7 @@ void pn_raw_connection_write_close(pn_raw_connection_t *rc) { pni_raw_write_close(rc); }

[GitHub] [qpid-proton] cliffjansen commented on a diff in pull request #402: PROTON-2748: Raw connection async close fix and tests.

2023-08-24 Thread via GitHub
cliffjansen commented on code in PR #402: URL: https://github.com/apache/qpid-proton/pull/402#discussion_r1304730556 ## c/src/proactor/epoll_raw_connection.c: ## @@ -408,32 +415,41 @@ pn_event_batch_t *pni_raw_connection_process(task_t *t, uint32_t io_events, bool }