[GitHub] [qpid-proton] jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently

2020-01-17 Thread GitBox
jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently URL: https://github.com/apache/qpid-proton/pull/207#issuecomment-575820136 Test command has changed in some Python and Go tests, but I think there is nothing wrong with the new state of things. ## Unix

[GitHub] [qpid-proton] jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently

2020-01-17 Thread GitBox
jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently URL: https://github.com/apache/qpid-proton/pull/207#issuecomment-575709767 First version of the PR * https://travis-ci.org/apache/qpid-proton/builds/637458579 *

[GitHub] [qpid-proton] jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently

2020-01-16 Thread GitBox
jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently URL: https://github.com/apache/qpid-proton/pull/207#issuecomment-575092712 What I have currently in mind is something like this. Hopefully it will work well for other tests besides ruby. ```diff

[GitHub] [qpid-proton] jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently

2020-01-15 Thread GitBox
jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently URL: https://github.com/apache/qpid-proton/pull/207#issuecomment-574690671 I can quickly test this by building all bindings, and then do `ctest -N -VV` on Linux and Windows, and diff outputs before and after

[GitHub] [qpid-proton] jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently

2020-01-15 Thread GitBox
jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently URL: https://github.com/apache/qpid-proton/pull/207#issuecomment-574682625 And I just wanted to run leak check with proton-python! :( OK, so the test registration instances I need to unify looks like this

[GitHub] [qpid-proton] jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently

2019-11-21 Thread GitBox
jdanekrh commented on issue #207: PROTON-2135 Set TEST_ENV more consistently URL: https://github.com/apache/qpid-proton/pull/207#issuecomment-557162035 Making large changes to CMake scares me, but well, I can try to make it into a macro. The difficulty is the usual one, the test