Github user asfgit closed the pull request at:
https://github.com/apache/qpid-jms/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/qpid-jms/pull/9#discussion_r127257588
--- Diff:
qpid-jms-client/src/test/java/org/apache/qpid/jms/sasl/CramMD5MechanismTest.java
---
@@ -85,4 +115,21 @@ public String getName() {
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/qpid-jms/pull/9#discussion_r127257712
--- Diff:
qpid-jms-client/src/main/java/org/apache/qpid/jms/sasl/CramMD5Mechanism.java ---
@@ -86,6 +86,14 @@ public String getName() {
}
Github user tabish121 commented on a diff in the pull request:
https://github.com/apache/qpid-jms/pull/9#discussion_r127257449
--- Diff:
qpid-jms-client/src/test/java/org/apache/qpid/jms/sasl/AbstractScramSHAMechanismTestBase.java
---
@@ -137,4 +139,25 @@ public void
GitHub user k-wall opened a pull request:
https://github.com/apache/qpid-jms/pull/9
QPIDJMS-294: Ensure that SASL mechanism has completed before allowingâ¦
⦠authentication to complete successfully
This change allows the SCRAM mechanisms to ensure that server final
