[GitHub] qpid-proton issue #87: Proton-c core split

2016-11-15 Thread alanconway
Github user alanconway commented on the issue: https://github.com/apache/qpid-proton/pull/87 On Mon, 2016-11-14 at 09:47 -0800, Andrew Stitcher wrote: > @gemmellr I've been rebasing continually, so it's a surprise the > dates are so long ago - I'll reset them before commit.

[GitHub] qpid-proton issue #87: Proton-c core split

2016-11-14 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/qpid-proton/pull/87 Annoyingly git 'reuses' the first commit details when doing many operations and so even though the sha might change as you update a commit, it keeps its original date, and you need to explicitly

[GitHub] qpid-proton issue #87: Proton-c core split

2016-11-14 Thread astitcher
Github user astitcher commented on the issue: https://github.com/apache/qpid-proton/pull/87 @gemmellr I've been rebasing continually, so it's a surprise the dates are so long ago - I'll reset them before commit. Thanks for pointing this out. --- If your project is set up for it,

[GitHub] qpid-proton issue #87: Proton-c core split

2016-11-14 Thread gemmellr
Github user gemmellr commented on the issue: https://github.com/apache/qpid-proton/pull/87 No comment on the actual code, but before bringing to master can you update the commits to use a more up to date timestamp? :) (using --reset-author for example) --- If your project is set up

[GitHub] qpid-proton issue #87: Proton-c core split

2016-11-13 Thread cliffjansen
Github user cliffjansen commented on the issue: https://github.com/apache/qpid-proton/pull/87 +1... excellent reorg of code. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea