[ 
https://issues.apache.org/jira/browse/QPID-5485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pavel Moravec updated QPID-5485:
--------------------------------

    Attachment: QPID-5485-new.2.patch
                QPID-5485-new.1.patch

Two versions of patch provided.

First version (QPID-5485-new.1.patch) creates pagedQueues directory on demand 
(only). However when --paging-dir broker option is specified, "lock" file is 
created in the directory automatically, due to BrokerDefaults / 
Broker::Options. (if the option is not specified, no "lock" file is created).

That sudden appearing of "lock" file is quite surprising for an end user, hence 
simplified version of the patch (QPID-5485-new.2.patch) relies on 
BrokerDefaults / Broker::Options purely, such that paging-dir is created 
everytime during broker startup, and the "lock" file is there every time. It 
can be rewritten / deleted by creating / deleting queue named "lock" without 
any issue (well, as the broker keeps link to the file from elsewhere, deleting 
the "lock" queue the file disappears but remains invisible).

Another solution would be to have hardcoded directory name for paged queues 
files, hardcoded like "rhm" or "qls" names are. With the option to have 
symbolic link from the directory to any disk partition. Then no lock file will 
appear. But this would break backward compatibility as --paging-dir would be 
obsolete.. So I prefer option 2.

Your thoughts?

>  Deleting paged queue does not remove underlying file
> -----------------------------------------------------
>
>                 Key: QPID-5485
>                 URL: https://issues.apache.org/jira/browse/QPID-5485
>             Project: Qpid
>          Issue Type: Bug
>          Components: C++ Broker
>    Affects Versions: 0.24
>         Environment: (any posix system)
>            Reporter: Pavel Moravec
>            Assignee: Pavel Moravec
>            Priority: Minor
>              Labels: easyfix, easytest, patch
>             Fix For: 0.27
>
>         Attachments: QPID-5485-new.1.patch, QPID-5485-new.2.patch
>
>
> Description of problem:
> When deleting a paged queue, the broker does not delete the underlying file 
> it created in /var/lib/qpidd directory.
> Version-Release number of selected component (if applicable):
> MRG-M 3.0 EA (qpid-cpp 0.22-29)
> How reproducible:
> 100%
> Steps to Reproduce:
> 0. service qpiddd restart
> 1. qpid-send -a "PagedQueue; {create:always, delete:always, node: { 
> x-declare: {arguments: {'qpid.paging':'True' }}}}"
> 2. file /var/lib/qpidd/PagedQueue 
> Actual results:
> /var/lib/qpidd/PagedQueue: data
> Expected results:
> /var/lib/qpidd/PagedQueue: cannot open `/var/lib/qpidd/PagedQueue' (No such 
> file or directory)
> Additional info:



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@qpid.apache.org
For additional commands, e-mail: dev-h...@qpid.apache.org

Reply via email to