Re: QPID-2388: Do not unmask signals whilst waiting for IO to happen

2010-08-31 Thread Andrew Stitcher
On Fri, 2010-08-27 at 14:20 -0700, a fabbri wrote: On Fri, Aug 27, 2010 at 12:46 PM, Andrew Stitcher astitc...@redhat.com wrote: On Fri, 2010-08-27 at 12:32 -0700, a fabbri wrote: ... I've not tested, but I'd be very surprised. IIRC, my strace of qpidd and client showed a ton of

Re: QPID-2388: Do not unmask signals whilst waiting for IO to happen

2010-08-27 Thread a fabbri
cc:ing the list, as I think this may be interesting for others. On 8/27/10 7:18 AM, Andrew Stitcher astitc...@redhat.com wrote: On Thu, 2010-08-26 at 16:13 -0700, aafabbri wrote: Hi Andrew, Just curious if you observed any performance gains from your commit (below). Chances are you haven't

Re: QPID-2388: Do not unmask signals whilst waiting for IO to happen

2010-08-27 Thread Andrew Stitcher
On Fri, 2010-08-27 at 12:32 -0700, a fabbri wrote: ... I've not tested, but I'd be very surprised. IIRC, my strace of qpidd and client showed a ton of setsigprocmask() syscalls. These are not cheap. I haven't retested with this new code yet, but I'll be happy to see those useless (in

Re: QPID-2388: Do not unmask signals whilst waiting for IO to happen

2010-08-27 Thread a fabbri
On Fri, Aug 27, 2010 at 12:46 PM, Andrew Stitcher astitc...@redhat.com wrote: On Fri, 2010-08-27 at 12:32 -0700, a fabbri wrote: ... I've not tested, but I'd be very surprised. IIRC, my strace of qpidd and client showed a ton of setsigprocmask() syscalls.  These are not cheap.  I haven't