Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-06-11 Thread rajith attapattu
On May 13, 2013, 3:22 p.m., Robbie Gemmell wrote: http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer.java, lines 744-745 https://reviews.apache.org/r/10738/diff/2/?file=288993#file288993line744 What impact does

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-22 Thread Robbie Gemmell
On May 13, 2013, 3:22 p.m., Robbie Gemmell wrote: http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer.java, lines 744-745 https://reviews.apache.org/r/10738/diff/2/?file=288993#file288993line744 What impact does

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-21 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10738/ --- (Updated May 21, 2013, 2:48 p.m.) Review request for qpid, Robbie Gemmell,

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-21 Thread rajith attapattu
On May 13, 2013, 3:22 p.m., Robbie Gemmell wrote: http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer.java, lines 744-745 https://reviews.apache.org/r/10738/diff/2/?file=288993#file288993line744 What impact does

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-21 Thread rajith attapattu
On May 13, 2013, 3:22 p.m., Robbie Gemmell wrote: http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/BasicMessageConsumer.java, lines 744-745 https://reviews.apache.org/r/10738/diff/2/?file=288993#file288993line744 What impact does

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-20 Thread Robbie Gemmell
On May 13, 2013, 3:22 p.m., Robbie Gemmell wrote: http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnection.java, line 873 https://reviews.apache.org/r/10738/diff/2/?file=288991#file288991line873 Whitespace rajith attapattu

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-20 Thread Robbie Gemmell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10738/#review20770 ---

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-14 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10738/ --- (Updated May 15, 2013, 3:06 a.m.) Review request for qpid, Robbie Gemmell,

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-13 Thread Robbie Gemmell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10738/#review20483 ---

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-13 Thread rajith attapattu
On May 13, 2013, 3:22 p.m., Robbie Gemmell wrote: http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java, lines 255-256 https://reviews.apache.org/r/10738/diff/2/?file=288992#file288992line255 Unused Will mark for

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-13 Thread rajith attapattu
On May 13, 2013, 3:22 p.m., Robbie Gemmell wrote: http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java, line 767 https://reviews.apache.org/r/10738/diff/2/?file=288992#file288992line767 We probably shouldn't catch all

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-05-08 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10738/ --- (Updated May 8, 2013, 2:02 p.m.) Review request for qpid, Robbie Gemmell,

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-27 Thread Robbie Gemmell
On April 24, 2013, 4:24 p.m., Robbie Gemmell wrote: I don't really agree that there is only a slim chance a delivery can begin before the session is marked closed, it actually seems fairly likely to occur (unless none of the queues used by the consumers on the session have any

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-25 Thread rajith attapattu
On April 24, 2013, 4:24 p.m., Robbie Gemmell wrote: I don't really agree that there is only a slim chance a delivery can begin before the session is marked closed, it actually seems fairly likely to occur (unless none of the queues used by the consumers on the session have any

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-24 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10738/ --- (Updated April 24, 2013, 12:19 p.m.) Review request for qpid, Robbie Gemmell,

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-24 Thread Robbie Gemmell
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10738/#review19626 --- I don't really agree that there is only a slim chance a delivery

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-24 Thread rajith attapattu
On April 24, 2013, 4:24 p.m., Robbie Gemmell wrote: I don't really agree that there is only a slim chance a delivery can begin before the session is marked closed, it actually seems fairly likely to occur (unless none of the queues used by the consumers on the session have any

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-24 Thread rajith attapattu
On April 24, 2013, 4:24 p.m., Robbie Gemmell wrote: I don't really agree that there is only a slim chance a delivery can begin before the session is marked closed, it actually seems fairly likely to occur (unless none of the queues used by the consumers on the session have any

Re: Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-24 Thread Robbie Gemmell
On April 24, 2013, 4:24 p.m., Robbie Gemmell wrote: I don't really agree that there is only a slim chance a delivery can begin before the session is marked closed, it actually seems fairly likely to occur (unless none of the queues used by the consumers on the session have any

Review Request: Address deadlock btw _messageDeliveryLock and _failoverMutex

2013-04-23 Thread rajith attapattu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10738/ --- Review request for qpid, Robbie Gemmell, Weston Price, and Rob Godfrey.