Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-05-06 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10020/#review20190 --- Ship it! Ship It! - Alan Conway On May 3, 2013, 7:15 p.m., Chug

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-05-03 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10020/ --- (Updated May 3, 2013, 7:15 p.m.) Review request for qpid, Gordon Sim and Ted

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-04-30 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10020/#review19948 --- trunk/qpid/cpp/src/qpid/broker/Queue.h

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-04-30 Thread Chug Rolke
On April 30, 2013, 12:13 p.m., Gordon Sim wrote: trunk/qpid/cpp/src/qpid/broker/Queue.h, line 172 https://reviews.apache.org/r/10020/diff/5/?file=285775#file285775line172 What happens if someone deletes the queues without explicitly cancelling the redirect? There is a circular

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-04-29 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10020/ --- (Updated April 29, 2013, 6:12 p.m.) Review request for qpid, Gordon Sim and

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-04-25 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10020/#review19739 --- This looks much nicer! Only minor comments.

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-04-03 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10020/ --- (Updated April 3, 2013, 10:08 p.m.) Review request for qpid, Gordon Sim and

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-04-01 Thread Gordon Sim
On March 27, 2013, 2:56 p.m., Gordon Sim wrote: trunk/qpid/cpp/src/qpid/broker/Broker.h, line 167 https://reviews.apache.org/r/10020/diff/3/?file=274538#file274538line167 I wonder if we could come up with a nicer name... Chug Rolke wrote: How does 'redirect' sound? much

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-03-28 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10020/#review18471 --- I'm not completely following this. It looks like declaring an

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-03-28 Thread Chug Rolke
On March 27, 2013, 2:56 p.m., Gordon Sim wrote: trunk/qpid/cpp/src/qpid/broker/Queue.h, line 171 https://reviews.apache.org/r/10020/diff/3/?file=274540#file274540line171 Is there a reason to use a raw pointer rather than a shared pointer? (Not that I see any insurmountable issue

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-03-28 Thread Chug Rolke
On March 28, 2013, 7:50 p.m., Alan Conway wrote: I'm not completely following this. It looks like declaring an overflow-partnership sends messages to queue X to queue Y and vice versa? Why would you want to redirect in both directions? Also I'm a bit puzzled by the name

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-03-28 Thread Alan Conway
On March 28, 2013, 7:50 p.m., Alan Conway wrote: I'm not completely following this. It looks like declaring an overflow-partnership sends messages to queue X to queue Y and vice versa? Why would you want to redirect in both directions? Also I'm a bit puzzled by the name

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-03-27 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10020/#review18422 --- trunk/qpid/cpp/src/qpid/broker/Broker.h

Re: Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-03-25 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10020/ --- (Updated March 26, 2013, 1:54 a.m.) Review request for qpid, Gordon Sim and

Review Request: C++ Broker 'rebind' to steer messages from one queue to others

2013-03-19 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10020/ --- Review request for qpid, Gordon Sim and Ted Ross. Summary (updated)