Re: Review Request: QPID-4424 - prevent multiple threads from processing PollableQueue events simultaneously

2012-11-26 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8147/#review13748 --- Ship it! Ship It! - Cliff Jansen On Nov. 23, 2012, 11:43 p.m.,

Re: Review Request: QPID-4424 - prevent multiple threads from processing PollableQueue events simultaneously

2012-11-24 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8147/#review13701 --- Ship it! this second change looks much better to me. - Andrew

Re: Review Request: QPID-4424 - prevent multiple threads from processing PollableQueue events simultaneously

2012-11-23 Thread Steve Huston
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8147/ --- (Updated Nov. 23, 2012, 11:43 p.m.) Review request for qpid, Andrew Stitcher,

Re: Review Request: QPID-4424 - prevent multiple threads from processing PollableQueue events simultaneously

2012-11-21 Thread Cliff Jansen
On Nov. 21, 2012, 2:57 p.m., Andrew Stitcher wrote: This is not an acceptable change to me. The problem is purely a windows one and the assert provides a valuable check for the Unix platform. Basically I think the windows implementation of PollableQueue is just wrong - or rather

Re: Review Request: QPID-4424 - prevent multiple threads from processing PollableQueue events simultaneously

2012-11-21 Thread Steve Huston
On Nov. 21, 2012, 2:57 p.m., Andrew Stitcher wrote: This is not an acceptable change to me. The problem is purely a windows one and the assert provides a valuable check for the Unix platform. Basically I think the windows implementation of PollableQueue is just wrong - or rather

Review Request: QPID-4424 - prevent multiple threads from processing PollableQueue events simultaneously

2012-11-20 Thread Steve Huston
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8147/ --- Review request for qpid, Andrew Stitcher, Chug Rolke, and Cliff Jansen.