---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7209/
---
(Updated April 26, 2013, 4:21 p.m.)
Review request for qpid, Kenneth Giusti and
On April 25, 2013, 8:46 p.m., Andrew Stitcher wrote:
I really like this code, I think that the issues below are all really nits
(except stopping MemoryMappedFile from having a default copy construct and
assignment operator)
I especially like the improvement of not having to specify
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7209/#review19774
---
Except for the missing encode()/decode() functions this looks good.
On April 26, 2013, 4:34 p.m., Andrew Stitcher wrote:
/trunk/qpid/cpp/src/qpid/broker/Message.h, line 148
https://reviews.apache.org/r/7209/diff/3/?file=284903#file284903line148
Did you actually add these new functions to Message.cpp? They don't
seem to be anywhere in the review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7209/#review19778
---
Ship it!
- Andrew Stitcher
On April 26, 2013, 4:21 p.m., Gordon
On April 26, 2013, 4:34 p.m., Andrew Stitcher wrote:
/trunk/qpid/cpp/src/qpid/broker/Message.h, line 148
https://reviews.apache.org/r/7209/diff/3/?file=284903#file284903line148
Did you actually add these new functions to Message.cpp? They don't
seem to be anywhere in the review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7209/
---
(Updated April 25, 2013, 11:51 a.m.)
Review request for qpid, Kenneth Giusti
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7209/#review19725
---
I really like this code, I think that the issues below are all
On Sept. 21, 2012, 8:06 p.m., Andrew Stitcher wrote:
On the whole I really like this approach. I have one reservation though -
it seems to me that queued messages in memory are actually there twice -
once on the regular queue and once encoded in the page file. Is this
correct? Is it
On Sept. 21, 2012, 8:06 p.m., Andrew Stitcher wrote:
On the whole I really like this approach. I have one reservation though -
it seems to me that queued messages in memory are actually there twice -
once on the regular queue and once encoded in the page file. Is this
correct? Is it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7209/#review11853
---
I also like the approach. You're correct that HA could replace it's
On 09/21/2012 11:14 AM, Gordon Sim wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7209/
---
Review request for qpid, Kenneth
On Sept. 24, 2012, 7:14 p.m., Alan Conway wrote:
I also like the approach. You're correct that HA could replace it's use of
eachMessage with a cursor, and it probably should do so anyway.
I think you will need to consider the case where a single message takes up
more than one page.
On 09/24/2012 09:05 PM, Carl Trieloff wrote:
I assume this queue will not support queue-browsing for example, is that
correct?
No, browsing is supported. However large numbers of browsers going
through a large queue at different speeds could lead to a lot of thrashing.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7209/
---
Review request for qpid, Kenneth Giusti and Ted Ross.
Description
---
==
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7209/#review11799
---
On the whole I really like this approach. I have one reservation
16 matches
Mail list logo
