Re: Review Request: qpid-4330 windows client hang/fault

2012-09-24 Thread Cliff Jansen
On Sept. 21, 2012, 7:22 p.m., Chug Rolke wrote: I ran this patch with extra OutputDebugString calls when the new logic checks threadSafeShutdown. In a typical client program like drain threadSafeShutdown is false every time as expected for IOThreads and for WinSockSetup. On

Re: Review Request: qpid-4330 windows client hang/fault

2012-09-24 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7179/#review11842 --- Ship it! This addresses a root cause of the client crash at exit.

Re: Review Request: qpid-4330 windows client hang/fault

2012-09-21 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7179/#review11796 --- I ran this patch with extra OutputDebugString calls when the new

Review Request: qpid-4330 windows client hang/fault

2012-09-19 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7179/ --- Review request for qpid, Andrew Stitcher, Chug Rolke, and Steve Huston.

Re: Review Request: qpid-4330 windows client hang/fault

2012-09-19 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/7179/#review11717 --- Minor nits follow

Re: Review Request: qpid-4330 windows client hang/fault

2012-09-19 Thread Cliff Jansen
On Sept. 19, 2012, 8:42 p.m., Andrew Stitcher wrote: http://svn.apache.org/repos/asf/qpid/trunk/qpid/cpp/src/qpid/sys/windows/QpidDllMain.h, line 48 https://reviews.apache.org/r/7179/diff/1/?file=158587#file158587line48 Shouldn't this be defined in the .cpp file? If the