Review Request 12275: Platform neutral helper functions.

2013-07-05 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/ --- Review request for qpid, Andrew Stitcher, Kenneth Giusti, and Rafael Schloming.

Re: Review Request 12275: Platform neutral helper functions.

2013-07-05 Thread Kenneth Giusti
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/#review22782 ---

Re: Review Request 12275: Platform neutral helper functions.

2013-07-05 Thread Kenneth Giusti
On July 5, 2013, 2:50 p.m., Kenneth Giusti wrote: http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.h, line 15 https://reviews.apache.org/r/12275/diff/1/?file=318334#file318334line15 I suspect that this condition conflicts with the ASL

Re: Review Request 12275: Platform neutral helper functions.

2013-07-05 Thread Andrew Stitcher
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/#review22786 --- This looks fine, if a little messy (but less messy than the

Re: Review Request 12275: Platform neutral helper functions.

2013-07-05 Thread Chug Rolke
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12275/#review22788 ---

Re: Review Request 12275: Platform neutral helper functions.

2013-07-05 Thread Cliff Jansen
On July 5, 2013, 2:50 p.m., Kenneth Giusti wrote: http://svn.apache.org/repos/asf/qpid/proton/trunk/examples/include/pncompat/internal/getopt.h, line 15 https://reviews.apache.org/r/12275/diff/1/?file=318334#file318334line15 I suspect that this condition conflicts with the ASL