Re: Review Request 12289: QPID-4327: HA added PrimaryTransactionObserver.

2013-07-11 Thread Alan Conway
> On July 11, 2013, 10:04 a.m., Gordon Sim wrote: > > /trunk/qpid/cpp/src/qpid/broker/TransactionObserver.h, line 59 > > > > > > Is there a reason not to have QueuePtr and Message as the two arguments > > for dequeue a

Re: Review Request 12289: QPID-4327: HA added PrimaryTransactionObserver.

2013-07-11 Thread Gordon Sim
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12289/#review23009 --- /trunk/qpid/cpp/src/qpid/broker/TransactionObserver.h

Re: Review Request 12289: QPID-4327: HA added PrimaryTransactionObserver.

2013-07-10 Thread Alan Conway
> On July 8, 2013, 12:10 p.m., Gordon Sim wrote: > > /trunk/qpid/cpp/src/qpid/broker/TransactionObserver.h, line 48 > > > > > > It's really the enqueue and dequeue operations that are transactional. > > It might be bet

Re: Review Request 12289: QPID-4327: HA added PrimaryTransactionObserver.

2013-07-10 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12289/ --- (Updated July 10, 2013, 10:28 p.m.) Review request for qpid, Andrew Stitcher an

Re: Review Request 12289: QPID-4327: HA added PrimaryTransactionObserver.

2013-07-09 Thread Alan Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12289/ --- (Updated July 9, 2013, 9:29 p.m.) Review request for qpid, Andrew Stitcher and