Re: Review Request 30898: Reactor send and receive soak test programs

2015-02-20 Thread Rafael Schloming
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30898/#review73279 --- Ship it! Ship It! - Rafael Schloming On Feb. 19, 2015, 8:26

Re: Review Request 30898: Reactor send and receive soak test programs

2015-02-20 Thread Rafael Schloming
On Feb. 12, 2015, 3:11 p.m., Rafael Schloming wrote: tests/tools/apps/c/reactor-recv.c, line 300 https://reviews.apache.org/r/30898/diff/1/?file=861148#file861148line300 Why are you creating a new handler for each incoming connection? Unless the handler holds per connection state

Re: Review Request 30898: Reactor send and receive soak test programs

2015-02-20 Thread Cliff Jansen
On Feb. 12, 2015, 3:11 p.m., Rafael Schloming wrote: tests/tools/apps/c/reactor-recv.c, line 300 https://reviews.apache.org/r/30898/diff/1/?file=861148#file861148line300 Why are you creating a new handler for each incoming connection? Unless the handler holds per connection state

Re: Review Request 30898: Reactor send and receive soak test programs

2015-02-19 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30898/ --- (Updated Feb. 19, 2015, 8:26 p.m.) Review request for qpid and Rafael

Re: Review Request 30898: Reactor send and receive soak test programs

2015-02-19 Thread Cliff Jansen
On Feb. 12, 2015, 3:11 p.m., Rafael Schloming wrote: tests/tools/apps/c/reactor-recv.c, line 300 https://reviews.apache.org/r/30898/diff/1/?file=861148#file861148line300 Why are you creating a new handler for each incoming connection? Unless the handler holds per connection state

Re: Review Request 30898: Reactor send and receive soak test programs

2015-02-12 Thread Rafael Schloming
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30898/#review72105 --- tests/tools/apps/c/reactor-recv.c

Review Request 30898: Reactor send and receive soak test programs

2015-02-11 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30898/ --- Review request for qpid and Rafael Schloming. Bugs: PROTRON-818

Re: Review Request 30898: Reactor send and receive soak test programs

2015-02-11 Thread Cliff Jansen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30898/ --- (Updated Feb. 12, 2015, 2:58 a.m.) Review request for qpid and Rafael